plugins/lsp: add gdscript package #3048
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattSturgeon
commented
Mar 4, 2025
| @@ -237,6 +236,7 @@ | |||
| fsautocomplete = "fsautocomplete"; | |||
| fstar = "fstar"; | |||
| futhark_lsp = "futhark"; | |||
| gdscript = "gdtoolkit_4"; | |||
There was a problem hiding this comment.
Actually, I'm not sure this is correct. GD Toolkit doesn't mention a language server.
Perhaps the correct package is godot_4?
There was a problem hiding this comment.
The LSP is actually part of the Godot editor itself. The client connects via TCP to a running Godot instance rather than launching a separate process. Since users need to manually start Godot anyway and likely have it installed already, we probably shouldn't add it as a dependency for GDScript LSP in Nixvim. But maybe just document this behavior instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1359 (comment)