Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins/lsp: add gdscript package #3048

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

plugins/lsp: add gdscript package #3048

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/lsp/lsp-packages.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@
"flux_lsp"
"foam_ls"
"fsharp_language_server"
"gdscript"
"gdshader_lsp"
"gh_actions_ls"
"ghdl_ls"
Expand Down Expand Up @@ -237,6 +236,7 @@
fsautocomplete = "fsautocomplete";
fstar = "fstar";
futhark_lsp = "futhark";
gdscript = "gdtoolkit_4";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I'm not sure this is correct. GD Toolkit doesn't mention a language server.

Perhaps the correct package is godot_4?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The LSP is actually part of the Godot editor itself. The client connects via TCP to a running Godot instance rather than launching a separate process. Since users need to manually start Godot anyway and likely have it installed already, we probably shouldn't add it as a dependency for GDScript LSP in Nixvim. But maybe just document this behavior instead.

ghcide = [
"haskellPackages"
"ghcide"
Expand Down