-
Notifications
You must be signed in to change notification settings - Fork 31.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dns: restore dns query cache ttl #57640
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
Ethan-Arrowood:fix-dns-resolve-cache
Apr 7, 2025
Merged
dns: restore dns query cache ttl #57640
nodejs-github-bot
merged 1 commit into
nodejs:main
from
Ethan-Arrowood:fix-dns-resolve-cache
Apr 7, 2025
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
Fixes: nodejs#57636 Co-authored-by: Robert Nagy <ronagy@icloud.com>
da48077
to
61f93c1
Compare
mcollina
approved these changes
Mar 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Can you open the follow-up issue to track that work?
ronag
approved these changes
Mar 26, 2025
pimterry
approved these changes
Mar 26, 2025
lpinca
approved these changes
Mar 26, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57640 +/- ##
==========================================
- Coverage 90.22% 90.22% -0.01%
==========================================
Files 630 630
Lines 185055 185056 +1
Branches 36216 36218 +2
==========================================
- Hits 166975 166963 -12
- Misses 11042 11047 +5
- Partials 7038 7046 +8
🚀 New features to boost your workflow:
|
BridgeAR
approved these changes
Mar 26, 2025
jasnell
approved these changes
Apr 5, 2025
Landed in b85505d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
backport-requested-v20.x
PRs awaiting manual backport to the v20.x-staging branch.
backport-requested-v22.x
PRs awaiting manual backport to the v22.x-staging branch.
backport-requested-v23.x
PRs awaiting manual backport to the v23.x-staging branch.
backport-requested-v24.x
PRs awaiting manual backport to the v24.x-staging branch.
c++
Issues and PRs that require attention from people who are familiar with C++.
cares
Issues and PRs related to the c-ares dependency or the cares_wrap binding.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #57636
When c-ares was updated the default caching behavior changed.
This PR restores the caching behavior by setting
qcache_max_ttl
to0
.This change in c-ares is reasonable; thus, as a follow up to this fix, we should implement a cache management API for DNS queries and then re-enable the new default cache value. Tracking issue for follow up work: #57641