modules: fota: Cleanup and update tests #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simensrostad
force-pushed
the
cleanupfotamodule
branch
12 times, most recently
from
1b28ccd to
e8100a2
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🎯 Core Changes:
- Refactored FOTA module state machine to handle firmware updates more robustly
- Added unit tests for FOTA module
- Removed redundant debug logging in network module
- Updated nRF SDK dependency to newer version
None identified - changes improve code quality and testability
Verdict: Approve - Changes add test coverage and improve code organization with no breaking changes
Code review performed by ANTHROPIC - claude-3-5-sonnet-20241022.
simensrostad
force-pushed
the
cleanupfotamodule
branch
3 times, most recently
from
8d5c93d to
4b2e232
Compare
Cleanup module according to interval state diagrams Update tests Diagrams will be publica later Signed-off-by: Simen S. Røstad <simen.rostad@nordicsemi.no>
Remove logging in `_run` SMF functions to avoid bloating application logs. Signed-off-by: Simen S. Røstad <simen.rostad@nordicsemi.no>
Add Kconfig to disable network quality sampling. Disable network quality sampling by default until we have a fix in the modem firmware to run CONEVAL and NCELLMEAS at the same time. Signed-off-by: Simen S. Røstad <simen.rostad@nordicsemi.no>
simensrostad
force-pushed
the
cleanupfotamodule
branch
from
4b2e232 to
bbaeef8
Compare
fix issues pointed out by static analysis Signed-off-by: Simen S. Røstad <simen.rostad@nordicsemi.no>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup module according to interval state diagrams Update tests
Diagrams will be publica later