Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nrf noup] Enable a depency of MBEDTLS_X509_CREATE_C #409

Closed
wants to merge 1 commit into from
Closed

[nrf noup] Enable a depency of MBEDTLS_X509_CREATE_C #409

wants to merge 1 commit into from

Conversation

SebastianBoe
Copy link

We are enabling MBEDTLS_X509_CREATE_C, but not it's dependency MBEDTLS_X509_LIBRARY.

Also enable MBEDTLS_X509_LIBRARY in case it's default value changes.

!!!!!!!!!! Please delete the instructions below and replace with PR description

If you have an issue number, please use a syntax of
Fixes #12345 and a brief change description

If you do not have an issue number, please have a good description of
the problem and the fix. Help the reviewer understand what to expect.

Make sure you delete these instructions (to prove you have read them).

!!!!!!!!!! Instructions end

@NordicBuilder NordicBuilder mentioned this pull request Mar 12, 2024
Closed
@ArekBalysNordic
Copy link
Contributor

The unit test fails are not related to your PR. They will be fixed in #411

@SebastianBoe SebastianBoe force-pushed the more_reasonable_defaults branch from 76a6694 to 84a9595 Compare April 11, 2024 10:53
@SebastianBoe
[nrf noup] Enable a depency of MBEDTLS_X509_CREATE_C
6411b4e 
We are enabling MBEDTLS_X509_CREATE_C, but not it's dependency
MBEDTLS_X509_LIBRARY.

Also enable MBEDTLS_X509_LIBRARY in case it's default value changes.

Signed-off-by: Sebastian Bøe <sebastian.boe@nordicsemi.no>
@SebastianBoe SebastianBoe force-pushed the more_reasonable_defaults branch from 84a9595 to 6411b4e Compare April 11, 2024 14:20
@SebastianBoe
Copy link
Author

I'm giving up on this.

I expect this to change significantly soon anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@ArekBalysNordic ArekBalysNordic ArekBalysNordic approved these changes

@LuDuda LuDuda Awaiting requested review from LuDuda

Assignees
No one assigned
Labels
config
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SebastianBoe @ArekBalysNordic @Damian-Nordic