[nrf fromlist][nrfconnect] Improve CHIP_MEMORY_PROFILING config #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Damian-Nordic
approved these changes
Apr 3, 2024
|
Also, can you please describe why SHELL_MINIMAL is undesired? It doesn't seem related to the profiling feature. |
It was requested by QA to have it because it helps with using all SHELL components like KERNEL_SHELL, CHIP_SHELL, and NET_SHELL. |
ArekBalysNordic
force-pushed
the
memory_profiling_improvements
branch
from
0a609e6 to
55f2b45
Compare
LuDuda
reviewed
Apr 3, 2024
kkasperczyk-no
approved these changes
Apr 4, 2024
- Enabled the full SHELL option when memory profiling is enabled.
ArekBalysNordic
force-pushed
the
memory_profiling_improvements
branch
from
55f2b45 to
247ce52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled the full SHELL option when memory profiling is enabled.