[nrf toup] [nrfconnect] Disable External FD if QSPI NOR is not available #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to have support for factory data when the partition manager is enabled but there is no support for QSPI external flash.
ArekBalysNordic
force-pushed
the
nrf54l15_partition_manager
branch
from
bc98adf to
8a76cd2
Compare
markaj-nordic
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
The ExternalFlashFactoryData is not used anywhere anyway, so was there a problem with that or it's just a matter of optimization?
Should we add the same condition when instantiating the concrete template classes in at the bottom of the FactoryDataProvider.cpp file?
Actually, I don't know why we haven't removed the external flash support from there yet... |
kkasperczyk-no
approved these changes
Apr 22, 2024
LuDuda
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to have support for factory data when the partition manager is enabled but there is no support for QSPI external flash.