[nrfconnect] Reconfigure memory pool sizes #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krish2718
reviewed
Mar 29, 2025
With introduction of dedicated memory pools for nRF70 Wi-Fi driver, redistribute current heap size among the driver heap and kernel heap. Signed-off-by: Ravi Dondaputi <ravi.dondaputi@nordicsemi.no>
rado17
force-pushed
the
mem_pool_configuration
branch
from
5b2d9dd to
cf283cb
Compare
krish2718
approved these changes
Mar 29, 2025
| default 40144 | ||
|
|
||
| config NRF_WIFI_DATA_HEAP_SIZE | ||
| default 50576 if BUILD_WITH_TFM |
There was a problem hiding this comment.
Where do these values come from? The description says "redistribute", but the given sizes do not sum up to 110720. Are you sure it's safe to decrease the pool size?
LuDuda
approved these changes
Mar 31, 2025
There was a problem hiding this comment.
If the values are confirmed then, it's great to see the optimization!
I would run the nightly tests on it (we might do it also after the merge?) - @doublemis1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With introduction of dedicated memory pools for nRF70 Wi-Fi driver, redistribute current heap size among the
driver heap and kernel heap.