-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix block_cipher configuration #41
Merged
nordicjm
merged 8 commits into
nrfconnect:main
from
tomi-font:fix_block-cipher_configuration
Mar 24, 2025
Merged
fix block_cipher configuration #41
nordicjm
merged 8 commits into
nrfconnect:main
from
tomi-font:fix_block-cipher_configuration
Mar 24, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MD/CIPHER" This reverts commit 98603a8. Temporary revert to rework some conflicting commits. Signed-off-by: Tomi Fontanilles <tomi.fontanilles@nordicsemi.no>
ffe3291
to
309e5bf
Compare
This reverts commit 2cc273b. Reverting this noup to split it into its different logical parts. Part of the changes in this noup is re-applied from upstream commits now that PR 9562 is merged upstream. Signed-off-by: Tomi Fontanilles <tomi.fontanilles@nordicsemi.no>
…abled Instead of allowing PSA dispatching only when CRYPTO_C is set and some MBEDTLS_PSA_ACCEL_ALG_xxx is set, we enable dispatching when CRYPTO_CLIENT and PSA_WANT_ALG_xxx are set. This makes the feature more useful in cases where the PSA support is provided externally, like for example TF-M in Zephyr. This commit also add proper guards for tests trying to use MD+PSA dispatch. Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no> (cherry picked from commit c516307ad90d24de7f6f83e6b2fd825329ce5824) Signed-off-by: Tomi Fontanilles <tomi.fontanilles@nordicsemi.no>
This change is re-applied from commit 2cc273b that was reverted to split it into separate noups. Signed-off-by: Tomi Fontanilles <tomi.fontanilles@nordicsemi.no>
Make definitions from md.h available in psa_util.h. This change is re-applied from commit 2cc273b that was reverted to split it into separate noups. This is needed otherwise we get errors regarding missing definitions, e.g. of mbedtls_md_type_t in mbedtls_md_type_from_psa_alg(). Signed-off-by: Tomi Fontanilles <tomi.fontanilles@nordicsemi.no>
Make block_cipher call into PSA. This allows code calling legacy CCM/GCM to end up calling PSA Crypto, especially useful from NS when TF-M is in use. This change is re-applied from commit 2cc273b that was reverted to split it into separate noups. Signed-off-by: Tomi Fontanilles <tomi.fontanilles@nordicsemi.no>
-This allows TF-M minimal configuration to stil dispatch using legacy while we are waiting for more apps/samples to be ported to use PSA crypto APIs Signed-off-by: Frank Audun Kvamtrø <frank.kvamtro@nordicsemi.no> (edited cherry pick of 98603a8) Signed-off-by: Tomi Fontanilles <tomi.fontanilles@nordicsemi.no>
309e5bf
to
918f858
Compare
frkv
approved these changes
Mar 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Vge0rge
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages.