suit: Do not erase on IPUC write setup #21056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahasztag
requested review from
tomchy,
robertstypa,
adsz-nordic and
nordic-mik7
github-actions
bot
added
the
changelog-entry-required
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: b2a897a5f969444968bd4d89a5b2cb45327a35f9 more detailssdk-nrf:
Github labels
List of changed files detected by CI (1)Outputs:ToolchainVersion: 4ffa2202d5 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
ahasztag
force-pushed
the
NCSDK-32433_no_erase_on_ipuc_setup
branch
4 times, most recently
from
5cd42f1 to
d0c0028
Compare
tomchy
reviewed
Mar 20, 2025
ahasztag
force-pushed
the
NCSDK-32433_no_erase_on_ipuc_setup
branch
from
d0c0028 to
b2a897a
Compare
Erasing of the IPUC took about 500ms of time, which led to many issues. The erasing was removed, instead different security measures were introduced, erasing parts when the seek offset is greater than the write peek offset. Signed-off-by: Artur Hadasz <artur.hadasz@nordicsemi.no>
ahasztag
force-pushed
the
NCSDK-32433_no_erase_on_ipuc_setup
branch
from
b2a897a to
f377b05
Compare
tomchy
approved these changes
Mar 20, 2025
|
robertstypa
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Erasing of the IPUC took about 500ms of time, which led to many issues.
The erasing was removed, instead different security measures were introduced, erasing parts when the
seek offset is greater than the write peek offset.