Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suit: Do not erase on IPUC write setup #21056

Merged
merged 1 commit into from
Mar 20, 2025
Merged

suit: Do not erase on IPUC write setup #21056

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions subsys/suit/ipuc/src/suit_ipuc_sdfw.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,15 +297,6 @@ suit_plat_err_t suit_ipuc_sdfw_write_setup(int ipc_client_id, struct zcbor_strin
suit_plat_digest_cache_remove(component_id);
#endif /* CONFIG_SUIT_DIGEST_CACHE */

if (ipuc_sink.erase == NULL ||
ipuc_sink.erase(ipuc_sink.ctx) != SUIT_PLAT_SUCCESS) {
LOG_ERR("Erase operation not supported or failed");
if (ipuc_sink.release) {
ipuc_sink.release(ipuc_sink.ctx);
}
k_mutex_unlock(&ipuc_mutex);
return SUIT_PLAT_ERR_IO;
}

if (ipuc_sink.release) {
ipuc_sink.release(ipuc_sink.ctx);
Expand Down Expand Up @@ -371,6 +362,22 @@ suit_plat_err_t suit_ipuc_sdfw_write(int ipc_client_id, struct zcbor_string *com
return SUIT_PLAT_ERR_IO;
}

if ((ipuc_sink.write != NULL) && (ipuc_sink.seek != NULL)
&& (offset > ipuc_entry->write_peek_offset)) {
/* Erasing if necessary
*/
uint8_t erase_buffer[READ_CHUNK_MAX_SIZE] = {
[0 ... READ_CHUNK_MAX_SIZE - 1] = 0xFF
};

ipuc_sink.seek(ipuc_sink.ctx, ipuc_entry->write_peek_offset);
for (size_t off = ipuc_entry->write_peek_offset; off < offset;
off += READ_CHUNK_MAX_SIZE) {
ipuc_sink.write(ipuc_sink.ctx, (uint8_t *)erase_buffer,
MIN(sizeof(erase_buffer), slot_size - off));
}
}

if (ipuc_sink.seek == NULL ||
ipuc_sink.seek(ipuc_sink.ctx, offset) != SUIT_PLAT_SUCCESS) {
LOG_ERR("Seek operation not supported or failed");
Expand Down