tests: drivers: Add QSPI driver test with single line mode #21061

nordic-bami · 2025-03-20T11:44:53Z

This test is introduced due to customer bug report: Failure on QSPI flash used in non-Quad mode (single line)

NordicBuilder · 2025-03-20T11:49:57Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 9

Inputs:

Sources:

sdk-nrf: PR head: 8ec1a8565a70eacaaab207c05f0819b33fc99125

more details

sdk-nrf:

PR head: 8ec1a8565a70eacaaab207c05f0819b33fc99125
merge base: 4c623e64e60633b234c20150d040be7e560c5b50
target head (main): 73c22404b5f96682749c379881cddb473eb84978
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (6)

CODEOWNERS
scripts
│  ├── ci
│  │  │ tags.yaml
tests
│  ├── drivers
│  │  ├── nrf_qspi_flash
│  │  │  ├── CMakeLists.txt
│  │  │  ├── flash_cfg
│  │  │  │  │ mx25r64_single_line.overlay
│  │  │  ├── prj.conf
│  │  │  │ testcase.yaml

Outputs:

Toolchain

Version: 4ffa2202d5
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:4ffa2202d5_e579f9fbe6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister
- sdk-nrf test count: 38
✅ Integration tests

Disabled integration tests

- desktop52_verification
- doc-internal
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_mesh
- test-fw-nrfconnect-ble_samples
- test-fw-nrfconnect-boot
- test-fw-nrfconnect-chip
- test-fw-nrfconnect-fem
- test-fw-nrfconnect-nfc
- test-fw-nrfconnect-nrf-iot_cloud
- test-fw-nrfconnect-nrf-iot_libmodem-nrf
- test-fw-nrfconnect-nrf-iot_mosh
- test-fw-nrfconnect-nrf-iot_positioning
- test-fw-nrfconnect-nrf-iot_samples
- test-fw-nrfconnect-nrf-iot_serial_lte_modem
- test-fw-nrfconnect-nrf-iot_thingy91
- test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- test-fw-nrfconnect-nrf_crypto
- test-fw-nrfconnect-proprietary_esb
- test-fw-nrfconnect-ps
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-rs
- test-fw-nrfconnect-tfm
- test-fw-nrfconnect-thread
- test-fw-nrfconnect-zigbee
- test-low-level
- test-sdk-audio
- test-sdk-dfu
- test-sdk-find-my
- test-sdk-mcuboot
- test-sdk-pmic-samples
- test-sdk-wifi
- test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

nordic-bami · 2025-03-20T12:49:49Z

Please review: @nrfconnect/ncs-co-build-system @nrfconnect/ncs-test-leads @nrfconnect/ncs-code-owners

nordicjm · 2025-03-20T12:56:08Z

tests/drivers/nrf_qspi_flash/CMakeLists.txt

+if(NOT SYSBUILD)
+	message(FATAL_ERROR
+		" This is a multi-image application that should be built using sysbuild.\n"
+		" Add --sysbuild argument to west build command to prepare all the images.")
+endif()


nordicjm · 2025-03-20T12:56:21Z

tests/drivers/nrf_qspi_flash/flash_cfg/mx25r64_single_line.overlay

+ */
+
+&mx25r64 {
+	status="okay";


spaces lacking

What tab size is required ?

nordicjm · 2025-03-20T12:56:50Z

tests/drivers/nrf_qspi_flash/testcase.yaml

+    integration_platforms:
+      - nrf52840dk/nrf52840
+      - nrf5340dk/nrf5340/cpuapp
+    harness: console


I don't see the point in this being added to sdk-nrf, add it to upstream zephyr instead?

This case is NRF specific and related to NRF devices only past driver bug

Yes? You can add a nordic specific test upstream, nrf_qspi_flash is a nordic driver, it won't run on e.g. stm32 platforms

I can do this, but what is the point ? It will be slower and maintaining it will be more complicated

This test is introduced due to customer bug report: Failure on QSPI flash used in non-Quad mode (single line) Signed-off-by: Bartosz Miller <bartosz.miller@nordicsemi.no>

sonarqubecloud · 2025-03-20T13:10:20Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

nordic-bami requested review from a team as code owners March 20, 2025 11:44

github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 20, 2025

nordic-bami marked this pull request as draft March 20, 2025 11:45

nordic-bami force-pushed the implement_mspi_mode_switch_test branch from 6b8313f to 544e17e Compare March 20, 2025 11:46

nordic-bami marked this pull request as ready for review March 20, 2025 11:46

nordic-bami force-pushed the implement_mspi_mode_switch_test branch from 544e17e to 04a84f4 Compare March 20, 2025 11:51

github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 20, 2025

nordic-bami force-pushed the implement_mspi_mode_switch_test branch from 04a84f4 to fbcceea Compare March 20, 2025 11:53

nordic-segl approved these changes Mar 20, 2025

View reviewed changes

nordic-pikr approved these changes Mar 20, 2025

View reviewed changes

nordic-bami force-pushed the implement_mspi_mode_switch_test branch 2 times, most recently from 09972e6 to a92aa82 Compare March 20, 2025 12:02

nordic-bami requested review from nordic-piks, PerMac, katgiadla and a team as code owners March 20, 2025 12:02

nordic-piks approved these changes Mar 20, 2025

View reviewed changes

nordic-bami force-pushed the implement_mspi_mode_switch_test branch 2 times, most recently from 24281e8 to 288dcb7 Compare March 20, 2025 12:32

nordicjm requested changes Mar 20, 2025

View reviewed changes

tests: drivers: Add QSPI driver test with single line mode

8ec1a85

This test is introduced due to customer bug report: Failure on QSPI flash used in non-Quad mode (single line) Signed-off-by: Bartosz Miller <bartosz.miller@nordicsemi.no>

nordic-bami force-pushed the implement_mspi_mode_switch_test branch from 288dcb7 to 8ec1a85 Compare March 20, 2025 13:04

nordic-bami closed this Mar 20, 2025

nordic-bami deleted the implement_mspi_mode_switch_test branch March 20, 2025 14:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tests: drivers: Add QSPI driver test with single line mode #21061

tests: drivers: Add QSPI driver test with single line mode #21061

nordic-bami commented Mar 20, 2025

NordicBuilder commented Mar 20, 2025 •

edited

Loading

nordic-bami commented Mar 20, 2025

nordicjm Mar 20, 2025

nordic-bami Mar 20, 2025

nordicjm Mar 20, 2025

nordic-bami Mar 20, 2025

nordicjm Mar 20, 2025

nordic-bami Mar 20, 2025 •

edited

Loading

nordicjm Mar 20, 2025

nordic-bami Mar 20, 2025

sonarqubecloud bot commented Mar 20, 2025

tests: drivers: Add QSPI driver test with single line mode #21061

tests: drivers: Add QSPI driver test with single line mode #21061

Conversation

nordic-bami commented Mar 20, 2025

NordicBuilder commented Mar 20, 2025 • edited Loading

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

nordic-bami commented Mar 20, 2025

nordicjm Mar 20, 2025

Choose a reason for hiding this comment

nordic-bami Mar 20, 2025

Choose a reason for hiding this comment

nordicjm Mar 20, 2025

Choose a reason for hiding this comment

nordic-bami Mar 20, 2025

Choose a reason for hiding this comment

nordicjm Mar 20, 2025

Choose a reason for hiding this comment

nordic-bami Mar 20, 2025 • edited Loading

Choose a reason for hiding this comment

nordicjm Mar 20, 2025

Choose a reason for hiding this comment

nordic-bami Mar 20, 2025

Choose a reason for hiding this comment

sonarqubecloud bot commented Mar 20, 2025

Quality Gate passed

NordicBuilder commented Mar 20, 2025 •

edited

Loading

nordic-bami Mar 20, 2025 •

edited

Loading