tests: drivers: Add QSPI driver test with single line mode #21061
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # | ||
| # Copyright (c) 2025 Nordic Semiconductor ASA | ||
| # | ||
| # SPDX-License-Identifier: LicenseRef-Nordic-5-Clause | ||
| # | ||
|
|
||
| cmake_minimum_required(VERSION 3.20.0) | ||
|
|
||
| find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE}) | ||
|
|
||
| project(nrf_qspi_flash) | ||
|
|
||
| target_sources(app PRIVATE ${ZEPHYR_BASE}/samples/drivers/spi_flash/src/main.c) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| /* | ||
| * Copyright (c) 2025 Nordic Semiconductor ASA | ||
| * | ||
| * SPDX-License-Identifier: LicenseRef-Nordic-5-Clause | ||
| */ | ||
|
|
||
| &mx25r64 { | ||
| status="okay"; | ||
| readoc="fastread"; | ||
| writeoc="pp"; | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| CONFIG_FLASH=y | ||
| CONFIG_ASSERT=y | ||
|
|
||
| CONFIG_PRINTK=y | ||
| CONFIG_LOG=y | ||
| CONFIG_CONSOLE=y | ||
| CONFIG_UART_CONSOLE=y | ||
| CONFIG_SERIAL=y |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| common: | ||
| sysbuild: true | ||
| depends_on: spi | ||
|
|
||
| tests: | ||
| tests.drivers.nrf_qspi_flash.qspi_multi_line_mode: | ||
| tags: | ||
| - ci_tests_drivers_flash | ||
| - drivers | ||
| - flash | ||
| - spi | ||
| platform_allow: | ||
| - nrf52840dk/nrf52840 | ||
| - nrf5340dk/nrf5340/cpuapp | ||
| integration_platforms: | ||
| - nrf52840dk/nrf52840 | ||
| - nrf5340dk/nrf5340/cpuapp | ||
| harness: console | ||
|
There was a problem hiding this comment. I don't see the point in this being added to sdk-nrf, add it to upstream zephyr instead? There was a problem hiding this comment. This case is NRF specific and related to NRF devices only past driver bug There was a problem hiding this comment. Yes? You can add a nordic specific test upstream, nrf_qspi_flash is a nordic driver, it won't run on e.g. stm32 platforms There was a problem hiding this comment. I can do this, but what is the point ? It will be slower and maintaining it will be more complicated |
||
| harness_config: | ||
| type: multi_line | ||
| ordered: true | ||
| regex: | ||
| - ".*Flash erase succeeded.*" | ||
| - ".*Data read matches data written. Good.*" | ||
|
|
||
| tests.drivers.nrf_qspi_flash.qspi_single_line_mode: | ||
| tags: | ||
| - ci_tests_drivers_flash | ||
| - drivers | ||
| - flash | ||
| - spi | ||
| platform_allow: | ||
| - nrf52840dk/nrf52840 | ||
| - nrf5340dk/nrf5340/cpuapp | ||
| integration_platforms: | ||
| - nrf52840dk/nrf52840 | ||
| - nrf5340dk/nrf5340/cpuapp | ||
| extra_args: | ||
| - EXTRA_DTC_OVERLAY_FILE="flash_cfg/mx25r64_single_line.overlay" | ||
| harness: console | ||
| harness_config: | ||
| type: multi_line | ||
| ordered: true | ||
| regex: | ||
| - ".*Flash erase succeeded.*" | ||
| - ".*Data read matches data written. Good.*" | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spaces lacking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What tab size is required ?