Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applications: nrf_desktop: Fix dvfs module consuming event #21140

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zycz
Copy link
Contributor

@zycz zycz commented Mar 25, 2025

FIX nrf_desktop dvfs module consuming
ble_peer_conn_params event when it should not.

JIRA: NCSDK-31478

@zycz zycz requested a review from a team as a code owner March 25, 2025 14:10
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 25, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 25, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 2

Inputs:

Sources:

sdk-nrf: PR head: d93e78642a3abeadff1bce8c892fd57704416d0b

more details

sdk-nrf:

PR head: d93e78642a3abeadff1bce8c892fd57704416d0b
merge base: 7fa043ff26e1c878958200d3e69bc323008c76a4
target head (main): 7fa043ff26e1c878958200d3e69bc323008c76a4
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (1)
applications
│  ├── nrf_desktop
│  │  ├── src
│  │  │  ├── modules
│  │  │  │  │ dvfs.c

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain
  • ◻️ Build twister
  • ◻️ Integration tests
    • ◻️ desktop52_verification
Disabled integration tests
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@@ -300,7 +300,7 @@ static bool handle_ble_peer_conn_params_event(const struct ble_peer_conn_params_
process_dvfs_states(DVFS_STATE_LLPM_CONNECTED,
event->interval_min & REG_CONN_INTERVAL_LLPM_MASK);

return true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a known issue

Copy link

You can find the documentation preview for this PR here.

FIX nrf_desktop dvfs module consuming
ble_peer_conn_params event when it should not.

JIRA: NCSDK-31478

Signed-off-by: Jan Zyczkowski <jan.zyczkowski@nordicsemi.no>
@zycz zycz force-pushed the issue31478_lilium_desktop_suspend branch from 3751fa5 to d93e786 Compare March 25, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants