Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applications: nrf_desktop: Fix dvfs module consuming event #21140

Merged
merged 1 commit into from
Mar 26, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion applications/nrf_desktop/src/modules/dvfs.c
Original file line number Diff line number Diff line change
@@ -300,7 +300,7 @@ static bool handle_ble_peer_conn_params_event(const struct ble_peer_conn_params_
process_dvfs_states(DVFS_STATE_LLPM_CONNECTED,
event->interval_min & REG_CONN_INTERVAL_LLPM_MASK);

return true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a known issue

return false;
}
static void dvfs_state_timeout_work_handler(struct k_work *work)
{
Original file line number Diff line number Diff line change
@@ -335,6 +335,9 @@ nRF Desktop
The negative impact of USB polling jitter is more visible in case of USB High-Speed.
* The Fast Pair sysbuild configurations to align the application with the sysbuild Kconfig changes for controlling the Fast Pair provisioning process.
The Nordic device models intended for demonstration purposes are now supplied by default in the nRF Desktop Fast Pair configurations.
* The :ref:`nrf_desktop_dvfs` to no longer consume the :c:struct:`ble_peer_conn_params_event`.
This allows to propagate the event to further listeners of the same or lower priority.
This prevents an issue where :ref:`nrf_desktop_ble_latency` is not informed about the connection parameter update (it might cause missing connection latency updates).

* Removed: