Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sample: set STATIC_INIT_GNU for the sidewalk sample #616

Merged
merged 3 commits into from
Oct 4, 2024
Merged

sample: set STATIC_INIT_GNU for the sidewalk sample #616

merged 3 commits into from
Oct 4, 2024

Conversation

tejlmand
Copy link
Contributor

@tejlmand tejlmand commented Sep 24, 2024 •
edited by ktaborowski
Loading

The sidewalk sample linking places stack_protector from the C library in the init_array sections.

For proper initialization in Zephyr then content in this init_array section requires STATIC_INIT_GNU to be configured.

CI parameters

Github_actions:
  #(branch, hash, pull/XXX/head)
  NRF_revision: pull/16860/head

  # Do not change after creating PR
  Create_NRF_PR: false
Jenkins:
  test-sdk-sidewalk: master

Description

JIRA ticket:

Self review

  • There is no commented code.
  • There are no TODO/FIXME comments without associated issue ticket.
  • Commits are properly organized.
  • Change has been tested.
  • Tests were updated (if applicable).

@github-actions github-actions bot added the source PR changing src files label Sep 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

Sample diff used total
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.dut RAM 428 B 139.57 KB 0 B
ROM -2.56 KB 493.49 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.dut.no_secure RAM 428 B 139.56 KB 0 B
ROM -3.13 KB 482.05 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello RAM 428 B 117.05 KB 0 B
ROM -2.48 KB 439.35 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.ble_only RAM 428 B 90.33 KB 0 B
ROM -2.43 KB 343.73 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.ble_only.release RAM 428 B 85.56 KB 0 B
ROM -2.99 KB 275.45 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.release RAM 428 B 100.94 KB 0 B
ROM -2.96 KB 351.76 KB 0 B
thingy53/nrf5340/cpuapp:sample.sidewalk.demo.ble_only RAM 368 B 105.71 KB 0 B
ROM -741 B 335.81 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.demo RAM -888 B 117.67 KB 0 B
ROM -1.88 KB 430.28 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.demo.ble_only RAM -888 B 102.33 KB 0 B
ROM -1.9 KB 352.76 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.dut RAM -884 B 141.25 KB 0 B
ROM -2.26 KB 494.18 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.dut.no_secure RAM -884 B 141.23 KB 0 B
ROM -2.31 KB 485.61 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello RAM -880 B 118.84 KB 0 B
ROM -1.75 KB 445.1 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.ble_only RAM -888 B 92.16 KB 0 B
ROM -1.89 KB 351.02 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.ble_only.release RAM -880 B 87.34 KB 0 B
ROM -2.03 KB 287.58 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.release RAM -880 B 102.69 KB 0 B
ROM -2.02 KB 362.42 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.demo RAM 327 B 111.16 KB 0 B
ROM -1.38 KB 374.98 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.demo.ble_only RAM 327 B 95.97 KB 0 B
ROM -1.38 KB 296.35 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.dut RAM 331 B 134.87 KB 0 B
ROM -1.69 KB 439.64 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.dut.no_secure RAM 331 B 134.85 KB 0 B
ROM -1.74 KB 432.17 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello RAM 335 B 112.6 KB 0 B
ROM -1.23 KB 390.08 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello.ble_only RAM 327 B 86.06 KB 0 B
ROM -1.39 KB 294.84 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello.ble_only.release RAM 335 B 81.41 KB 0 B
ROM -1.65 KB 229.25 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello.release RAM 335 B 96.59 KB 0 B
ROM -1.65 KB 304.79 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.demo RAM 428 B 115.66 KB 0 B
ROM -2.42 KB 424.75 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.demo.ble_only RAM 428 B 100.29 KB 0 B
ROM -2.43 KB 345.5 KB 0 B

@NordicBuilder NordicBuilder mentioned this pull request Sep 24, 2024
Merged
@RobertGalatNordic

This comment was marked as outdated.

Sign in to view
@tejlmand tejlmand force-pushed the upmerge/20240812_static_init_gnu_fixes branch from 3bda35b to 6c98d35 Compare September 24, 2024 14:41
@NordicBuilder NordicBuilder mentioned this pull request Sep 24, 2024
Closed
@github-actions github-actions bot added the tests label Sep 25, 2024
@RobertGalatNordic RobertGalatNordic force-pushed the upmerge/20240812_static_init_gnu_fixes branch from 5f048b7 to 52b2982 Compare September 27, 2024 09:00
This was referenced Sep 27, 2024
Closed
Closed
Merged
tejlmand and others added 3 commits October 4, 2024 07:26
@tejlmand @RobertGalatNordic
sample: set STATIC_INIT_GNU for the sidewalk sample
625480e 
The sidewalk sample linking places stack_protector from the C library
in the init_array sections.

For proper initialization in Zephyr then content in this init_array
section requires STATIC_INIT_GNU to be configured.

Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
@RobertGalatNordic
tests: update tests for upmerge
5cd666d 
fix issues found in tests on upmerge PR

Signed-off-by: Robert Gałat <robert.galat@nordicsemi.no>
@RobertGalatNordic
tests: add static partitions to manual dfu image
48bac63 
autogenerated partitions.yml is different than the one from sample.
the same pm_static has been used to make partitions consistant.

Signed-off-by: Robert Gałat <robert.galat@nordicsemi.no>
@RobertGalatNordic RobertGalatNordic force-pushed the upmerge/20240812_static_init_gnu_fixes branch from 2f0eb1c to 48bac63 Compare October 4, 2024 07:27
@carlescufi carlescufi merged commit 437ef18 into nrfconnect:main Oct 4, 2024
56 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertGalatNordic RobertGalatNordic RobertGalatNordic approved these changes

@ktaborowski ktaborowski Awaiting requested review from ktaborowski

Assignees
No one assigned
Labels
source PR changing src files tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tejlmand @RobertGalatNordic @carlescufi