Fix inner product failure when original weight is f16 and oc is 1 #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -525,7 +525,7 @@ status_t jit_brgemm_ip_fwd_conf_t::init_conf(cpu_isa_t isa, | |||
| jbgp.nb_ic = div_up(jbgp.ic, jbgp.ic_block); | |||
|
|
|||
| // gemm-based inner product performs better when oc = 1 | |||
| if (is_f32_compute && jbgp.oc == 1) return status::unimplemented; | |||
| if (is_f32_compute && jbgp.oc == 1 && jbgp.orig_wei_dt != f16) return status::unimplemented; | |||
There was a problem hiding this comment.
I bet we should fix the condition not only for fp16 weights, but for all weights compression cases (jbgp.weights_decompression == true)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix inner product failure when original weight is f16 and oc is 1
Fixes # (CVS-160653)