Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inner product failure when original weight is f16 and oc is 1 #278

Open
wants to merge 1 commit into
base: v3.6_for_ie_master
Choose a base branch
from
Open

Fix inner product failure when original weight is f16 and oc is 1 #278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cpu/x64/jit_brgemm_inner_product_utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,7 @@ status_t jit_brgemm_ip_fwd_conf_t::init_conf(cpu_isa_t isa,
jbgp.nb_ic = div_up(jbgp.ic, jbgp.ic_block);

// gemm-based inner product performs better when oc = 1
if (is_f32_compute && jbgp.oc == 1) return status::unimplemented;
if (is_f32_compute && jbgp.oc == 1 && jbgp.orig_wei_dt != f16) return status::unimplemented;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bet we should fix the condition not only for fp16 weights, but for all weights compression cases (jbgp.weights_decompression == true)


jbgp.oc_block = get_adjusted_oc_block();
jbgp.nb_oc = div_up(jbgp.oc, jbgp.oc_block);
Expand Down