Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GPU] prevent too long sort in experimental detectron generate proposals single image ref kernel when many zeroes on fp16 #28422

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

[GPU] prevent too long sort in experimental detectron generate proposals single image ref kernel when many zeroes on fp16 #28422

wants to merge 10 commits into from
+15 −5

Conversation

michal-miotk
Copy link
Contributor

@michal-miotk michal-miotk commented Jan 13, 2025 •
edited
Loading

Details:

  • changed quickSortIterative to quickSelectIterative
  • added changing pivot position
  • issue happens on ref kernel when many zeroes on fp16 inference
  • on UHD770 fp32 inference on model instance
    segmentation-security-0010.xml speed up 0.14fps->0.19fps

Tickets:

@michal-miotk michal-miotk requested review from a team as code owners January 13, 2025 23:21
@github-actions github-actions bot added the category: GPU OpenVINO GPU plugin label Jan 13, 2025
dnkurek
dnkurek approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@dnkurek dnkurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michal-miotk
Copy link
Contributor Author

looks like not fixed issue, still hang in specific case

@michal-miotk
Copy link
Contributor Author

works

@michal-miotk michal-miotk changed the title [GPU] [DRAFT] prevent too long sort when all zeroes [GPU] prevent too long sort in experimental detectron generate proposals single image ref kernel when many zeroes on fp16 Jan 16, 2025
@dnkurek
Copy link
Contributor

dnkurek commented Jan 16, 2025

Commit title is a bit too long. Second part of it should rather be in the description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnkurek dnkurek dnkurek approved these changes

Assignees
No one assigned
Labels
category: GPU OpenVINO GPU plugin Code Freeze
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michal-miotk @dnkurek @p-durandin