Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GPU] prevent too long sort in experimental detectron generate proposals single image #28422

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
+15 −5
Open

[GPU] prevent too long sort in experimental detectron generate proposals single image #28422

Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a357856
prevent too long sort when all zeroes
michal-miotk Jan 13, 2025
3784fa7
Merge branch 'master' into fix_detectron
michal-miotk Jan 13, 2025
ab025f3
parallel quick sort, dynamically changing pivot
michal-miotk Jan 15, 2025
8c13833
sort only PRE_NMS_TOPN sth like 1000 instead 200_000 elements
Jan 15, 2025
c1cd58d
undo parallel
Jan 15, 2025
7a435cc
fix error in comparision
michal-miotk Jan 15, 2025
061f534
Merge branch 'master' into fix_detectron
michal-miotk Jan 15, 2025
d87b7ee
fixed small error in partitin func, changed name of function
michal-miotk Jan 15, 2025
0f32fa0
deleted zero check
michal-miotk Jan 15, 2025
b345476
fix (static variable without static word)
michal-miotk Jan 16, 2025
36bab31
added comment for pivot selection, fixed style
michal-miotk Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions .../kernel_selector/cl_kernels/experimental_detectron_generate_proposals_single_image_ref.cl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,17 @@ inline void FUNC(swap_box)(__global Box* a, __global Box* b) {
}

inline int FUNC(partition)(__global Box* arr, int l, int h) {
INPUT0_TYPE pivotScore = arr[h].score;
int static_counter = 0;
static_counter++;
dnkurek marked this conversation as resolved.
Show resolved Hide resolved
int pivot_idx = l;
if(static_counter%3 == 0) {
Copy link
Contributor

@clee30 clee30 Jan 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is 3 here? May be need to define it.

Copy link
Contributor

@dnkurek dnkurek Jan 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to me like a cyclic pivot selection rotation scheme in order to avoid worst case scenario in quicksort

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that a simple comment may suffice so it's more clear

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

pivot_idx = (l+h)/2;
}
if(static_counter%3 == 1) {
pivot_idx = h;
}
INPUT0_TYPE pivotScore = arr[pivot_idx].score;
FUNC_CALL(swap_box)(&arr[h], &arr[pivot_idx]);
int i = (l - 1);
for (int j = l; j <= h - 1; j++) {
if (arr[j].score > pivotScore) {
Expand All @@ -129,7 +139,7 @@ inline void FUNC(bubbleSortIterative)(__global Box* arr, int l, int h) {
}
}

inline void FUNC(quickSortIterative)(__global Box* arr, int l, int h) {
inline void FUNC(quickSelectIterative)(__global Box* arr, int l, int h) {
// Create an auxiliary stack
const int kStackSize = 100;
int stack[kStackSize];
Expand All @@ -153,7 +163,7 @@ inline void FUNC(quickSortIterative)(__global Box* arr, int l, int h) {

// If there are elements on left side of pivot,
// then push left side to stack
if (p - 1 > l) {
if (p - 1 > l && l < PRE_NMS_TOPN) {
if (top >= (kStackSize - 1)) {
FUNC_CALL(bubbleSortIterative)(arr, l, p - 1);
} else {
Expand All @@ -164,7 +174,7 @@ inline void FUNC(quickSortIterative)(__global Box* arr, int l, int h) {

// If there are elements on right side of pivot,
// then push right side to stack
if (p + 1 < h) {
if (p + 1 < h && p + 1 < PRE_NMS_TOPN) {
if (top >= (kStackSize - 1)) {
FUNC_CALL(bubbleSortIterative)(arr, p + 1, h);
} else {
Expand All @@ -179,7 +189,7 @@ inline void FUNC(quickSortIterative)(__global Box* arr, int l, int h) {
KERNEL(edgpsi_ref_stage_1)(__global OUTPUT_TYPE* proposals) {
dnkurek marked this conversation as resolved.
Show resolved Hide resolved
__global Box* boxes = (__global Box*)proposals;

FUNC_CALL(quickSortIterative)(boxes, 0, NUM_PROPOSALS-1);
FUNC_CALL(quickSelectIterative)(boxes, 0, NUM_PROPOSALS-1);
}
#undef Box
#endif /* EDGPSI_STAGE_1 */
Expand Down
Loading