-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add missing S3 permissions #796
base: main
Are you sure you want to change the base?
Conversation
Thanks! |
I am adding resource to be aligned with the linked doc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again!
DO NOT MERGE SORRY
Looks like one is missing. Drafting now. |
Now it works. |
Forgot to push the last permission yesterday's evening. OMG what a pain, now I swear it works :-D |
"arn:aws:s3:::amzn-s3-demo-import-bucket", | ||
"arn:aws:s3:::amzn-s3-demo-import-bucket/*", | ||
"arn:aws:s3:::amzn-s3-demo-export-bucket", | ||
"arn:aws:s3:::amzn-s3-demo-export-bucket/*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw the word demo
in the resource names and had to look up how they're used exactly. We should mention in the text above that amzn-s3-demo-import-bucket
and amzn-s3-demo-export-bucket
are example names. They are, right?
It should also be enough to just have one, maybe? Or change the name to reflect our use case as a slightly more concrete example. Like bib-ec2-image-upload-bucket-example
or something.
Or am I wrong about what this all means?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really the bucket name in ARN format, I was trying to match what is documented in the linked AWS doc rather than this README. I can change if you insist, I take it since this is part of the documentation it should be more clear to a user who is copy-pasting these blocks into AWS UI that they should replace this one as well.
I was testing this on a newly created account and two permissions were missing.