Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing S3 permissions #796

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: add missing S3 permissions #796

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,24 @@ Note that when no value is given the progress is auto-detected baed on the envir

#### Prerequisites

In order to successfully import an AMI into your AWS account, you need to have the [vmimport service role](https://docs.aws.amazon.com/vm-import/latest/userguide/required-permissions.html) configured on your account.
In order to successfully import an AMI into your AWS account, you need to have the [vmimport service role](https://docs.aws.amazon.com/vm-import/latest/userguide/required-permissions.html) configured on your account with the following additional permissions:

```
{
"Effect": "Allow",
"Action": [
"s3:ListAllMyBuckets",
"s3:GetBucketAcl",
"s3:DeleteObject"
],
"Resource": [
"arn:aws:s3:::amzn-s3-demo-import-bucket",
"arn:aws:s3:::amzn-s3-demo-import-bucket/*",
"arn:aws:s3:::amzn-s3-demo-export-bucket",
"arn:aws:s3:::amzn-s3-demo-export-bucket/*"
Comment on lines +217 to +220
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw the word demo in the resource names and had to look up how they're used exactly. We should mention in the text above that amzn-s3-demo-import-bucket and amzn-s3-demo-export-bucket are example names. They are, right?

It should also be enough to just have one, maybe? Or change the name to reflect our use case as a slightly more concrete example. Like bib-ec2-image-upload-bucket-example or something.

Or am I wrong about what this all means?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really the bucket name in ARN format, I was trying to match what is documented in the linked AWS doc rather than this README. I can change if you insist, I take it since this is part of the documentation it should be more clear to a user who is copy-pasting these blocks into AWS UI that they should replace this one as well.

]
},
```

#### Flags

Expand Down
Loading