feat: support multiple juice_mux_listen callbacks for different ports #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
force-pushed
the
feat/support-multiple-juice_mux_listen-callbacks
branch
16 times, most recently
from
1ffd80c to
23f93a4
Compare
Supports multiple callbacks for unhandled STUN requests. Stores multiple registries, one per local listening port in a `conn_registry_t **registries;` field on `conn_mode_entry_t`. The list of registries grows in the same way as the list of agents in `conn_mode_entry_t`. Adds a `port` property to `conn_registry_t` which is the port the registry is bound to, and an `index` property which is the index of the registry in the containing `registries` list in `conn_mode_entry_t`.
achingbrain
force-pushed
the
feat/support-multiple-juice_mux_listen-callbacks
branch
from
23f93a4 to
d1893a8
Compare
achingbrain
commented
Jan 20, 2025
13 tasks
|
@paullouisageneau are there any further changes you'd like to see here or is this ready to go in? |
Co-authored-by: Paul-Louis Ageneau <paul-louis@ageneau.org>
|
@paullouisageneau All comments addressed! |
paullouisageneau
approved these changes
Feb 14, 2025
achingbrain
deleted the
feat/support-multiple-juice_mux_listen-callbacks
branch
This was referenced Feb 15, 2025
|
Thank you for merging this - will it make it into a release soon? |
|
@paullouisageneau could this please be released? It would be really great to roll it up to paullouisageneau/libdatachannel#1211 and draw a line under all this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #248 that addresses #248 (comment)
Supports multiple callbacks for unhandled STUN requests, one per listening address (e.g. host + port).
Stores multiple registries, one per local listening address in a
conn_registry_t **registries;field onconn_mode_entry_t.The list of registries grows in the same way as the list of agents in
conn_mode_entry_t.Adds an
addressproperty toconn_registry_twhich is the host+port the registry is bound to, and aregistry_indexproperty which is the index of the registry in the containingregistrieslist inconn_mode_entry_t.