[ColorControl]Add checks for rate and step size parameters in commands handling #33251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple and
lazarkov
|
PR #33251: Size comparison from 8ba371a to 7237a72 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #33251: Size comparison from 8ba371a to 59d23de Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
… at 0. Add a test step to TC_CC_5.2 to validate the expected failure
…date_cluster_revisions.py) and regen
…nd Y = 0 is valid
jmartinez-silabs
force-pushed
the
update/CC_rateXY_checks
branch
from
59d23de to
ad394f1
Compare
|
PR #33251: Size comparison from f6eb522 to ad394f1 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
changed the title
lpbeliveau-silabs
approved these changes
Jul 12, 2024
andy31415
reviewed
Jul 19, 2024
andy31415
reviewed
Jul 19, 2024
andy31415
approved these changes
Jul 19, 2024
bzbarsky-apple
approved these changes
Jul 19, 2024
yufengwangca
approved these changes
Jul 19, 2024
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
…s handling (project-chip#33251) * Return invalid comamnd on MoveColor command with RateX and RateY both at 0. Add a test step to TC_CC_5.2 to validate the expected failure * Add checks for stepSize and bump Color control cluster revision in its xml * Update CC cluster revision from 6 to 7 in relevant zap files (with update_cluster_revisions.py) and regen * Restyled by prettier-yaml * update changes based on latest spec pr changes * Revert added test in TC_CC_5_2. spec pr change MoveColor with RateX and Y = 0 is valid * Add yaml certification test step for the added CC check * Restyled by whitespace * Restyled by prettier-yaml --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds checks to the color control cluster commands handling based on this Spec pr
https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/9140
RateX and RateY, or StepSize parameters shall not be 0.Yaml test updates.I will update the test-plan firstEdit: RateX and RateY = 0 remains accepted and it stops any ongoing transition