-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] Added [[maybe_unused]] to remove errors from NDEBUG builds #33315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #33315: Size comparison from c4e37c2 to d0c519d Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #33315: Size comparison from 16e220b to 806d22f Decreases (2 builds for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
mkardous-silabs
approved these changes
May 6, 2024
PR #33315: Size comparison from 16e220b to 69a07e8 Decreases (2 builds for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
bzbarsky-apple
approved these changes
May 7, 2024
chirag-silabs
pushed a commit
to rosahay-silabs/connectedhomeip
that referenced
this pull request
Jul 15, 2024
…to remove errors from NDEBUG builds (project-chip#33315) Merge in WMN_TOOLS/matter from cherry-pick/no_debug_build_fix to silabs_slc_1.3 Squashed commit of the following: commit 393d82919c6208e785f2d5b724de08ff75c8a9b7 Author: Curtis Rahman <curtis.rahman@silabs.com> Date: Tue May 7 15:54:54 2024 -0400 Added light-switch to no debug builds commit b5b0bf2fcbe72bc53c5a9531360c43f6ecf74523 Author: Curtis Rahman <111998767+CuRahman@users.noreply.github.com> Date: Mon May 6 21:54:43 2024 -0400 [Silabs] Added [[maybe_unused]] to remove errors from NDEBUG builds (project-chip#33315) * Added NDEBUG ifndef to minimize code size * Restyled by whitespace * Restyled by clang-format * Added #endif * Added [[mayne_unused]] --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem/Feature:
Unused variable errors within these methods when adding the NDEBUG define. Changes affect lock/light-switch.
Description of Fix/Solution:
Added [[maybe_unused]] before variable declarations.