-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS tv-casting-app: deprecating old casting impl, replacing with shim #33350
Merged
sharadb-amazon
merged 1 commit into
project-chip:master
from
sharadb-amazon:ios-shim-20240430
May 8, 2024
Merged
iOS tv-casting-app: deprecating old casting impl, replacing with shim #33350
sharadb-amazon
merged 1 commit into
project-chip:master
from
sharadb-amazon:ios-shim-20240430
May 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6d174e0
to
f77ca89
Compare
f77ca89
to
c8c0c0e
Compare
PR #33350: Size comparison from 5078a93 to c8c0c0e Decreases (2 builds for efr32)
Full report (77 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
chrisdecenzo
approved these changes
May 8, 2024
woody-apple
approved these changes
May 8, 2024
woody-apple
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change deprecates the old CastingServerBridge implementation for the iOS tv-casting-app and replaces that with a thinner shim layer that re-routes to the new APIs described in /examples/tv-casting-app/APIs.md
The shim layer would allow any existing clients to upgrade to newer versions of the Matter SDK and this library.
Change summary
Testing
Verified and tested locally with iOS tv-casting-app running against the Linux TV app