[nrfconnect] Fixed Python requirements for factory data generation #33980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
pullapprove
bot
requested review from
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #33980: Size comparison from 4cdce52 to fe426f8 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Jun 18, 2024
Recently the SetupPayload module has started utilizing `concrete` package. As a result, it has became an indirect dependency of implementation of the nrfconnect factory data generation. Forward the `setup_payload/python/requirements.txt` to the nrfconnect specific requirements as a fix. Signed-off-by: Marcin Kajor <marcin.kajor@nordicsemi.no>
markaj-nordic
force-pushed
the
ncs_fix_python_req
branch
from
fe426f8 to
a3163e6
Compare
Damian-Nordic
approved these changes
Jun 20, 2024
LuDuda
approved these changes
Jun 20, 2024
|
PR #33980: Size comparison from be26a8f to a3163e6 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Jun 21, 2024
|
@markaj-nordic need to also change |
|
PR #33980: Size comparison from be26a8f to af16e4b Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pimpalemahesh
pushed a commit
to pimpalemahesh/connectedhomeip
that referenced
this pull request
Jun 24, 2024
…roject-chip#33980) * [nrfconnect] Fixed Python requirements for factory data generation Recently the SetupPayload module has started utilizing `concrete` package. As a result, it has became an indirect dependency of implementation of the nrfconnect factory data generation. Forward the `setup_payload/python/requirements.txt` to the nrfconnect specific requirements as a fix. Signed-off-by: Marcin Kajor <marcin.kajor@nordicsemi.no> * Fix setup_payload requirements path in build.yaml --------- Signed-off-by: Marcin Kajor <marcin.kajor@nordicsemi.no> Co-authored-by: Damian Krolik <damian.krolik@nordicsemi.no>
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Jul 10, 2024
…roject-chip#33980) * [nrfconnect] Fixed Python requirements for factory data generation Recently the SetupPayload module has started utilizing `concrete` package. As a result, it has became an indirect dependency of implementation of the nrfconnect factory data generation. Forward the `setup_payload/python/requirements.txt` to the nrfconnect specific requirements as a fix. Signed-off-by: Marcin Kajor <marcin.kajor@nordicsemi.no> * Fix setup_payload requirements path in build.yaml --------- Signed-off-by: Marcin Kajor <marcin.kajor@nordicsemi.no> Co-authored-by: Damian Krolik <damian.krolik@nordicsemi.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently the SetupPayload module has started utilizing
concretepackage.As a result, it has became an indirect dependency of implementation of the nrfconnect factory data generation.
Forward the
setup_payload/python/requirements.txtto the nrfconnect specific requirements as a fix.