Implement Thread Network Directory server #34343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
examples
scripts
darwin
lib
controller
app
tests
support
core
labels
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex and
harsha-rajendran
|
PR #34343: Size comparison from 74768a8 to 39ac64e Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
kiel-apple
reviewed
Jul 16, 2024
kiel-apple
reviewed
Jul 16, 2024
kiel-apple
reviewed
Jul 16, 2024
src/app/clusters/thread-network-directory-server/DefaultThreadNetworkDirectoryStorage.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/thread-network-directory-server/ThreadNetworkDirectoryStorage.h
Outdated
Show resolved
Hide resolved
src/app/clusters/thread-network-directory-server/ThreadNetworkDirectoryStorage.h
Outdated
Show resolved
Hide resolved
src/app/clusters/thread-network-directory-server/thread-network-directory-server-instance.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/thread-network-directory-server/thread-network-directory-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/thread-network-directory-server/thread-network-directory-server.cpp
Show resolved
Hide resolved
|
PR #34343: Size comparison from 74768a8 to 5392d15 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34343: Size comparison from 74768a8 to b6db541 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
Note: Backwards compat check failed here, since this hasn't been specified yet. |
bzbarsky-apple
approved these changes
Jul 18, 2024
src/app/clusters/thread-network-directory-server/DefaultThreadNetworkDirectoryStorage.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/thread-network-directory-server/DefaultThreadNetworkDirectoryStorage.cpp
Outdated
Show resolved
Hide resolved
- Use octstr[8] for ExtendedPanID fields - Add ActiveTimestamp to ThreadNetworkStruct - Remove NetworkChanged event PreferredExtendedPanID is nullable, so the uint64 representation is not suitable because the value 0xFFF... is disallowed as a null marker. Change all related attributes / fields to octstr[8] to be consistent. Also add the cluster to the relevant meta-data files. See CHIP-Specifications/connectedhomeip-spec#10019
Also add it to the network-manager example app.
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> Co-authored-by: Kiel Oleson <kielo@apple.com>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Remove DefaultInstance() and weak cluster init function and instead provide a DefaultThreadNetworkDirectoryServer sub-class that's easy to instantiate with the default storage implementation. Roll back in-memory state on persistent storage failure and add tests for this. Add documentation about ByteSpan lifetimes in OperationalDataset class. Add comments to MTRDemuxingStorage.mm
ksperling-apple
force-pushed
the
tnd-server
branch
from
b6db541 to
f3693a9
Compare
jmartinez-silabs
approved these changes
Jul 18, 2024
|
PR #34343: Size comparison from 3418614 to f3693a9 Full report (3 builds for cc32xx, stm32)
|
|
PR #34343: Size comparison from 3418614 to e828cdb Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
* Update Thread Network Directory cluster definition - Use octstr[8] for ExtendedPanID fields - Add ActiveTimestamp to ThreadNetworkStruct - Remove NetworkChanged event PreferredExtendedPanID is nullable, so the uint64 representation is not suitable because the value 0xFFF... is disallowed as a null marker. Change all related attributes / fields to octstr[8] to be consistent. Also add the cluster to the relevant meta-data files. See CHIP-Specifications/connectedhomeip-spec#10019 * zap_regen_all * Implement Thread Network Directory server Also add it to the network-manager example app. * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> Co-authored-by: Kiel Oleson <kielo@apple.com> * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Remove stale zap generated files * Address review comments Remove DefaultInstance() and weak cluster init function and instead provide a DefaultThreadNetworkDirectoryServer sub-class that's easy to instantiate with the default storage implementation. Roll back in-memory state on persistent storage failure and add tests for this. Add documentation about ByteSpan lifetimes in OperationalDataset class. Add comments to MTRDemuxingStorage.mm * Use emberAf...ClusterInitCallback (not ...Server) * Address review comments * Avoid conversion warning --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> Co-authored-by: Kiel Oleson <kielo@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Thread Network Directory cluster definition based on https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/10019
Implement Thread Network Directory server and add it to network-manage example app.