[Fix] Replaced automatable PICS in SEAR tests #35231
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced automatable PICS in SEAR 1.3, 1.5, and 1.6 test modules.
|
Review changes with Changed Files
|
github-actions
bot
added
tests
matter-1.4-te2-script-change
- resolved linting issue
|
PR #35231: Size comparison from 32c961f to 32cd0ad Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35231: Size comparison from 4d4fcb3 to b830540 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35231: Size comparison from 3bf596f to b253b36 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
- Replaced C02.Rsp with SkipArea command id check against accepted commands list for SearchArea cluster
|
PR #35231: Size comparison from 3d69583 to b8903bc Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
chapongatien,
chrisdecenzo,
chshu and
chulspro
pullapprove
bot
requested review from
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
Does this align with the Test Plan? I think this is a good addition but it needs to be aligned with the Test Plan and given the timing, this might be something we need to postpone to 1.5? |
cecille
reviewed
Oct 22, 2024
cecille
removed
the
matter-1.4-te2-script-change
Updating to leave top level PIC's unchanged
github-actions
bot
added
the
matter-1.4-te2-script-change
Updating to leave top level PICS alone
j-ororke
removed
the
matter-1.4-te2-script-change
github-actions
bot
added
the
matter-1.4-te2-script-change
j-ororke
removed
the
matter-1.4-te2-script-change
|
PR #35231: Size comparison from 4c69001 to c74e2da Full report (25 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, telink, tizen)
|
github-actions
bot
added
the
matter-1.4-te2-script-change
|
PR #35231: Size comparison from a3a443a to ed064c2 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35231: Size comparison from 1c92162 to 5156b82 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
- Updating to using attribute_guard, command_guard, and feature_guard functions where applicable.
|
PR #35231: Size comparison from 1c92162 to 283dbb7 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
reviewed
Jan 17, 2025
| @@ -94,6 +94,17 @@ async def test_TC_SEAR_1_6(self): | |||
| asserts.fail("The --app-pid flag must be set when PICS_SDK_CI_ONLY is set") | |||
| self.app_pipe = self.app_pipe + str(app_pid) | |||
|
|
|||
| attributes = Clusters.ServiceArea.Attributes | |||
|
|
|||
| if not await self.attribute_guard(endpoint=self.endpoint, attribute=attributes.SupportedAreas): | |||
There was a problem hiding this comment.
Given that we now have the top-level guards, this should be changed over to use those.
Also, I'm pretty sure the pics_ function in this test is incorrect - it looks like the function on line 83 is suppose to be pics_TC_SEAR_1_6, which is probably why these were added - the pics definition seems wrong.
There was a problem hiding this comment.
I have changed the function name for the pics to be pics_TC_SEAR_1_* based on the test being run so that the pics can be found during testing if they are needed.
- Changing to using correct names for pics function to be found by test runner script.
|
PR #35231: Size comparison from df5ee33 to c2554b8 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing