-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Replaced automatable PICS in SEAR tests #35231
Open
j-ororke
wants to merge
17
commits into
project-chip:master
Choose a base branch
from
j-ororke:remove_PICS_from_SEAR_tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
cfa0fcf
[Fix] Replaced automatable PICS in SEAR tests:
j-ororke 5ad2b47
Updated TC_SEAR_1_6 test module:
j-ororke 32cd0ad
Restyled by autopep8
restyled-commits b830540
Merge branch 'master' into remove_PICS_from_SEAR_tests
j-ororke b253b36
Merge branch 'master' into remove_PICS_from_SEAR_tests
j-ororke c2829af
Updated TC_SEAR_1_5 test module:
j-ororke 5b83c7a
Restyled by autopep8
restyled-commits b8903bc
Merge branch 'master' into remove_PICS_from_SEAR_tests
j-ororke c17f287
Update TC_SEAR_1_5.py
j-ororke ea856f9
Update TC_SEAR_1_6.py
j-ororke 1fa489a
Merge branch 'master' into remove_PICS_from_SEAR_tests
j-ororke c74e2da
Restyled by autopep8
restyled-commits ed064c2
Merge branch 'master' into remove_PICS_from_SEAR_tests
j-ororke 5156b82
Merge branch 'master' into remove_PICS_from_SEAR_tests
j-ororke 283dbb7
Updating TC_SEAR_1_3, TC_SEAR_1_5, and TC_SEAR_1_6 test modules:
j-ororke 3aaca75
Updating TC_SEAR_1_* test modules:
j-ororke c2554b8
Merge branch 'master' into remove_PICS_from_SEAR_tests
j-ororke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that we now have the top-level guards, this should be changed over to use those.
Also, I'm pretty sure the pics_ function in this test is incorrect - it looks like the function on line 83 is suppose to be pics_TC_SEAR_1_6, which is probably why these were added - the pics definition seems wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed the function name for the pics to be pics_TC_SEAR_1_* based on the test being run so that the pics can be found during testing if they are needed.