Fix data version handling in test033_TestMTRDeviceDeviceConfigurationChanged #35628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Changed Data versions are per-cluster, not per-attribute, so every time we inject an attribute report for a given cluster we need to bump the data version. Also: * Fixes checkAttributeReportTriggersConfigurationChanged to be an instance method, since it was taking the instance as an argument anyway. * Fixes checkAttributeReportTriggersConfigurationChanged to provide descriptions for its expectations and assertions that identify the callsite. * Adds some logging to MTRDevice to make it a little easier to tell which parts of attribute reporting are or are not happening and in which order.
|
Review changes with SemanticDiff. |
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi and
doru91
pullapprove
bot
requested review from
selissia,
tecimovic,
sharadb-amazon,
tehampson,
tcarmelveilleux,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple and
younghak-hwang
nivi-apple
approved these changes
Sep 17, 2024
|
PR #35628: Size comparison from a578c14 to ad0dd9e Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
approved these changes
Sep 17, 2024
tcarmelveilleux
approved these changes
Sep 17, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…Changed (project-chip#35628) Data versions are per-cluster, not per-attribute, so every time we inject an attribute report for a given cluster we need to bump the data version. Also: * Fixes checkAttributeReportTriggersConfigurationChanged to be an instance method, since it was taking the instance as an argument anyway. * Fixes checkAttributeReportTriggersConfigurationChanged to provide descriptions for its expectations and assertions that identify the callsite. * Adds some logging to MTRDevice to make it a little easier to tell which parts of attribute reporting are or are not happening and in which order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data versions are per-cluster, not per-attribute, so every time we inject an attribute report for a given cluster we need to bump the data version.
Also: