[Test] Creating TC_CADMIN_1_22 and TC_CADMIN_1_24 python test modules #35632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
j-ororke
commented
Sep 17, 2024
•
j-ororke
commented
- Created CADMIN_1_22 python test module following steps in PR here: TC_CADMIN_1_22
- Created CADMIN_1_24 python test module following steps in PR here: TC_CADMIN_1_24
- Removed following yaml test modules:
-
- Test_TC_CADMIN_1_21.yaml, Test_TC_CADMIN_1_22.yaml, Test_TC_CADMIN_1_23.yaml, Test_TC_CADMIN_1_24.yaml
- Created CADMIN_1_22 python test module following steps in PR here: - Created CADMIN_1_24 python test module following steps in PR here: - Removed following yaml test modules: -- Test_TC_CADMIN_1_21.yaml, Test_TC_CADMIN_1_22.yaml, Test_TC_CADMIN_1_23.yaml, Test_TC_CADMIN_1_24.yaml
|
Review changes with Changed Files
|
github-actions
bot
added
app
tests
matter-1.4-te2-script-change
|
PR #35632: Size comparison from 31894f6 to e244d98 Full report (11 builds for nxp, qpg, stm32, tizen)
|
- Resolved linting issues
|
PR #35632: Size comparison from 31894f6 to c8a2509 Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex and
harsha-rajendran
- Resolved issues with CI args in TC_CADMIN_1_22_24 test module - Removed yaml calls for 1_21, 1_22, 1_23, and 1_24, also removed yaml call for 1_9 from manualTests.json
|
PR #35632: Size comparison from 1f4e81e to fd13214 Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
removed
the
matter-1.4-te2-script-change
cecille
approved these changes
Oct 29, 2024
tehampson
reviewed
Oct 29, 2024
tehampson
reviewed
Oct 29, 2024
tehampson
reviewed
Oct 29, 2024
- Resolving comments from tehampson as these were needed changes to be made -- Substituted to using cleaner code for assert.asserts_equal instead of just assert.failure -- Resolving copy paste error in TC_CADMIN_1_4 test -- Made comments cleaner by rewording to include what the error code was referring too
github-actions
bot
added
the
matter-1.4-te2-script-change
- Changing method for test step 3 on TC_CADMIN_1_24 test now using timeout for 30 seconds instead of revoke commissioning
tehampson
reviewed
Nov 4, 2024
tehampson
reviewed
Nov 4, 2024
tehampson
reviewed
Nov 4, 2024
tehampson
reviewed
Nov 4, 2024
- Unnesting asserts from if statements
- Adding this suggested change from Terrence into the code, as it does make the code much cleaner Co-authored-by: Terence Hampson <thampson@google.com>
-Updating to changing static value to being stored in variable for easier readability as Terrence has suggested, making the code easier to read.
- Removed unneccessary await from asserts
|
@j-ororke Just an FYI please feel free to mark comments where you believe you 100% addressed them as resolved. If there is some sort of discussion those you can keep open to see if the reviewer is happy, but otherwise I think it is perfectly reasonable to mark comments that are completed by you as resolved. |
tehampson
approved these changes
Nov 19, 2024
raju-apple
approved these changes
Nov 20, 2024
andy31415
reviewed
Nov 27, 2024
| nodeid=self.dut_node_id, timeout=180, iteration=10000, discriminator=self.discriminator, option=1) | ||
|
|
||
| self.step(3) | ||
| sleep(180) |
There was a problem hiding this comment.
yaml used to wait for 181 seconds instead of 180 for some reason.
Also this is absolutely terrible for CI. Could we make CI sleep less? Or maybe have an interface to skip slow in PR CI the same like we have for YAML: https://github.com/project-chip/connectedhomeip/blob/master/scripts/tests/chiptest/__init__.py#L98
There was a problem hiding this comment.
I apologize for this test having caused some issues in the CI currently due to the sleep time.
I will file a PR here soon to remove this test from running in the CI moving forward, sounds like this test is not needed to be run in the CI.
There was a problem hiding this comment.
Hi @andy31415,
I noticed that there is some new code in src/python_testing/test_metadata.yaml in the master branch.
In the slow_tests section of that yaml file there appears to be CADMIN_1_9, CADMIN_1_19, and CADMIN_1_22_24 tests with duration of test runs added currently.
Does this resolve the issue with the CI and the test from this above PR? Can this comment be resolved?
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…project-chip#35632) * [Test] Creating TC_CADMIN_1_22 and TC_CADMIN_1_24: - Created CADMIN_1_22 python test module following steps in PR here: - Created CADMIN_1_24 python test module following steps in PR here: - Removed following yaml test modules: -- Test_TC_CADMIN_1_21.yaml, Test_TC_CADMIN_1_22.yaml, Test_TC_CADMIN_1_23.yaml, Test_TC_CADMIN_1_24.yaml * Restyled by autopep8 * Updating TC_CADMIN_1_22 and TC_CADMIN_1_24: - Resolved linting issues * Created TC_CADMIN_1_22_24 test module: - Merged TC_CADMIN_1_24 and TC_CADMIN_1_22 standalone test modules into a single test module - Found enum for window closed value and replaced it in the tests - Removed generate_unique_value and AttemptCommission functions - Updated CI arguments format to YAML'esque format * Restyled by autopep8 * Updated TC_CADMIN_1_22_24: - Renamed class to TC_CADMIN_1_22_24 * Updating TC_CADMIN_1_22_24: - Resolving lint errors * Update TC_CADMIN_1_22_24.py Updated to include dependency location change for matter_testing support module * Updated TC_CADMIN_1_22_24.py: - Resolved issues with CI args in TC_CADMIN_1_22_24 test module - Removed yaml calls for 1_21, 1_22, 1_23, and 1_24, also removed yaml call for 1_9 from manualTests.json * Updating TC_CADMIN_1_22_24 test module: - Resolving comments from tehampson as these were needed changes to be made -- Substituted to using cleaner code for assert.asserts_equal instead of just assert.failure -- Resolving copy paste error in TC_CADMIN_1_4 test -- Made comments cleaner by rewording to include what the error code was referring too * Update TC_CADMIN_1_22_24 test module: - Changing method for test step 3 on TC_CADMIN_1_24 test now using timeout for 30 seconds instead of revoke commissioning * Restyled by autopep8 * Update TC_CADMIN_1_22_24.py - Unnesting asserts from if statements * Update src/python_testing/TC_CADMIN_1_22_24.py - Adding this suggested change from Terrence into the code, as it does make the code much cleaner Co-authored-by: Terence Hampson <thampson@google.com> * Update TC_CADMIN_1_22_24.py -Updating to changing static value to being stored in variable for easier readability as Terrence has suggested, making the code easier to read. * Restyled by autopep8 * Updated TC_CADMIN_1_22_24 test module: - Removed unneccessary await from asserts * Restyled by autopep8 --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Terence Hampson <thampson@google.com>
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Feb 28, 2025
----------
Revert "[SL-UP] Circular callback fix (#85) (#36406)" (#36475)
This reverts commit 078bc30d3f9f5d46c989272b2a50b3f5e8eb2f55.
Update camera zone cluster to latest spec docs (#36411)
* Generated using ./alchemy zap --attribute="in-progress" ... ZoneManagement.adoc
* Generated using ./scripts/tools/zap_regen_all.py
* Remove renamed file
* Restyled by whitespace
* Restyled by prettier-json
* Remove renamed file
* Remove choice for single element
---------
Co-authored-by: Restyled.io <commits@restyled.io>
[ICD] Shutdown icd client storage when destroying android controller (#36348)
* Shutdown DefautICDClientStorage when destorying Android controller
* Restyled by whitespace
* Update DefaultICDClientStorage.h
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
---------
Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
[pw_fuzzer] Add FuzzTests for PASE Message Receiving (#36445)
* Add FuzzTests for PASE Message Receiving
* Integrating Comments
* Removing two unused global string constants
* Integrating Comments
remove unused CHIP_CONFIG_MAX_BINDINGS (#36483)
Change output folder for apps (#35700)
* Change output folder for apps
* Update integrations/docker/images/chip-cert-bins/Dockerfile
* Update integrations/docker/images/chip-cert-bins/Dockerfile
[Silabs] Move Wi-Fi interface to src/platform from examples/platform (#36477)
* Restructure platform files
* Move all files to src/platform
* Build the wf200 in the new wifi structure
* rename directory
* Build the rs9116 in the new wifi structure
* Build the SiWx917 NCP in the new wifi structure
* Build the SiWx917 SoC in the new wifi structure
* Delete wfx_host_events header in favor of the new abstraction structure
* remove unnecessary includes in gn files and the cflag changes
* restyle
* add todo comment
* remove cflag inclusion
* add missing incllude
* Add missing includes
* Restyled by clang-format
* Move wifi_args.gni file to the wifi directory
* Rename Wf200WifiInterface to WifiInterface
* Rename SiWxWifiInterface to WifiInterface
* Rename Rsi91xWifiInterface.cpp to WifiInterface.cpp
---------
Co-authored-by: Restyled.io <commits@restyled.io>
[Darwin] API to list all network commissioning features supported by an MTRDevice (#36479)
* [Darwin] API to list all network commissioning features supported by an MTRDevice
- Expose the network commissioning feature bitset as API to know what
transports are supported by the device.
* Code review comments
* Code review comments
* Restyled by clang-format
---------
Co-authored-by: Restyled.io <commits@restyled.io>
Removal of 2 redundant attributes in CameraAVStreamMgmt cluster. (#36478)
SDK update for corresponding Spec change.
Remove the CurrentSnapshotConfig and CurrentVideoCodecs as they
are captured by the Allocated Video and Snapshot stream attributes.
Also, fix a field name in the Snapshotstream allocation command.
Run ZAP regen for the corresponding changes.
[Fabric-Sync] Port commissioner control protocol implementation (#36427)
* [Fabric-Sync] Port commissioner control protocol
* Add device synchronization
* Fix compile error
* Update examples/fabric-sync/admin/DeviceSubscription.cpp
Co-authored-by: Terence Hampson <thampson@google.com>
* Address review comments
* Add debug log
* Update examples/fabric-sync/admin/DeviceManager.cpp
Co-authored-by: Terence Hampson <thampson@google.com>
* Address review comments
* Add endpoint check
---------
Co-authored-by: Terence Hampson <thampson@google.com>
[nxp][examples][mcxw71_k32w1] Add platform/CHIPDeviceBuildConfig.h (#36482)
* [nxp][examples][mcxw71_k32w1] Include platform/CHIPDeviceConfig.h in FreeRtosHooks.cpp
* this will include the CHIP_DEVICE_CONFIG_ENABLE_OTA_REQUESTOR macro allowing OTAIdleActivities
to be called during ota.
* Switch FreeRtosHooks.c to FreeRtosHooks.cpp
* Add extern to functions
Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com>
* Restyled by whitespace
* Restyled by clang-format
* Restyled by gn
---------
Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Move ember-specific attribute persistence providers into `src/util/persistence` (#36473)
* Move persistence providers code into util since they depend on ember.
Unit tests pass, will need to fix up apps.
* Fix up more includes
* Restyled by clang-format
* Fix up qpg build
* Also fix nrfconnect deferred attribute persistence use
* Fix path
* Add persistence to esp32 CMakeLists.txt
* Update examples/lighting-app/qpg/BUILD.gn
---------
Co-authored-by: Andrei Litvin <andreilitvin@google.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Add timeout to excute a command (#36492)
[HVAC] Thermostat deadband handling (#35673)
* [HVAC] Shift heating and cooling setpoints to preserve deadband, when possible
* Minor function renames, fix incorrect setters
* Populate deadband on setpointLimits when Auto is supported
* [Thermostat] Add test for deadband handling
* Restyled Python test
* Fix int promotion errors on some platforms
* Remove unused Python imports
* Fix capitalization of structs, methods, fields, etc.
* Silly C++ int promotion rules
* [HVAC] Fix incorrect naming of TSTAT 2.3 test class
* Fix errant quote in TC_TSTAT_2_3.py
* Drop deadband fix test in favor of separate PR
* Apply suggestions from code review
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Don't use three-arg setter for attributes
* Rename deadband member
* Add backwards-compatibility comment for return code substitution
* Restyled
---------
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
[Fabric-Sync] Use Meyers' Singleton pattern for BridgedDeviceManager and DeviceManager (#36491)
[darwin] Update the NetworkFramework UDP implementation (#36418)
* [Network.framework] Add chip_system_config_use_network_framework
* [Network.framework] Update src/lib/core/CHIPConfig.h file to enable CHIP_CONFIG_IsPlatformPOSIXErrorNonCritical
* [Network.framework] Update src/system/SystemConfig.h file to enable CHIP_SYSTEM_CONFIG_USE_POSIX_SOCKETS
* [Network.Framework] Update src/inet/InetInterface* files with some additional #ifdef for the network framework
* [Network.Framework] Update src/inet/IPAddress* files with some additional #ifdef for the network framework
* [Network.framework] Update src/inet/InetInterfaceImplDefault.cpp to enable the default implementation
* [Network.framework] Update src/system to not use WakeEvent/Signal when using the network framework
* [Network.framework] Convert UDPEndPointImplNetworkFramework.cpp to .mm with arc support
* [chip-tool] Ensure each commissioner listen onto its own udc port since Network.framework won't allow SO_REUSEPORT
* [Matter.framework][darwin-framework-tool] Add chip_system_config_use_network_framework flag support
* Apply suggestions from code review
---------
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Move more of the MTRAttributeValueWaiter logic into the waiter. (#36416)
* Move more of the MTRAttributeValueWaiter logic into the waiter.
This logic should not live in MTRDevice.
* Address review comments.
Do not use reverse commissioning to pair test server (#36490)
[Fabric-Sync] Port sync-device command from fabric-admin (#36507)
fan_control_server: Fix circular callback issue (#36489)
* fan_control_server: Fix circular callback issue
This PR fixes a circular callback bug in fan control server using flags
when updating SpeedSetting and PercentSetting.
Before this change, a PercentSetting write to 25% would end up circling
back to 30% as shown:
```
[MatterTest] 11-12 19:16:40.792 INFO @@@ WRITE PercentSetting to 25
[MatterTest] 11-12 19:16:40.801 INFO @@@ ATTRIB: EP1/FanControl/SpeedSetting: 3
[MatterTest] 11-12 19:16:40.802 INFO @@@ ATTRIB: EP1/FanControl/SpeedCurrent: 3
[MatterTest] 11-12 19:16:40.802 INFO @@@ ATTRIB: EP1/FanControl/PercentSetting: 30
[MatterTest] 11-12 19:16:40.802 INFO @@@ ATTRIB: EP1/FanControl/PercentCurrent: 30
```
Now it behaves as expected:
```
[MatterTest] 11-13 18:54:27.961 INFO @@@ WRITE PercentSetting to 25
[MatterTest] 11-13 18:54:27.970 INFO @@@ ATTRIB: EP1/FanControl/SpeedSetting: 3
[MatterTest] 11-13 18:54:27.970 INFO @@@ ATTRIB: EP1/FanControl/SpeedCurrent: 3
[MatterTest] 11-13 18:54:27.970 INFO @@@ ATTRIB: EP1/FanControl/PercentSetting: 25
[MatterTest] 11-13 18:54:27.971 INFO @@@ ATTRIB: EP1/FanControl/PercentCurrent: 25
```
Co-authored-by: lpbeliveau-silabs <louis-philip.beliveau@silabs.com>
* Addressed review suggestions
---------
Co-authored-by: lpbeliveau-silabs <louis-philip.beliveau@silabs.com>
[Telink] fix stack sizes to avoid 90% usage (#36485)
* [Telink] Add temporarry THREAD_ANALYZER to check stack sizes during crash
* [Telink] fix configs
* [Telink] Increase OpenThread stack (98% usage during OTA)
* [Telink] Set INFO as default MCUboot log level
* [Telink] define CHIP_TASK_STACK_SIZE from one place
* [Telink] Add thread-analyzer as target build
* [Telink] decrise BOOT_MAX_IMG_SECTORS
* [Telink] temporary enable THREAD_ANALYZER by default
* [Telink] Increase stack sizes to avoid 90+% usage
* [Telink] increase more
* [Telink] set THREAD_ANALYZER=n by default
[NXP][platform][common] Remove unrequired config defines to use default values instead (#36497)
Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
[nxp][examples][rt1060] Update WiFi credentials setting in RT1060 readme (#36496)
Add missing #include for size_t (#36474)
[Chef] add Multi-sensor (#36469)
* Chef add multi sensor
* Fix compilation issues
* Remove Groups cluster,fix by TC_DeviceConformance.py
FIX TC_EEVSE_2_3 test fail when run in EST timezone (#36500)
* Ensure calculation of target_time_delta in compute_expected_target_time_as_epoch_s is done fully in UTC
* Restyled by autopep8
---------
Co-authored-by: Restyled.io <commits@restyled.io>
Improve detection of "historical" events in Matter.framework. (#36506)
We were marking events as "historical" if there were any attributes in the same
report that have the C quality. This had a few problems:
* Some devices randomly report C-quality attributes, for various reasons.
* Some attributes stop having the C quality in favor of Q, in some cases, so
this is not very forward-compatible.
The fix is to remove this C-quality check altogether. At that point we have the
following situations:
1. We're setting up a new subscription and getting our initial priming report.
This case will still have _receivingPrimingReport set, and will cause any
events reported as part of priming to be marked "historical".
2. We are getting a "priming" report from a server-side subscription resumption
after the server timed out on a subscription. If this happens before the
max-interval elapses, we will see this as a normal report on our
subscription, but with all attributes and events the server knows about
included. In this case, we mark ourselves as being in a "priming report" if
we get an event that has an event number we have already seen, so that we
mark any not-seen-before events in that report as "historical", since we
don't know how long ago they are from.
3. We are getting a normal incremental report, and will not mark any such events
as "historical".
Since we are now keeping track of last-received event numbers, we can also use
those for our subscriptions and can filter out any events that have an event
number no greater than our last-observed one.
Added the data_model_xmls.gni within matter testing infrastructure for data model python packaging (#36499)
* Added data models gni file and consumed it using via BUILD.gn
* Update build_python.sh with chip testing wheel modifications
* Restyled by gn
---------
Co-authored-by: Restyled.io <commits@restyled.io>
Fix crash in NamedPipeCommands.cpp caused by stack-buffer-underflow (#36465)
* Fix stack-buffer-underflow in NamedPipeCommands.cpp
* Update NamedPipeCommands.cpp
ESP32: Fix compile error for esp32h2 and add config for dynamic server (#36432)
* ESP32: Fix compile error for esp32h2 and add config for dynamic server
* add esp_wifi_lib if wifi enabled
[script] Add core.symlinks=true to submodules init (#36498)
On Windows, symlinks in submodules are detected as simple text files.
Adding this option to the git submodule command correctly detects the
symlinks.
Signed-off-by: marius-alex-tache <marius.tache@nxp.com>
[Darwin] add API to get public key without leaks (with fixes) (#36340)
* Initial checkin
* Fixing review feedback
* Adding braces
* Restyled by clang-format
* Fixing build
* Restyled by clang-format
* Fixing annotations
* Update src/darwin/Framework/CHIP/MTRKeypair.h
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* separate statements involving _mPublicKey to make compiler happy
* use `CFAutorelease` on CoreFoundation typed public key copies
* fix indent
* implement `copyPublicKey` for `MTRTestKeys`; add TODO note about optional method calls
* remove comment
it's a test; this is the best we can do with an optional protocol method
* consistent formatting for `copyPublicKey` calls
* reformat `copyPublicKey` in `MTRTestKeys`
remove comment - not this method's job to worry about other implementation's potential side-effects
* Update src/darwin/Framework/CHIP/MTRKeypair.h
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* re-add `publicKey` in `CHIPToolKeypair`
check compatibility in CI before going back and removing
* use `copyPublicKey` in more places
* dedupe public key cache population for CHIPToolKeypair
* Restyled by clang-format
* try manually releasing pubkey in test
* leakfix: MTRP256KeypairBridge
* leakfix: `MTRCertificateTests.testGenerateCSR`
* remove unnecessary plain `publicKey` implementation
* temporarily do the inelegant patch on CFAutorelease
* fix another remaining `publicKey` instance
* Restyled by clang-format
* fix `publicKey` deprecation, marking for future release
---------
Co-authored-by: Justin Wood <woody@apple.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
[nrfconnect] Fix all-clusters-app settings size (#36501)
After switching to building with sysbuild, the source of
the settings partition size has changed from the DTS to
the partition manager. Make sure the settings partition
is 32kB even when building all-clusters-apps without
DFU support.
Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
Darwin XPC: allow `NSDate` typed objects in `internalProperties` dictionary (#36514)
[Fabric-Sync] Fix failing to pair sync device (#36510)
* Fix failing to pair sync device
* Address review comments
* Address review commment
[Fabric-Admin] Set remote bridge after reverse pair the bridge device (#36451)
* [Fabric-Admin] Set remote bridge after reverse pair the bridge devide
* Add remote bridge to local bridge after pairing
* Set the reverse commissioning flag
* Do not add device as a bridged device after reverse pairing
* Fix compare error
* Address review comments
fan-control-server: Fix FanMode circular callback issue (#36515)
Similar to what was done for Speed and Percent, this PR fixes a bug where
a FanMode could result in a circular callback.
For example, setting the FanMode to kAuto, could trigger this issue.
chef-fan-control: Remove unnecessary circular callback checks (#36517)
* chef-fan-control: Remove unnecessary checks
With the recent circular callback bugfixes done in the cluster code in
pull/36515 and pull/36489, we can now safely remove unnecessary checks
that prevented the circular callbacks in the app side.
* remove unused includes/imports.
[Telink] Update Docker image (Zephyr update) (#36530)
* [Telink] Update Docker image (Zephyr update)
* [Telink] Update Docker image (Zephyr update)
Wrong title on the ST index (copy/paste error) (#36529)
Add a helper function for getting P256PublicKey from MTRKeypair. (#36520)
That way we are not ending up with multiple copies of finicky code.
Correct description of device controller callbacks (#36531)
Update Coding style documentation (#36275)
* Update coding style guide
- removed most of the motivation sections as it was somewhat
repetitive and made the doc quite verbose
- removed the drawing because it doesn't match the SDK implementation
in reality
- removed C discussion - I don't think we have any
- added python versions. Didn't add the other languages because I
dont' know but other folks can easily add a follow up
- added sections on
+ formatters
+ anonymous namespaces for internal stuff in cpp files
+ singletons
+ std containers to heap allocation sections
+ CopySpanToMutableSpan
+ std::optional
+ python section
- removed the code samples from heap allocation because it implies
that people show re-implement these things when the preference is
to use the provided support classes
- removed the version table - we have git history.
* Move coding style into main style dir
* Use md since that's why the doc wasn't included
* Restyled by prettier-markdown
* add new words to wordlist
* Add clarification about heap allocation
* Add clarification about code removal
* add isort ref to formatter table
* add ruff
* use links
* Apply suggestions from code review
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* address review comments
* Add link suffix toml to wordlist
---------
Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
[Fabric-Sync] Set remote bridge after reverse pair the bridge device (#36509)
* Set remote bridge after reverse pair the bridge device
* Address review comment
Update the readme of fabric-sync app based on the latest update (#36540)
* Update the readme of fabric-sync app based on the latest update
* Restyled by prettier-markdown
* Remove extra comma
---------
Co-authored-by: Restyled.io <commits@restyled.io>
[Telink] Add tl3218x board support & Update builds to docker version 92 (#36409)
* [Telink] Add TL3218X sceleton
* [Telink] Disable temporarry BLE
* [Telink] save ram by change config & revert add retention board
* riscv: telink:tl3218x: clean code and fix CI.
- fix CI error.
- clean code and improve settings.
- delete retention setting for TL321X.
Signed-off-by: Haiwen Xia <haiwen.xia@telink-semi.com>
* [Telink] Revert add retention board
---------
Signed-off-by: Haiwen Xia <haiwen.xia@telink-semi.com>
Co-authored-by: Alex Tsitsiura <s07641069@gmail.com>
* riscv: telink:tl3218x: add ble optimize.
- add optimize for ble.
- low down the ramcost.
- revert nvs cache to pass certify.
Signed-off-by: Haiwen Xia <haiwen.xia@telink-semi.com>
* [Telink] Add LZMA compression support for TL321x platform
Signed-off-by: Jinmiao Yu <jinmiao.yu@telink-semi.com>
* [Telink] Use LZMA by default for tl321x
* [Telink] CI build tests
* Restyled by clang-format
* [Telink] Update Config B9X_BLE_ to TL_BLE_
Signed-off-by: Damien Ji <yinghao.ji@telink-semi.com>
* [Telink] update zephyr revision for CI build tests
Signed-off-by: Damien Ji <yinghao.ji@telink-semi.com>
* [Telink] update zephyr revision for CI build tests
Signed-off-by: Damien Ji <yinghao.ji@telink-semi.com>
* [Telink] Cleanup overlays
* [Telink] update zephyr revision for CI build tests
Signed-off-by: Damien Ji <yinghao.ji@telink-semi.com>
* [Telink] Increase ISR and CHIP stack sizes to avoid 90%+ usage
* [Telink] Update builds to docker version 92
---------
Signed-off-by: Haiwen Xia <haiwen.xia@telink-semi.com>
Signed-off-by: Jinmiao Yu <jinmiao.yu@telink-semi.com>
Signed-off-by: Damien Ji <yinghao.ji@telink-semi.com>
Co-authored-by: haiwentelink <125550736+haiwentelink@users.noreply.github.com>
Co-authored-by: Haiwen Xia <haiwen.xia@telink-semi.com>
Co-authored-by: Jinmiao Yu <jinmiao.yu@telink-semi.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Damien Ji <yinghao.ji@telink-semi.com>
[nxp][examples][contact-sensor][zap] Update zap files (#36513)
* [nxp][examples][contact-sensor][zap] Update zap files
* Update cluster version
* Update AccessControl feature map
* Add OTA Requestor device type to EP0
* [nxp][examples][contact-sensor][zap] Disable Extension ACL attribute
Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com>
---------
Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com>
Add unit test for deleting CommandSender when response is pending (#36536)
TC-IDM-4.2: Remove yaml, now has a python impl (#36518)
Handle ACL and readability in `reporting/Engine.cpp` (#36488)
* Move ACL validation in reporting engine for reads
* Fix up logic for ACL & return codes
* Take into consideration global attributes: their ACL is ok
* Make testread pass (with hacks because the test is not sane)
* Update comment and model setting.
* Another comment update
* Fix includes
* Fix typo
* Restyled by clang-format
* Update comment
* Update ACL test logic and revert testread to original setup
* Restyle
* Address review comments
* Restyle
* Update src/app/reporting/Engine.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Update src/app/reporting/Engine.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Update src/app/reporting/Engine.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Update src/app/reporting/Engine.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Update src/app/reporting/Engine.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Restyle
* Fix extra bracket
---------
Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Co-authored-by: Andrei Litvin <andreilitvin@google.com>
[Telink] Update Docker image (Zephyr update) (#36563)
[nxp][platform][k32w0] Remove KVS logs for init phase (#36553)
* [nxp][platform][k32w0] Remove KVS logs for init phase
Signed-off-by: marius-alex-tache <marius.tache@nxp.com>
* Restyled by whitespace
---------
Signed-off-by: marius-alex-tache <marius.tache@nxp.com>
Co-authored-by: Restyled.io <commits@restyled.io>
setup: support installations with Python3.13 (#36549)
[NXP][third_party] Fixed memory leak in BR mDNS code (#36543)
* [NXP][third_party] Fixed memory leak in BR mDNS code
This commit fixes potential memory leaks that could happen
if multiple resolve of browse operations are done without
calling the appropriate stop function to clean up the
allocated resources. If using the Matter CLI this issue
is not possible as the CLI always stops the previous
operation but other processes calling the resolve/browse
API might not follow this flow.
Also fixed the return value of the StopBrowse function.
Signed-off-by: Marius Preda <marius.preda@nxp.com>
* Restyled by clang-format
---------
Signed-off-by: Marius Preda <marius.preda@nxp.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Delete user and group in case of conflicts (#36528)
[Fabric-Sync] Implement pair-device command (#36508)
* [Fabric-Sync] Port pair-device command from fabric-admin
* Update examples/fabric-sync/shell/ShellCommands.cpp
Co-authored-by: Terence Hampson <thampson@google.com>
---------
Co-authored-by: Terence Hampson <thampson@google.com>
Fix cluster Bridged Device Basic Information in matter-devices.xml (#36467)
Fixes Carbon Monoxide Concentration Measurement in matter-devices.xml (#36466)
Fixes Carbon Monoxide Concentration Measurement in matter-devices.xml
[Silabs] Replace rvc by dishwasher in SL example (#36367)
* Replace rvc by dishwasher
Replace rvc by dishwasher
* Restyle
[ameba] Ameba SNTP and observer support (#36382)
* [ameba] Support Time Syncronization Using SNTP
* [ameba] Synchronize RTC with SNTP
* [ameba] Add CONFIG_ENABLE_AMEBA_SNTP to config/ameba/chip.cmake and run restyle-diff.sh
* [ameba] Add Ameba Observer for Ameba Examples
* [Ameba] Fix build with all-clusters-minimal-app and SystemTimeSupport.cpp
* [Ameba] Update Docker Version to 91
* [Ameba] moved AmebaObserver.h to examples/platform/ameba/observer/ and updated Ameba cmake
* [Ameba] simplified #if defined(CONFIG_ENABLE_AMEBA_SNTP) && (CONFIG_ENABLE_AMEBA_SNTP == 1) to #if CONFIG_ENABLE_AMEBA_SNTP
---------
Co-authored-by: Andrei Litvin <andy314@gmail.com>
Add APIs to access default SessionKeystore & PersistentStorageDelegate (#36566)
* Add APIs to access default SessionKeystore & PersistentStorageDelegate
* Restyled by whitespace
---------
Co-authored-by: Restyled.io <commits@restyled.io>
[Fabric-Sync] Support icd-registration during device sync (#36569)
[Telink] Improve B92 retention target & Update builds to docker version 93 (#36552)
* riscv:b92: fix ble thread overflow.
- cut down the ramcost for b92 retention mode.
- move the .ramcode to retention .
Signed-off-by: Haiwen Xia <haiwen.xia@telink-semi.com>
* Restyled by whitespace
* Restyled by clang-format
* [Telink] Update hash of latest Zephyr to check builds
* [Telink] Update builds to docker version 93
* riscv:b92: clean code and adjust config.
- change the kconfig.default value .
- merge the same setting for save ram.
Signed-off-by: Haiwen Xia <haiwen.xia@telink-semi.com>
* [Telink] Update builds to docker version 93
---------
Signed-off-by: Haiwen Xia <haiwen.xia@telink-semi.com>
Co-authored-by: Haiwen Xia <haiwen.xia@telink-semi.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Have `DataModel::Provider` be an argument to Server Init parameters (#36558)
* Set a provider in server init
* Restyle
* Fix some include dependencies
* Add back missing include
* Undo change for nrf
* Add import for android
* Undo qpg change
* Update examples/all-clusters-app/nrfconnect/main/AppTask.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Update examples/light-switch-app/qpg/src/AppTask.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Update examples/lock-app/nrfconnect/main/AppTask.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Update examples/lit-icd-app/nrfconnect/main/AppTask.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Update src/controller/python/chip/server/ServerInit.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Help users update
* Added comment
* Restyled by prettier-markdown
* Update examples/lock-app/qpg/src/AppTask.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Update examples/platform/infineon/cyw30739/matter_config.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Update examples/platform/telink/common/src/AppTaskCommon.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Update examples/pump-app/nrfconnect/main/AppTask.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Update examples/platform/openiotsdk/app/openiotsdk_platform.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Fix includes
* Removed an include
* Update examples/pump-controller-app/nrfconnect/main/AppTask.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Update examples/shell/shell_common/cmd_server.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Update examples/window-app/nrfconnect/main/AppTask.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Remove extra include
* More comments updated
* Remove unneeded dependency
* Fix log
* Update src/app/server/Server.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Remove double init
---------
Co-authored-by: Andrei Litvin <andreilitvin@google.com>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Co-authored-by: Restyled.io <commits@restyled.io>
TC_WHM_2_1: Fix incorrect --aplication argument (#36578)
It should be `water-heater` instead of `evse`.
use VerifyOrDie instead of assert() (#36583)
Improve logging in setPersistedClusterData. (#36581)
Before this change we would log setPersistedClusterData claiming we don't know
our VID/PID/etc, though chances are the data being passed in exactly contains
that information.
In the new setup, we update our state, then log.
If an XPC client doesn't care about a nodeID (hasn't made it), don't create one (#36586)
* Fixing infinite loop
* Restyled by clang-format
---------
Co-authored-by: Restyled.io <commits@restyled.io>
ESP32: fix typo to include correct Span.h in secure cert data provider (#36589)
* ESP32: fix typo to include correct Span.h in secure cert data provider
* restyle
[Linux] Fix crash when shutting down BLE Manager after platform shutdown (#36550)
[Linux] Reuse short UUID defined in BLE layer (#36557)
* [Linux] Reuse short UUID defined in BLE layer
* Restyled by clang-format
---------
Co-authored-by: Restyled.io <commits@restyled.io>
Add pigweed.json to root and opt out to cli analytics (#36598)
Better logging when Darwin.framework is asked to encode an incorrect type in a list. (#36599)
[Silabs] Adds changes for min and max values of refrigerator temperature controlled cabinet (#36592)
* Adds changes for min and max values of refrigerator temperature control cabinet
* Removed the manual set for temperatureset-point
* Converting Fahrenheit to Celsius min max values
[Darwin][Ble] Keep scanning while connecting to a device until didConnectPeripheral fires (#36595)
Use _deviceForNodeID:createIfNeeded: in more places. (#36602)
We had some manual lock-and-get code that can go away now.
ESP32: Fix building chip_gn for cmake v3.31.x and onwards (#36606)
remove the WORKING_DIRECTORY from chip_gn target
For cmake v3.31.x, custom command generated for chip_gn-build in
build.ninja concats the $WORKING_DIRECTORY and $BUILD_DIR paths and
it mess up the chip_gn step when building example.
COMMAND = cd "/Users/account/esp-matter/connectedhomeip/connectedhomeip/config/esp32/components/chip;/Users/account/esp-matter/examples/light/build/esp-idf/chip" && ninja esp32
For cmake version prior to v3.31, it do not prepend the
$WORKING_DIRECTORY path.
COMMAND = cd /Users/account/esp-matter/examples/light/build/esp-idf/chip && ninja esp32
This could be becuase of https://github.com/Kitware/CMake/commit/f5f80305ef69dd33fbedd31ef1d2cfd3d2bc15b4
related issue - https://github.com/espressif/esp-matter/issues/1157
Add SWVersion in OTAFragment (#36590)
[nxp][platform][mcxw71_k32w1] Relocate key storage default option to example apps args definition files (#36577)
The GN args file for the MCXW71/K32W1 platforms defines a default
for the "nxp_nvm_component" option which prevents the users from
selecting a different option in the command line. The default value
for this build option is already defined by the
third_party/nxp/nxp_matter_support/gn_build/nxp_sdk.gni
GN arguments file. If one would want to override the default, this
has to be done in the scope of the application so that the user can
also override the build option from the command line.
Signed-off-by: Marian Chereji <marian.chereji@nxp.com>
energy-management-app: Add boost state in WaterHeater README (#36338)
* Add boost state in WaterHeater README
* Format
Implement Operational State Cluster PhaseList attribute (#36350)
* Update chef-operational-state-delegate-impl.h
opPhase
* Update chef-operational-state-delegate-impl.h
Implement mOperationalPhaseList
* Restyle
* Update chef-operational-state-delegate-impl.h
Use CharSpan
* Update chef-operational-state-delegate-impl.h
* Clean
[ESP32]: fix compile error for c6 bt lib path (#36332)
* esp32: fix compile error for c6 bt lib path
* Add warning message if no libble_app.a is found.
[Fabric-Sync] Cleanup pass through APIs (#36604)
[Crypto] replacing OpenSSL-specific flag by new public API (#36608)
This is a follow_up to #36386 based on a post-merge comment,
- an OpenSSL-specific mInitialized flag was added to HASH_SHA256 to check if digest computation was initialised, which isn't used for other Crypto Backends
- Fix: replace by a Public API `IsInitialized`, with its implementation for OpenSSL/BoringSSL
Add AsyncFacilitator to enable an async, event-driven, non-polling me… (#29364)
* Add an AsyncTransferFacilitator that supports BDX transfer using an event driven approach rather than polling
- Update the OTA provider darwin implementation to use the AsyncTransferFacilitator to transfer the OTA file using BDX
* Editorial fixes
* Restyled by whitespace
* Restyled by clang-format
* Apply suggestions from code review
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Addresssed review comments
* Restyle
* Apply suggestions from code review
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Address review comments
* More fixes
* Restyle
* Apply suggestions from code review
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Apply suggestions from code review
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Address more review comments
* Apply suggestions from code review
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Address review comments
* Apply suggestions from code review
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Fix restyled issues.
* Add missing header
* Address review comments.
---------
Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Incremental improvements to controller dependencies (#36567)
* Remove unused reference to CHIP_CONFIG_ENABLE_READ_CLIENT
* ExamplePersistentStorage does not need CHIPDeviceController
* Tidy up some Linux app-main dependencies
* Reduce dependency of data model on controller
* Fix log placerholders to use ChipLogFormatX64 in fabric sync example
[Fabric-Admin] Clean up pass through functions from Device Manager (#36614)
* [Fabric-Admin] Clean up pass through functions from Device Manager
* Restyled by clang-format
---------
Co-authored-by: Restyled.io <commits@restyled.io>
Set `dataModelProvider` as a required argument for `Controller::FactoryInitParams` (#36613)
* Add dataModelProvider to Factor init parameters for the codegen data model provider
* make setting the same data model on interaction model provider a noop
* Fix compile
* Fix links
* Restyle
* Restyled by prettier-markdown
* Fix text
* Fix some deps
* Restyled by gn
* Remove dependencies/auto-init of codegen data model in the interaction model. We now fully expect all applications to provide a data model provider
* Fix include
* Update src/app/InteractionModelEngine.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Address some code review comments
* Fix unit tests
* Restyle
* Add more comments about why we have very intentional ordering
---------
Co-authored-by: Andrei Litvin <andreilitvin@google.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Mark _deviceForNodeID:createIfNeeded: as possibly returning nil. (#36617)
Add some constraint checks to the colorcontrol cluster commands (#36542)
* add some constraint checks to the colorcontrol cluster commands
* Update src/app/clusters/color-control-server/color-control-server.cpp
Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com>
* Addrese comments. Move ConstraintCheck Before Unsupported command checks. Add contraint checks for ColorTemperatureMireds arguments
* Update src/app/clusters/color-control-server/color-control-server.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
---------
Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Make Hash_SHA256_stream::IsInitialized() protected (#36633)
[NXP] Update Thermostat ZAP files to fix IDM errors (#36612)
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
BDX transfer support for Python tests (#34821)
* Add the python-C++ translation.
* Add a BDX transfer server to handle unsolicited BDX init messages.
* Add the manager to implement the transfer pool.
* Add the initial implementation of a BDX transfer.
* Use BdxTransfer in the other classes.
* Update constructors to set the delegates etc. correctly.
* Implement the C++ side of the barrier. Move the data callback into the transfer delegate.
* Add a way to map the transfer to the python contexts.
* Fix some of the minor TODOs.
* Add init/shutdown to the transfer server.
* Start on the implementation of the Python side.
Also add the transfer obtained context to the C++ methods relating to expecting transfers.
* Listen for all BDX protocol messages rather than just the init messages.
* Fix minor issues in the transfer server.
* Implement a good chunk of the python side.
* Fix compile errors.
* Fix a number of issues preventing the BDX python code from running at all.
* Return the results of the python-C methods.
* Fix the async-ness of the methods that prepare the system to receive a BDX transfer.
Also run the python BDX initialisation.
* Initialise the BDX transfer server.
Also ignore the BDX transfer server implementation that only handles diagnostic logs.
* Fixes necessary to await on the future from PrepareToReceive/SendBdxData.
* Call Responder::PrepareForTransfer from BdxTransfer.
* Correctly schedule satisfying the future on the event loop.
* Use the real property to determine if a PyChipError was a success.
* Fix sending the accept message.
* Acknowledge received blocks so the BDX transfer continues.
Also don't ignore all messages after the init.
* Fix the parameters of the python callback methods.
* Add another async transaction class to handle the transfer completed callback.
* Add comments to the C++ code.
* Add a test for the BDX transfer that uses the diagnostic logs cluster.
* Move the calls to release a transfer out of the manager so it works the way one would expect.
* Delay releasing the C++ BDX transfer object until after it's no longer in use.
* Verify the diagnostic logs response is a success.
* Restyled by whitespace
* Restyled by clang-format
* Restyled by gn
* Restyled by autopep8
* Restyled by isort
* Improve BdxTransferManager's comments.
* Use a vector for the data to send over a BDX transfer rather than a raw pointer.
* Minor renames.
* Improve the error message when the BDX transfer pool is exhausted.
* Minor fixes.
* remove a check that was inadvertently kept.
* print a log message when something that shouldn't happen inevitably does.
* use user_params to get the end user support log test parameter.
* Pass the status report's status code up the stack.
* Merge the BDX transfer server into the manager.
* Rename BdxTransferManager to TestBdxTransferServer.
* Minor cleanup.
* Rename TransferData to TransferInfo.
* Change `!=` to `is not` in python.
* Add missing type annotation.
* Improve the documentation of the ownership in the C++ side.
* Restyled by clang-format
* Restyled by autopep8
* Update the new test to work with the new formatting.
Also remove an unnecessary conversion to bytearray.
* Lint fixes.
* Fix clang-tidy errors.
* Several fixes suggested by Andrei.
* Fix a name in a comment.
* Fix issues preventing test from working.
Also:
* Split the accept function into one for sending data and one for receiving data.
* Return bytes instead of a bytearray when receiving data.
* Add typing to the data callback.
* Rename the methods that accept transfers so it's clear which way the data is flowing.
* Add doc comments to the Python classes and methods.
* Fix issues found by mypy.
* Restyled by clang-format
* Restyled by autopep8
* Fix python lint error.
* Explicitly truncate the status code when generating the error.
* Generate the diagnostic log to transfer in the test.
---------
Co-authored-by: Restyled.io <commits@restyled.io>
[Fabric-Sync] Fix segment fault during fabric admin initialization (#36635)
[Implementation] Adding get_endpoint functionality to matter_testing support module (#36568)
* Incorporating new get_endpoint functionality in matter_testing support module:
- Added prior previous get_endpoint functionality from Cecille back to matter_testing support module.
- Updating test modules to use new get_endpoint functionality mentioned in issue: https://github.com/project-chip/matter-test-scripts/issues/416
* Restyled by autopep8
* Updated TC_OCC_3_2 to resolve linting errors
---------
Co-authored-by: Restyled.io <commits@restyled.io>
TC-OPCREDS-3.4: Automate (#33541)
* chore(TC_OPCREDS_3.4): skeleton class
* chore(TC_OPCREDS_3.4): implementation until step CSRRequest IsForUpdatedNOC=True
* chore(TC_OPCREDS_3.4): All test step are implement using the old way to printed them
* chore(TC_OPCREDS_3.4): patch from restyled code
* chore(TC_OPCREDS_3.4): restyled by autopep8
* chore(TC_OPCREDS_3.4): fix code-lints
* chore(TC_OPCREDS_3.4): add suggestions
* chore(TC_OPCREDS_3.4): steps _method instead print each step and add suggestions
* chore(TC_OPCREDS_3.4): fix restyled
* chore(TC_OPCREDS_3.4): fix re-implementation validate single entry certs
* chore(TC_OPCREDS_3.4): fix resyled
* chore(TC_OPCREDS_3.4): reverting commissioningBuilingBlocks without icac and nocBytes
* chore(TC_OPCREDS_3.4): fix matter_testing_support ModuleNotError
* chore(TC_OPCREDS_3.4): added and replaced some outcomes/methods for TestSteps
* chore(TC_OPCREDS_3.4): fix restyled
* chore(TC_OPCREDS_3.4): fix restyled
* chore(TC_OPCREDS_3.4): added suggestions
* chore(TC_OPCREDS_3.4): added expected outcomes for some test step
* chore(TC_OPCREDS_3.4): fix restyled
* chore(TC_OPCREDS_3.4): fix f-strings without any placeholder
* chore(TC_OPCREDS_3.4): implemented all expected outcomes for all steps
* chore(TC_OPCREDS_3.4): fix restyled
* Update src/python_testing/TC_OPCREDS_3_4.py
Needs the PICS function
Co-authored-by: C Freeman <cecille@google.com>
---------
Co-authored-by: C Freeman <cecille@google.com>
[Test] Creating TC_CADMIN_1_22 and TC_CADMIN_1_24 python test modules (#35632)
* [Test] Creating TC_CADMIN_1_22 and TC_CADMIN_1_24:
- Created CADMIN_1_22 python test module following steps in PR here:
- Created CADMIN_1_24 python test module following steps in PR here:
- Removed following yaml test modules:
-- Test_TC_CADMIN_1_21.yaml, Test_TC_CADMIN_1_22.yaml, Test_TC_CADMIN_1_23.yaml, Test_TC_CADMIN_1_24.yaml
* Restyled by autopep8
* Updating TC_CADMIN_1_22 and TC_CADMIN_1_24:
- Resolved linting issues
* Created TC_CADMIN_1_22_24 test module:
- Merged TC_CADMIN_1_24 and TC_CADMIN_1_22 standalone test modules into a single test module
- Found enum for window closed value and replaced it in the tests
- Removed generate_unique_value and AttemptCommission functions
- Updated CI arguments format to YAML'esque format
* Restyled by autopep8
* Updated TC_CADMIN_1_22_24:
- Renamed class to TC_CADMIN_1_22_24
* Updating TC_CADMIN_1_22_24:
- Resolving lint errors
* Update TC_CADMIN_1_22_24.py
Updated to include dependency location change for matter_testing support module
* Updated TC_CADMIN_1_22_24.py:
- Resolved issues with CI args in TC_CADMIN_1_22_24 test module
- Removed yaml calls for 1_21, 1_22, 1_23, and 1_24, also removed yaml call for 1_9 from manualTests.json
* Updating TC_CADMIN_1_22_24 test module:
- Resolving comments from tehampson as these were needed changes to be made
-- Substituted to using cleaner code for assert.asserts_equal instead of just assert.failure
-- Resolving copy paste error in TC_CADMIN_1_4 test
-- Made comments cleaner by rewording to include what the error code was referring too
* Update TC_CADMIN_1_22_24 test module:
- Changing method for test step 3 on TC_CADMIN_1_24 test now using timeout for 30 seconds instead of revoke commissioning
* Restyled by autopep8
* Update TC_CADMIN_1_22_24.py
- Unnesting asserts from if statements
* Update src/python_testing/TC_CADMIN_1_22_24.py
- Adding this suggested change from Terrence into the code, as it does make the code much cleaner
Co-authored-by: Terence Hampson <thampson@google.com>
* Update TC_CADMIN_1_22_24.py
-Updating to changing static value to being stored in variable for easier readability as Terrence has suggested, making the code easier to read.
* Restyled by autopep8
* Updated TC_CADMIN_1_22_24 test module:
- Removed unneccessary await from asserts
* Restyled by autopep8
---------
Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Terence Hampson <thampson@google.com>
[Test] Creating CADMIN 1.19 python3 test module (#35611)
* [Test] Creating CADMIN 1.19 test module:
- Test module created following steps in PR: https://github.com/CHIP-Specifications/chip-test-plans/pull/4669
* Restyled by autopep8
* Update TC_CADMIN_1_19 test module:
- Resolving linting issues
* Removing yaml test module for TC_CADMIN_1_19:
- Removed yaml test as we have created python test module in its place
* Update TC_CADMIN_1_19.py
- Removed debugging print statements as no longer needed in test code
* Update src/python_testing/TC_CADMIN_1_19.py
Co-authored-by: C Freeman <cecille@google.com>
* Update src/python_testing/TC_CADMIN_1_19.py
Co-authored-by: C Freeman <cecille@google.com>
* Updating TC_CADMIN_1_19 and matter_testing scripts:
- Updated CI Arguments
- Updated dependency location for matter_testing_support
- Removed local OpenCommissioningWindow function, updated to using MatterBaseTest version
- Removed local CommissioningAttempt function, moved to using function call directly in test
- Removed initialization of TH2 controller as not needed
- Removed additional dictionary names and delimited it down to just using numbers instead.
- Updated matter_testing support script to include setting timeout value dynamically in openCommissioningWindow function
* Restyled by autopep8
* Update TC_CADMIN_1_19.py
Resolving Linting errors
* Update TC_CADMIN_1_19.py
- Moved location of print_step to top of for range for creating virtual fragments
- Removed unnecessary print_step for catching error
* Updated TC_CADMIN_1_19 test module:
- Created new variable for current_fabric + 1
- Replaced if statements with asserts.assert_equal()
- Changed start of range from 1 to 0
- Changed test steps to match test plan better, removed test step 1
* Restyled by autopep8
* Updated TC_CADMIN_1_19 test module:
- Added new criteria to test step 3 where max_fabrics is checked to make sure it is greater than initial_fabrics count
* Updated TC_CADMIN_1_19 test module:
- Removed print statement from debugging session
* Restyled by autopep8
---------
Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: C Freeman <cecille@google.com>
[Silabs] Add Trigger events from Matter CLI to README (#36570)
* Add refrigeratoralarm event to README.md
Add refrigeratoralarm event
* Update README.md
* Update README.md
Trigger events from Matter CLI
* restyled
* Update .wordlist.txt to add refrigeratoralarm
* Update Refrigerator README.md
[NXP] Add EL2GO factory data impl, change default rw61x factory data impl (#36615)
* [NXP][platform] Add EL2GO factory data implementation, update default factory data implmentation to use secure element
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
* [NXP][exmples] Add EL2GO factory data implementation, update default factory data implmentation to use secure element
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
* [NXP][script] Add EL2GO factory data implementation
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
* [NXP][doc] Add EL2GO factory data implementation, update default factory data implmentation to use secure element
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
* Restyled by whitespace
* Restyled by clang-format
* Restyled by gn
* Restyled by prettier-markdown
* Restyled by autopep8
* Restyled by isort
* [NXP] fix spelling
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
* [NXP][submodule] Update NXP matter support submodule
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
* [NXP] Add factory data secure key storage compatiblity with actual factory data
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
---------
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Make IsInitialized implementation in OpenSSL backward compatible with older OpenSSL versions (#36634)
Add some additional `dataModelProvider` settings on server init (#36639)
* Add some missed registrations of dataModelProvider in server init
* Fix commissioner main dependencies (make nrf tests compile)
* Move around dependencies - apparently the commissioner main should be public
* Fix one more odd dependency
Resolve CommissionerMain dependency issues (#36632)
* Resolve CommissionerMain dependency issues
Note that CHIP_DEVICE_CONFIG_ENABLE_BOTH_COMMISSIONER_AND_COMMISSIONEE=1
requires chip_build_controller=true at the GN level, otherwise `lib` does
not pull in `controller`.
* Touch something in /tests/ to force NRF native_posix_64 tests to run
* Add nogncheck to conditional controller imports
dac_revocation: Perform cross validation against crl signer or crl signer delegator (#35144)
* dac_revocation: Support crl signer and crl signer delegator
- Add crl signer and crl signer delegator cert in the python script
which generates the revocation set
- perform the cross validation of DAC/PAI with crl signer and crl signer
delegator cert
- Extended and added unit tests for crl signer delegator case
* include algoright and remove the local var declaration
* use unused attribute
* Fix the buffer overrun and use maybe_unused instead of unused attribute
* we do not need to differentiate pai/dac when cross verifying
* add checks on return value and unit tests on malformed crl signer cert
* use std::string instead of const char *
* address some more reviews
* Update src/credentials/attestation_verifier/TestDACRevocationDelegateImpl.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
---------
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
removed unnecessary include (#36646)
[Silabs] Adds fix for support default value in refrigerator alarm cluster Refrigerator application (#36651)
* Adds changes for supported value
* Adds changes for the supported value
[Silabs] PSA Crypto PAL customized for EFR32. (#36575)
* [Silabs] PSA Crypto PAL customized for EFR32.
Adds SubscriptionInfoProvider API to check if a given fabric has at least 1 subscription (#36627)
* [SL-UP] Add fabric subscription check to the interaction model engine (#117)
* Remove unwanted change
* Restyle
* Improve readability
* Restyled by clang-format
* Update src/app/SubscriptionsInfoProvider.h
Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com>
---------
Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com>
[Silabs] Adds refrigerator app matter shell support for change door state (#36548)
* Added changes for the matter shell
* Added support for the matter shell refrigerator door state
* Added changes for the failure
* Adds required comment changes
* Added restyler changes
* Adds changes according to comment
[Fabric-Sync] Fix segment fault during fabric device sync (#36656)
energy-management-app: refactor WH and EVSE into separate endpoints and fix conformance issues (#36201)
* Add missing Water Heater device to matter-devices.xml
This PR adds the missing Water Heater device to matter-devices.xml.
The description was generated using the Alchemy tool
(https://github.com/project-chip/alchemy) with the following command:
`alchemy zap --attribute="in-progress" --sdkRoot=./connectedhomeip/
--specRoot=./connectedhomeip-spec/
./connectedhomeip-spec/src/device_types/WaterHeater.adoc`
I manually fixed the device nae from `Matter Water Heater` to `Water
Heater`.
* zap regen
* energy-management-app: Split WH and EVSE into 2 endpoints
This PR refactors the energy-management-app into 2 separate endpoints
(one for EVSE and another for WaterHeater).
This is the first step in making this app spec-conformant.
`TC_DeviceBasicComposition.py` failed on this app before this PR and now passes.
Changes:
* Split Water Heater and EVSE into two separate endpoints (1 and 2).
Updated zap and code.
* Dinamically disable unused endpoint at runtime. Based on the app choice
(command line argument on linux or #define in ESP32 or SIlabs), initialize
the clusters in the correct endpoint and disable the other endpoint.
For example, for Water Heater, initialize clusters on endpoint 2 and
disable endpoint 1 (EVSE).
* Refactor/move the init code related to ElectricalSensor (PowerTopology, EPM and EEM) from inside EVSE
into ElectricalSensorInit.h/.cpp so they can be easier to reuse by both WaterHeater and EVSE.
* Refactor/move DEM cluster init code into its own file so it can be
better reused outside EVSE.
Test performed:
1. Check basic composition for EVSE:
```
scripts/run_in_python_env.sh out/python_env './scripts/tests/run_python_test.py --app ./out/linux-x64-energy-management-no-ble/chip-energy-management-app --app-args "--application evse --trace-to json:log" --script src/python_testing/TC_DeviceBasicComposition.py --script-args "--qr-code MT:-24J0AFN00KA0648G00"'
```
2. Check basic composition for WaterHeater:
```
scripts/run_in_python_env.sh out/python_env './scripts/tests/run_python_test.py --app ./out/linux-x64-energy-management-no-ble/chip-energy-management-app --app-args "--application water-heater --trace-to json:log" --script src/python_testing/TC_DeviceBasicComposition.py --script-args "--qr-code MT:-24J0AFN00KA0648G00"'
```
3. Check app against `TC_EEVSE_2_6.py`:
```
rm -f evse.bin; ./out/linux-x64-energy-management-no-ble/chip-energy-management-app --enable-key 000102030405060708090a0b0c0d0e0f --KVS evse.bin --featureSet 0x3d
python src/python_testing/TC_EEVSE_2_6.py --endpoint 1 -m on-network -n 1234 -p 20202021 -d 3840 --hex-arg enableKey:000102030405060708090a0b0c0d0e0f
```
* Use anon namespace instead of static.
* disable enpoint on esp32 and silabs
* address Tennessee's PR feedback
* Review suggestion: move GetMainAppEndpointId to another file
* zap regen
* fix matter-devices white space diffs
* App now builds on all-clusters app
* Fix typo on init
* fix all-clusters breakage on esp32
* fix misuse of namespace in header
* Fix breakage for silabs water heater
* Update WaterHeater endpoint for CI tests
This fixes REPL test CI breakage.
* Update WaterHeater tests to endpoint 2
* Bumped ClusterRevisions
Cluster 40 (0x28) BasicInformation - 3 -> 4
Cluster 47 (0x2f) PowerSource - 2 -> 3
Cluster 48 (0x30) GeneralCommissioning 1-> 2
Cluster 3 (0x03) Identify 4 -> 5
Cluster 153 (0x99) EnergyEvse 2 -> 3
Cluster 157 (0x9d) EnergyEvseMode 1-> 2
Cluster 159 (0x9f) DeviceEnergyManagementMode 1-> 2
* Update AccessControl featureMap to enable Extension attribute
* Remove AccessControl extension attribute
* Remove kStateForecastReporting from the default feature map
That feature can't be enabled together with kPowerAdjustment.
* Update TC_WHM_1_2 endpoint to 2
* Fix various conformance issues
Remove PowerSource from root node and move to EP1/evse
Bump cluster revisions where needed
Fix device type descriptions for each EP
Remove unused Thermostat cluster and added a TODO. We need to properly
implement this cluster for this app for temperature control.
* TC_WHM_1_2: Use endpoint id passed as argument instead of hardcoded
[Silabs] General updates and fixes for the Silabs Wi-Fi platforms (#36628)
* [SL-UP] Remove two algo design for the wifi retry mechanism (#103)
* [SL-UP] Rename ot interval to transport interval (#108)
* [SL-UP] Delete unnecessary double abstraction for the wiseconnect power save functions (#109)
* [SL-UP] Update spi-multiplex header inclusion (#110)
* [SL-UP] Fix Builds after Wi-Fi interface refactor (#111)
* [SL-UP] Remove WF200 define duplication to avoid value conflicts at runtime (#126)
* fix spacing
* restyle
* Fix define name
* add missing function
* Fix wf200 ICD build
* Restyled by clang-format
* Add debug config
* Re added sem check
---------
Co-authored-by: Restyled.io <commits@restyled.io>
[Silabs] Move Wi-Fi interface files to the final structure (#36644)
* Move files
* Move wifi files to their final location & cleanup
* Restyled by clang-format
* rename directories
* rename paths for new locations
* Restyled by clang-format
* update include path with the structure
---------
Co-authored-by: Restyled.io <commits@restyled.io>
Deliver SIGINT to the shell thread to interrupt read() (#36533)
* Deliver SIGINT to the sell thread to interrupt read()
* Verify that TV apps exit cleanly
* TV casting app with proper shutdown on SIGTERM
* Fix import
* Revert sigaction() usage, as it seems not to work on Darwin
* Remove ifdefs
* Use signal() instead of sigaction() on Darwin
* Restyled by clang-format
---------
Co-authored-by: Restyled.io <commits@restyled.io>
Update light-switch-app/nrfconnect/README.md to fix privilege (#36657)
Update light-switch-app/nrfconnect/README.md to fix privilege
python.md: Add real example for run_python_test for the lighting_app (#36645)
This PR adds a real example for running the `run_python_test.py` script against the `chip-lighting-app`.
python.md: Fix python_env command (#36641)
* python.md: Fix python_env command
This PR fixes the python activation command in the tutorial.
From `source pyenv/bin/activate` to `source out/python_env/bin/activate`
* Restyled by prettier-markdown
---------
Co-authored-by: Restyled.io <commits@restyled.io>
[NXP][platform][RT][RW61x] Disable "chip_inet_config_enable_tcp_endpoint" gn arg (#36665)
* [NXP][platform][rt1060] Disable chip_inet_config_enable_tcp_endpoint
Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
* [NXP][platform][rt1170] Disable chip_inet_config_enable_tcp_endpoint
Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
* [NXP][platform][rw61x] Disable chip_inet_config_enable_tcp_endpoint
Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
---------
Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
Add skip_bytes functionality to OTA Provider and BDX downloader class (#36357)
[Silabs] Trustzone-compatibility. (#36643)
[Silabs] Silabs Uart Shell fixes (#36667)
* [SL-UP] Bugfix/silabs out rtt removal (#142)
* [SL-UP] Bugfix/matter shell crash nullptr (#125)
* Added checks on null ptr to prevent uart shell crash and modified ICD shell commands to be compatible with our internal structure
Update energy-management-app README.md (#36662)
* Update energy-management-app README.md
Add link to `kBasicInstallationTestEvent` definition
* Update README.md
* Update README.md
* Restyle
* Update README.md
Use commit it
Remove Active flag when the readhandler is going to be destroyed (#36653)
* remove Active flag when the readhandler is going to be destroyed
* Restyled by clang-format
---------
Co-authored-by: Restyled.io <commits@restyled.io>
Sync latest commits of the laundry-washer-app in nxp rw61x platform (#36664)
* Fix Matter 1.3 certifiction TC-LWM-1.1 case that feature-map should be 0
Signed-off-by: Chin-Ran Lo <nxf57500@lsv051039.swis.nl-cdc01.nxp.com>
(cherry picked from commit 21c40394dd0df65b1dd07e6cf9545f9d5cb1af25)
* Update laundry washer ZAP file to pass TC-IDM-10.2/10.4/10.5 during Matter 1.4 SVE
Signed-off-by: Oliver Fan <nxf90549@lsvm07u0000059.swis.us-west-2.aws.nxp.com>
[nxp toup][laundry-washer-app][common] Update laundry washer to pass TC-OPSTATE-2.6 during Matter 1.4 SVE
Signed-off-by: Oliver Fan <nxf90549@lsvm07u0000059.swis.us-west-2.aws.nxp.com>
[nxp toup][laundry-washer-app][RW612][RTOS] Update RW612 RTOS laundry washer app to pass TC-OPSTATE-2.6 during Matter 1.4 SVE
Signed-off-by: Oliver Fan <nxf90549@lsvm07u0000059.swis.us-west-2.aws.nxp.com>
[nxp toup][laundry-washer-app][RT1170][RTOS] Update RT1170+IW612 RTOS laundry washer app to pass TC-OPSTATE-2.6 during Matter 1.4 SVE
Signed-off-by: Oliver Fan <nxf90549@lsvm07u0000059.swis.us-west-2.aws.nxp.com>
[nxp toup][laundry-washer-app][RW612][Zephyr] Update laundry washer to pass TC-OPSTATE-2.6, TC-IDM-10.2/10.4/10.5 during Matter 1.4 SVE
Signed-off-by: Oliver Fan <nxf90549@lsvm07u0000059.swis.us-west-2.aws.nxp.com>
* Update RW/RT device types ZAP files to align with latest root node configuration updates done in thermostat zap configuration
Signed-off-by: Lo,Chin-Ran <chin-ran.lo@nxp.com>
* Update RT1060 RTOS laundry washer app to aligh with rw61x and rt1170 to pass TC-OPSTATE-2.6
Signed-off-by: Oliver Fan <nxf90549@lsvm07u0000059.swis.us-west-2.aws.nxp.com>
* Restyled by clang-format
* Restyled by gn
---------
Signed-off-by: Oliver Fan <nxf90549@lsvm07u0000059.swis.us-west-2.aws.nxp.com>
Signed-off-by: Lo,Chin-Ran <chin-ran.lo@nxp.com>
Co-authored-by: Chin-Ran Lo <nxf57500@lsv051039.swis.nl-cdc01.nxp.com>
Co-authored-by: Oliver Fan <nxf90549@lsvm07u0000059.swis.us-west-2.aws.nxp.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Decouple ember-specific functions from descriptor cluster (#36493)
* descriptor: decouple from ember
* Restyled by clang-format
* fix shadow error
* fix test build
* fix test build
* use Client cluster iteration
* Restyled by clang-format
* fix CI building error
* fix android build
* review changes
* Restyled by clang-format
* review changes
* some doc changes
* Fix the semantic tags iterator and add unit tests for the new functions
* Restyled by clang-format
* fix clang tidy check
* add composition test
* Restyled by clang-format
* Update src/app/data-model-provider/MetadataTypes.h
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Update src/app/codegen-data-model-provider/CodegenDataModelProvider.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
---------
Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Andrei Litvin <andy314@gmail.com>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Updating TC_CADMIN_1_9 test module due to issues noticed during step 4 (#36546)
* Updating TC_CADMIN_1_9 test module:
- Replacing wait with using 3 and 50 as error codes possible when attempting to commission on the 21st attempt!
* Restyled by autopep8
* Updating TC_CADMIN_1_9 test module:
- Attempting to resolve linting error for bare except
* Updating TC_CADMIN_1_9 test module:
- Attempting to resolve linting errors
* Updating CADMIN_1_9 test module:
- Replaced exception to using asserts.assert_in() function instead, much cleaner!
---------
Co-authored-by: Restyled.io <commits@restyled.io>
esp32: remove esp32_codegen.cmake and use common chip_data_model.cmake instead (#36674)
Bridge: Remove ACL client (#36677)
Fix JniReferences::GetOptionalValue (#36682)
* Fix JniReferences::GetOptionalValue
It's possible the optional is not of class java/util/Optional so just use the object provided
* fix formatting
Update host.py to fix water-leak-detector-app gen (#36683)
Formatting code extracts (#36670)
* Formatting code extracts
Formatting code extracts
* Update python.md
WARNING: Could not lex literal_block as "python"
Documentation: Fix incorrect paths in fuzz_testing.md and yaml.md (#36689)
* Documentation: Fix incorrect paths in fuzz_testing.md and yaml.md
* Update fuzz_testing.md
Stop shell read loop if the input stream was closed (#36675)
Ensure SYSTEM_STATS_INCREMENT only on successful Timer allocation in SystemTimer.h (#36690)
* Fix: Ensure SYSTEM_STATS_INCREMENT only on successful Timer allocation
* Update SystemTimer.h
Disable chef build of tempcontrol cabinet. (#36694)
Bridge app: remove binding client (#36697)
A binding client means that this device would be reaching out and
writing to the binding cluster on another endpoint, which is likely
NOT what was intended here since it doesn't do that.
The current app now shows no clusters listed in the client list
on any cluster (from device dump).
Some code updates on composition logic after #36493 (#36681)
* Remove some stutterning from endpoint composition (pattern repeated)
* Remove some explitic bits, add comments about what endpoint composition patterns are
* Restyle
* Restyled by clang-format
* Fix typo
---------
Co-authored-by: Restyled.io <commits@restyled.io>
[Fabric-Sync] Fix deadlock when removing device (#36706)
* [Fabric-Sync] Fix deadlock when removing device
* Add assertChipStackLockedByCurrentThread just in case
FanControl: modify percentSetting/percentSpeedSetting return value in case NULL is written (match spec) (#36242)
* Modified return value as per spec
* Modified return value for speedSetting attribute
* Updated test suite with return value.
Fix small typo in DataModelLogger-src.zapt (#36702)
* Fix small typo in DataModelLogger-src.zapt
* Update DataModelLogger.cpp
[Darwin] Framework diagnostics at startup (#36696)
* add script to make git commit SHA of build available to framework
via derived header
* trigger diagnostic log at framework init
* enumerate derived output file
Python testing: Update commissioning window API (#36669)
* Python testing: Update commissioning window API
- add some defaults to make this easier to use
- change the name to match the other methods in the class
* Fix API for new test
[Fabric-Sync]: Convert ember-driven functions to interface functions (#3…
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Feb 28, 2025
- adding additional 80 commits
- resolving conflict for merge with master due to modification of test_TC_CADMIN_1_5.yaml
Merging master into create_CADMIN_1_5_test PR branch:
- adding 709 commits
- Resolving conflict with merge due to modification of test_TC_CADMIN_1_5.yaml on master
[NXP][platform][common] Fix return status when removed a non-existing network ID (#36435)
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
chef: Fix FanControl mode/speed interdependence behavior (#36256)
* chef: Fix FanControl mode/speed interdepency behavior
This PR implements the FanControl logic to ensure the interdependent
behavior between Mode/Speed/Percent is coherent.
This is based on what was done in the AirPurifier examples.
Changes:
* Removed Custom Write/Read
* Updated Zap file `SpeedMax` default to 10 instead of 100
* Forward `MatterPostAttributeChangeCallback` FanControl-related changes
to `ChefFanControlManager`
* Implements Mode/Speed/Percent interdependency logic based on the
AirPurifier example
Test:
* Verified that Mode, Speed and SpeedPercent change accordingly when any
of those attributes change and cross a boundary.
* ifdef out code for non-fancontrol examples.
* Address Boris' review feedback
* Update examples/chef/common/chef-fan-control-manager.cpp
Co-authored-by: Andrei Litvin <andy314@gmail.com>
* Andrei's review suggestions
* review suggestions: clarify Auto behavior and use struct for ranges.
* Fix minor bug introduced when addressing review suggestions (!= vs ==)
* Update examples/chef/common/chef-fan-control-manager.cpp
Co-authored-by: Andrei Litvin <andy314@gmail.com>
* fix const
* Apply suggestions from Andrei's code review
Co-authored-by: Andrei Litvin <andy314@gmail.com>
* Restyled by clang-format
* Apply Boris' suggestions from code review
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Address Boris' review suggestions
---------
Co-authored-by: Andrei Litvin <andy314@gmail.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Revert "[SL-UP] Circular callback fix (#85) (#36406)" (#36475)
This reverts commit 078bc30d3f9f5d46c989272b2a50b3f5e8eb2f55.
Update camera zone cluster to latest spec docs (#36411)
* Generated using ./alchemy zap --attribute="in-progress" ... ZoneManagement.adoc
* Generated using ./scripts/tools/zap_regen_all.py
* Remove renamed file
* Restyled by whitespace
* Restyled by prettier-json
* Remove renamed file
* Remove choice for single element
---------
Co-authored-by: Restyled.io <commits@restyled.io>
[ICD] Shutdown icd client storage when destroying android controller (#36348)
* Shutdown DefautICDClientStorage when destorying Android controller
* Restyled by whitespace
* Update DefaultICDClientStorage.h
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
---------
Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
[pw_fuzzer] Add FuzzTests for PASE Message Receiving (#36445)
* Add FuzzTests for PASE Message Receiving
* Integrating Comments
* Removing two unused global string constants
* Integrating Comments
remove unused CHIP_CONFIG_MAX_BINDINGS (#36483)
Change output folder for apps (#35700)
* Change output folder for apps
* Update integrations/docker/images/chip-cert-bins/Dockerfile
* Update integrations/docker/images/chip-cert-bins/Dockerfile
[Silabs] Move Wi-Fi interface to src/platform from examples/platform (#36477)
* Restructure platform files
* Move all files to src/platform
* Build the wf200 in the new wifi structure
* rename directory
* Build the rs9116 in the new wifi structure
* Build the SiWx917 NCP in the new wifi structure
* Build the SiWx917 SoC in the new wifi structure
* Delete wfx_host_events header in favor of the new abstraction structure
* remove unnecessary includes in gn files and the cflag changes
* restyle
* add todo comment
* remove cflag inclusion
* add missing incllude
* Add missing includes
* Restyled by clang-format
* Move wifi_args.gni file to the wifi directory
* Rename Wf200WifiInterface to WifiInterface
* Rename SiWxWifiInterface to WifiInterface
* Rename Rsi91xWifiInterface.cpp to WifiInterface.cpp
---------
Co-authored-by: Restyled.io <commits@restyled.io>
[Darwin] API to list all network commissioning features supported by an MTRDevice (#36479)
* [Darwin] API to list all network commissioning features supported by an MTRDevice
- Expose the network commissioning feature bitset as API to know what
transports are supported by the device.
* Code review comments
* Code review comments
* Restyled by clang-format
---------
Co-authored-by: Restyled.io <commits@restyled.io>
Removal of 2 redundant attributes in CameraAVStreamMgmt cluster. (#36478)
SDK update for corresponding Spec change.
Remove the CurrentSnapshotConfig and CurrentVideoCodecs as they
are captured by the Allocated Video and Snapshot stream attributes.
Also, fix a field name in the Snapshotstream allocation command.
Run ZAP regen for the corresponding changes.
[Fabric-Sync] Port commissioner control protocol implementation (#36427)
* [Fabric-Sync] Port commissioner control protocol
* Add device synchronization
* Fix compile error
* Update examples/fabric-sync/admin/DeviceSubscription.cpp
Co-authored-by: Terence Hampson <thampson@google.com>
* Address review comments
* Add debug log
* Update examples/fabric-sync/admin/DeviceManager.cpp
Co-authored-by: Terence Hampson <thampson@google.com>
* Address review comments
* Add endpoint check
---------
Co-authored-by: Terence Hampson <thampson@google.com>
[nxp][examples][mcxw71_k32w1] Add platform/CHIPDeviceBuildConfig.h (#36482)
* [nxp][examples][mcxw71_k32w1] Include platform/CHIPDeviceConfig.h in FreeRtosHooks.cpp
* this will include the CHIP_DEVICE_CONFIG_ENABLE_OTA_REQUESTOR macro allowing OTAIdleActivities
to be called during ota.
* Switch FreeRtosHooks.c to FreeRtosHooks.cpp
* Add extern to functions
Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com>
* Restyled by whitespace
* Restyled by clang-format
* Restyled by gn
---------
Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Move ember-specific attribute persistence providers into `src/util/persistence` (#36473)
* Move persistence providers code into util since they depend on ember.
Unit tests pass, will need to fix up apps.
* Fix up more includes
* Restyled by clang-format
* Fix up qpg build
* Also fix nrfconnect deferred attribute persistence use
* Fix path
* Add persistence to esp32 CMakeLists.txt
* Update examples/lighting-app/qpg/BUILD.gn
---------
Co-authored-by: Andrei Litvin <andreilitvin@google.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Add timeout to excute a command (#36492)
[HVAC] Thermostat deadband handling (#35673)
* [HVAC] Shift heating and cooling setpoints to preserve deadband, when possible
* Minor function renames, fix incorrect setters
* Populate deadband on setpointLimits when Auto is supported
* [Thermostat] Add test for deadband handling
* Restyled Python test
* Fix int promotion errors on some platforms
* Remove unused Python imports
* Fix capitalization of structs, methods, fields, etc.
* Silly C++ int promotion rules
* [HVAC] Fix incorrect naming of TSTAT 2.3 test class
* Fix errant quote in TC_TSTAT_2_3.py
* Drop deadband fix test in favor of separate PR
* Apply suggestions from code review
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Don't use three-arg setter for attributes
* Rename deadband member
* Add backwards-compatibility comment for return code substitution
* Restyled
---------
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
[Fabric-Sync] Use Meyers' Singleton pattern for BridgedDeviceManager and DeviceManager (#36491)
[darwin] Update the NetworkFramework UDP implementation (#36418)
* [Network.framework] Add chip_system_config_use_network_framework
* [Network.framework] Update src/lib/core/CHIPConfig.h file to enable CHIP_CONFIG_IsPlatformPOSIXErrorNonCritical
* [Network.framework] Update src/system/SystemConfig.h file to enable CHIP_SYSTEM_CONFIG_USE_POSIX_SOCKETS
* [Network.Framework] Update src/inet/InetInterface* files with some additional #ifdef for the network framework
* [Network.Framework] Update src/inet/IPAddress* files with some additional #ifdef for the network framework
* [Network.framework] Update src/inet/InetInterfaceImplDefault.cpp to enable the default implementation
* [Network.framework] Update src/system to not use WakeEvent/Signal when using the network framework
* [Network.framework] Convert UDPEndPointImplNetworkFramework.cpp to .mm with arc support
* [chip-tool] Ensure each commissioner listen onto its own udc port since Network.framework won't allow SO_REUSEPORT
* [Matter.framework][darwin-framework-tool] Add chip_system_config_use_network_framework flag support
* Apply suggestions from code review
---------
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Move more of the MTRAttributeValueWaiter logic into the waiter. (#36416)
* Move more of the MTRAttributeValueWaiter logic into the waiter.
This logic should not live in MTRDevice.
* Address review comments.
Do not use reverse commissioning to pair test server (#36490)
[Fabric-Sync] Port sync-device command from fabric-admin (#36507)
fan_control_server: Fix circular callback issue (#36489)
* fan_control_server: Fix circular callback issue
This PR fixes a circular callback bug in fan control server using flags
when updating SpeedSetting and PercentSetting.
Before this change, a PercentSetting write to 25% would end up circling
back to 30% as shown:
```
[MatterTest] 11-12 19:16:40.792 INFO @@@ WRITE PercentSetting to 25
[MatterTest] 11-12 19:16:40.801 INFO @@@ ATTRIB: EP1/FanControl/SpeedSetting: 3
[MatterTest] 11-12 19:16:40.802 INFO @@@ ATTRIB: EP1/FanControl/SpeedCurrent: 3
[MatterTest] 11-12 19:16:40.802 INFO @@@ ATTRIB: EP1/FanControl/PercentSetting: 30
[MatterTest] 11-12 19:16:40.802 INFO @@@ ATTRIB: EP1/FanControl/PercentCurrent: 30
```
Now it behaves as expected:
```
[MatterTest] 11-13 18:54:27.961 INFO @@@ WRITE PercentSetting to 25
[MatterTest] 11-13 18:54:27.970 INFO @@@ ATTRIB: EP1/FanControl/SpeedSetting: 3
[MatterTest] 11-13 18:54:27.970 INFO @@@ ATTRIB: EP1/FanControl/SpeedCurrent: 3
[MatterTest] 11-13 18:54:27.970 INFO @@@ ATTRIB: EP1/FanControl/PercentSetting: 25
[MatterTest] 11-13 18:54:27.971 INFO @@@ ATTRIB: EP1/FanControl/PercentCurrent: 25
```
Co-authored-by: lpbeliveau-silabs <louis-philip.beliveau@silabs.com>
* Addressed review suggestions
---------
Co-authored-by: lpbeliveau-silabs <louis-philip.beliveau@silabs.com>
[Telink] fix stack sizes to avoid 90% usage (#36485)
* [Telink] Add temporarry THREAD_ANALYZER to check stack sizes during crash
* [Telink] fix configs
* [Telink] Increase OpenThread stack (98% usage during OTA)
* [Telink] Set INFO as default MCUboot log level
* [Telink] define CHIP_TASK_STACK_SIZE from one place
* [Telink] Add thread-analyzer as target build
* [Telink] decrise BOOT_MAX_IMG_SECTORS
* [Telink] temporary enable THREAD_ANALYZER by default
* [Telink] Increase stack sizes to avoid 90+% usage
* [Telink] increase more
* [Telink] set THREAD_ANALYZER=n by default
[NXP][platform][common] Remove unrequired config defines to use default values instead (#36497)
Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
[nxp][examples][rt1060] Update WiFi credentials setting in RT1060 readme (#36496)
Add missing #include for size_t (#36474)
[Chef] add Multi-sensor (#36469)
* Chef add multi sensor
* Fix compilation issues
* Remove Groups cluster,fix by TC_DeviceConformance.py
FIX TC_EEVSE_2_3 test fail when run in EST timezone (#36500)
* Ensure calculation of target_time_delta in compute_expected_target_time_as_epoch_s is done fully in UTC
* Restyled by autopep8
---------
Co-authored-by: Restyled.io <commits@restyled.io>
Improve detection of "historical" events in Matter.framework. (#36506)
We were marking events as "historical" if there were any attributes in the same
report that have the C quality. This had a few problems:
* Some devices randomly report C-quality attributes, for various reasons.
* Some attributes stop having the C quality in favor of Q, in some cases, so
this is not very forward-compatible.
The fix is to remove this C-quality check altogether. At that point we have the
following situations:
1. We're setting up a new subscription and getting our initial priming report.
This case will still have _receivingPrimingReport set, and will cause any
events reported as part of priming to be marked "historical".
2. We are getting a "priming" report from a server-side subscription resumption
after the server timed out on a subscription. If this happens before the
max-interval elapses, we will see this as a normal report on our
subscription, but with all attributes and events the server knows about
included. In this case, we mark ourselves as being in a "priming report" if
we get an event that has an event number we have already seen, so that we
mark any not-seen-before events in that report as "historical", since we
don't know how long ago they are from.
3. We are getting a normal incremental report, and will not mark any such events
as "historical".
Since we are now keeping track of last-received event numbers, we can also use
those for our subscriptions and can filter out any events that have an event
number no greater than our last-observed one.
Added the data_model_xmls.gni within matter testing infrastructure for data model python packaging (#36499)
* Added data models gni file and consumed it using via BUILD.gn
* Update build_python.sh with chip testing wheel modifications
* Restyled by gn
---------
Co-authored-by: Restyled.io <commits@restyled.io>
Fix crash in NamedPipeCommands.cpp caused by stack-buffer-underflow (#36465)
* Fix stack-buffer-underflow in NamedPipeCommands.cpp
* Update NamedPipeCommands.cpp
ESP32: Fix compile error for esp32h2 and add config for dynamic server (#36432)
* ESP32: Fix compile error for esp32h2 and add config for dynamic server
* add esp_wifi_lib if wifi enabled
[script] Add core.symlinks=true to submodules init (#36498)
On Windows, symlinks in submodules are detected as simple text files.
Adding this option to the git submodule command correctly detects the
symlinks.
Signed-off-by: marius-alex-tache <marius.tache@nxp.com>
[Darwin] add API to get public key without leaks (with fixes) (#36340)
* Initial checkin
* Fixing review feedback
* Adding braces
* Restyled by clang-format
* Fixing build
* Restyled by clang-format
* Fixing annotations
* Update src/darwin/Framework/CHIP/MTRKeypair.h
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* separate statements involving _mPublicKey to make compiler happy
* use `CFAutorelease` on CoreFoundation typed public key copies
* fix indent
* implement `copyPublicKey` for `MTRTestKeys`; add TODO note about optional method calls
* remove comment
it's a test; this is the best we can do with an optional protocol method
* consistent formatting for `copyPublicKey` calls
* reformat `copyPublicKey` in `MTRTestKeys`
remove comment - not this method's job to worry about other implementation's potential side-effects
* Update src/darwin/Framework/CHIP/MTRKeypair.h
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* re-add `publicKey` in `CHIPToolKeypair`
check compatibility in CI before going back and removing
* use `copyPublicKey` in more places
* dedupe public key cache population for CHIPToolKeypair
* Restyled by clang-format
* try manually releasing pubkey in test
* leakfix: MTRP256KeypairBridge
* leakfix: `MTRCertificateTests.testGenerateCSR`
* remove unnecessary plain `publicKey` implementation
* temporarily do the inelegant patch on CFAutorelease
* fix another remaining `publicKey` instance
* Restyled by clang-format
* fix `publicKey` deprecation, marking for future release
---------
Co-authored-by: Justin Wood <woody@apple.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
[nrfconnect] Fix all-clusters-app settings size (#36501)
After switching to building with sysbuild, the source of
the settings partition size has changed from the DTS to
the partition manager. Make sure the settings partition
is 32kB even when building all-clusters-apps without
DFU support.
Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
Darwin XPC: allow `NSDate` typed objects in `internalProperties` dictionary (#36514)
[Fabric-Sync] Fix failing to pair sync device (#36510)
* Fix failing to pair sync device
* Address review comments
* Address review commment
[Fabric-Admin] Set remote bridge after reverse pair the bridge device (#36451)
* [Fabric-Admin] Set remote bridge after reverse pair the bridge devide
* Add remote bridge to local bridge after pairing
* Set the reverse commissioning flag
* Do not add device as a bridged device after reverse pairing
* Fix compare error
* Address review comments
fan-control-server: Fix FanMode circular callback issue (#36515)
Similar to what was done for Speed and Percent, this PR fixes a bug where
a FanMode could result in a circular callback.
For example, setting the FanMode to kAuto, could trigger this issue.
chef-fan-control: Remove unnecessary circular callback checks (#36517)
* chef-fan-control: Remove unnecessary checks
With the recent circular callback bugfixes done in the cluster code in
pull/36515 and pull/36489, we can now safely remove unnecessary checks
that prevented the circular callbacks in the app side.
* remove unused includes/imports.
[Telink] Update Docker image (Zephyr update) (#36530)
* [Telink] Update Docker image (Zephyr update)
* [Telink] Update Docker image (Zephyr update)
Wrong title on the ST index (copy/paste error) (#36529)
Add a helper function for getting P256PublicKey from MTRKeypair. (#36520)
That way we are not ending up with multiple copies of finicky code.
Correct description of device controller callbacks (#36531)
Update Coding style documentation (#36275)
* Update coding style guide
- removed most of the motivation sections as it was somewhat
repetitive and made the doc quite verbose
- removed the drawing because it doesn't match the SDK implementation
in reality
- removed C discussion - I don't think we have any
- added python versions. Didn't add the other languages because I
dont' know but other folks can easily add a follow up
- added sections on
+ formatters
+ anonymous namespaces for internal stuff in cpp files
+ singletons
+ std containers to heap allocation sections
+ CopySpanToMutableSpan
+ std::optional
+ python section
- removed the code samples from heap allocation because it implies
that people show re-implement these things when the preference is
to use the provided support classes
- removed the version table - we have git history.
* Move coding style into main style dir
* Use md since that's why the doc wasn't included
* Restyled by prettier-markdown
* add new words to wordlist
* Add clarification about heap allocation
* Add clarification about code removal
* add isort ref to formatter table
* add ruff
* use links
* Apply suggestions from code review
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* address review comments
* Add link suffix toml to wordlist
---------
Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
[Fabric-Sync] Set remote bridge after reverse pair the bridge device (#36509)
* Set remote bridge after reverse pair the bridge device
* Address review comment
Update the readme of fabric-sync app based on the latest update (#36540)
* Update the readme of fabric-sync app based on the latest update
* Restyled by prettier-markdown
* Remove extra comma
---------
Co-authored-by: Restyled.io <commits@restyled.io>
[Telink] Add tl3218x board support & Update builds to docker version 92 (#36409)
* [Telink] Add TL3218X sceleton
* [Telink] Disable temporarry BLE
* [Telink] save ram by change config & revert add retention board
* riscv: telink:tl3218x: clean code and fix CI.
- fix CI error.
- clean code and improve settings.
- delete retention setting for TL321X.
Signed-off-by: Haiwen Xia <haiwen.xia@telink-semi.com>
* [Telink] Revert add retention board
---------
Signed-off-by: Haiwen Xia <haiwen.xia@telink-semi.com>
Co-authored-by: Alex Tsitsiura <s07641069@gmail.com>
* riscv: telink:tl3218x: add ble optimize.
- add optimize for ble.
- low down the ramcost.
- revert nvs cache to pass certify.
Signed-off-by: Haiwen Xia <haiwen.xia@telink-semi.com>
* [Telink] Add LZMA compression support for TL321x platform
Signed-off-by: Jinmiao Yu <jinmiao.yu@telink-semi.com>
* [Telink] Use LZMA by default for tl321x
* [Telink] CI build tests
* Restyled by clang-format
* [Telink] Update Config B9X_BLE_ to TL_BLE_
Signed-off-by: Damien Ji <yinghao.ji@telink-semi.com>
* [Telink] update zephyr revision for CI build tests
Signed-off-by: Damien Ji <yinghao.ji@telink-semi.com>
* [Telink] update zephyr revision for CI build tests
Signed-off-by: Damien Ji <yinghao.ji@telink-semi.com>
* [Telink] Cleanup overlays
* [Telink] update zephyr revision for CI build tests
Signed-off-by: Damien Ji <yinghao.ji@telink-semi.com>
* [Telink] Increase ISR and CHIP stack sizes to avoid 90%+ usage
* [Telink] Update builds to docker version 92
---------
Signed-off-by: Haiwen Xia <haiwen.xia@telink-semi.com>
Signed-off-by: Jinmiao Yu <jinmiao.yu@telink-semi.com>
Signed-off-by: Damien Ji <yinghao.ji@telink-semi.com>
Co-authored-by: haiwentelink <125550736+haiwentelink@users.noreply.github.com>
Co-authored-by: Haiwen Xia <haiwen.xia@telink-semi.com>
Co-authored-by: Jinmiao Yu <jinmiao.yu@telink-semi.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Damien Ji <yinghao.ji@telink-semi.com>
[nxp][examples][contact-sensor][zap] Update zap files (#36513)
* [nxp][examples][contact-sensor][zap] Update zap files
* Update cluster version
* Update AccessControl feature map
* Add OTA Requestor device type to EP0
* [nxp][examples][contact-sensor][zap] Disable Extension ACL attribute
Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com>
---------
Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com>
Add unit test for deleting CommandSender when response is pending (#36536)
TC-IDM-4.2: Remove yaml, now has a python impl (#36518)
Handle ACL and readability in `reporting/Engine.cpp` (#36488)
* Move ACL validation in reporting engine for reads
* Fix up logic for ACL & return codes
* Take into consideration global attributes: their ACL is ok
* Make testread pass (with hacks because the test is not sane)
* Update comment and model setting.
* Another comment update
* Fix includes
* Fix typo
* Restyled by clang-format
* Update comment
* Update ACL test logic and revert testread to original setup
* Restyle
* Address review comments
* Restyle
* Update src/app/reporting/Engine.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Update src/app/reporting/Engine.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Update src/app/reporting/Engine.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Update src/app/reporting/Engine.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Update src/app/reporting/Engine.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Restyle
* Fix extra bracket
---------
Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Co-authored-by: Andrei Litvin <andreilitvin@google.com>
[Telink] Update Docker image (Zephyr update) (#36563)
[nxp][platform][k32w0] Remove KVS logs for init phase (#36553)
* [nxp][platform][k32w0] Remove KVS logs for init phase
Signed-off-by: marius-alex-tache <marius.tache@nxp.com>
* Restyled by whitespace
---------
Signed-off-by: marius-alex-tache <marius.tache@nxp.com>
Co-authored-by: Restyled.io <commits@restyled.io>
setup: support installations with Python3.13 (#36549)
[NXP][third_party] Fixed memory leak in BR mDNS code (#36543)
* [NXP][third_party] Fixed memory leak in BR mDNS code
This commit fixes potential memory leaks that could happen
if multiple resolve of browse operations are done without
calling the appropriate stop function to clean up the
allocated resources. If using the Matter CLI this issue
is not possible as the CLI always stops the previous
operation but other processes calling the resolve/browse
API might not follow this flow.
Also fixed the return value of the StopBrowse function.
Signed-off-by: Marius Preda <marius.preda@nxp.com>
* Restyled by clang-format
---------
Signed-off-by: Marius Preda <marius.preda@nxp.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Delete user and group in case of conflicts (#36528)
[Fabric-Sync] Implement pair-device command (#36508)
* [Fabric-Sync] Port pair-device command from fabric-admin
* Update examples/fabric-sync/shell/ShellCommands.cpp
Co-authored-by: Terence Hampson <thampson@google.com>
---------
Co-authored-by: Terence Hampson <thampson@google.com>
Fix cluster Bridged Device Basic Information in matter-devices.xml (#36467)
Fixes Carbon Monoxide Concentration Measurement in matter-devices.xml (#36466)
Fixes Carbon Monoxide Concentration Measurement in matter-devices.xml
[Silabs] Replace rvc by dishwasher in SL example (#36367)
* Replace rvc by dishwasher
Replace rvc by dishwasher
* Restyle
[ameba] Ameba SNTP and observer support (#36382)
* [ameba] Support Time Syncronization Using SNTP
* [ameba] Synchronize RTC with SNTP
* [ameba] Add CONFIG_ENABLE_AMEBA_SNTP to config/ameba/chip.cmake and run restyle-diff.sh
* [ameba] Add Ameba Observer for Ameba Examples
* [Ameba] Fix build with all-clusters-minimal-app and SystemTimeSupport.cpp
* [Ameba] Update Docker Version to 91
* [Ameba] moved AmebaObserver.h to examples/platform/ameba/observer/ and updated Ameba cmake
* [Ameba] simplified #if defined(CONFIG_ENABLE_AMEBA_SNTP) && (CONFIG_ENABLE_AMEBA_SNTP == 1) to #if CONFIG_ENABLE_AMEBA_SNTP
---------
Co-authored-by: Andrei Litvin <andy314@gmail.com>
Add APIs to access default SessionKeystore & PersistentStorageDelegate (#36566)
* Add APIs to access default SessionKeystore & PersistentStorageDelegate
* Restyled by whitespace
---------
Co-authored-by: Restyled.io <commits@restyled.io>
[Fabric-Sync] Support icd-registration during device sync (#36569)
[Telink] Improve B92 retention target & Update builds to docker version 93 (#36552)
* riscv:b92: fix ble thread overflow.
- cut down the ramcost for b92 retention mode.
- move the .ramcode to retention .
Signed-off-by: Haiwen Xia <haiwen.xia@telink-semi.com>
* Restyled by whitespace
* Restyled by clang-format
* [Telink] Update hash of latest Zephyr to check builds
* [Telink] Update builds to docker version 93
* riscv:b92: clean code and adjust config.
- change the kconfig.default value .
- merge the same setting for save ram.
Signed-off-by: Haiwen Xia <haiwen.xia@telink-semi.com>
* [Telink] Update builds to docker version 93
---------
Signed-off-by: Haiwen Xia <haiwen.xia@telink-semi.com>
Co-authored-by: Haiwen Xia <haiwen.xia@telink-semi.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Have `DataModel::Provider` be an argument to Server Init parameters (#36558)
* Set a provider in server init
* Restyle
* Fix some include dependencies
* Add back missing include
* Undo change for nrf
* Add import for android
* Undo qpg change
* Update examples/all-clusters-app/nrfconnect/main/AppTask.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Update examples/light-switch-app/qpg/src/AppTask.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Update examples/lock-app/nrfconnect/main/AppTask.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Update examples/lit-icd-app/nrfconnect/main/AppTask.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Update src/controller/python/chip/server/ServerInit.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Help users update
* Added comment
* Restyled by prettier-markdown
* Update examples/lock-app/qpg/src/AppTask.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Update examples/platform/infineon/cyw30739/matter_config.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Update examples/platform/telink/common/src/AppTaskCommon.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Update examples/pump-app/nrfconnect/main/AppTask.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Update examples/platform/openiotsdk/app/openiotsdk_platform.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Fix includes
* Removed an include
* Update examples/pump-controller-app/nrfconnect/main/AppTask.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Update examples/shell/shell_common/cmd_server.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Update examples/window-app/nrfconnect/main/AppTask.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Remove extra include
* More comments updated
* Remove unneeded dependency
* Fix log
* Update src/app/server/Server.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Remove double init
---------
Co-authored-by: Andrei Litvin <andreilitvin@google.com>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Co-authored-by: Restyled.io <commits@restyled.io>
TC_WHM_2_1: Fix incorrect --aplication argument (#36578)
It should be `water-heater` instead of `evse`.
use VerifyOrDie instead of assert() (#36583)
Improve logging in setPersistedClusterData. (#36581)
Before this change we would log setPersistedClusterData claiming we don't know
our VID/PID/etc, though chances are the data being passed in exactly contains
that information.
In the new setup, we update our state, then log.
If an XPC client doesn't care about a nodeID (hasn't made it), don't create one (#36586)
* Fixing infinite loop
* Restyled by clang-format
---------
Co-authored-by: Restyled.io <commits@restyled.io>
ESP32: fix typo to include correct Span.h in secure cert data provider (#36589)
* ESP32: fix typo to include correct Span.h in secure cert data provider
* restyle
[Linux] Fix crash when shutting down BLE Manager after platform shutdown (#36550)
[Linux] Reuse short UUID defined in BLE layer (#36557)
* [Linux] Reuse short UUID defined in BLE layer
* Restyled by clang-format
---------
Co-authored-by: Restyled.io <commits@restyled.io>
Add pigweed.json to root and opt out to cli analytics (#36598)
Better logging when Darwin.framework is asked to encode an incorrect type in a list. (#36599)
[Silabs] Adds changes for min and max values of refrigerator temperature controlled cabinet (#36592)
* Adds changes for min and max values of refrigerator temperature control cabinet
* Removed the manual set for temperatureset-point
* Converting Fahrenheit to Celsius min max values
[Darwin][Ble] Keep scanning while connecting to a device until didConnectPeripheral fires (#36595)
Use _deviceForNodeID:createIfNeeded: in more places. (#36602)
We had some manual lock-and-get code that can go away now.
ESP32: Fix building chip_gn for cmake v3.31.x and onwards (#36606)
remove the WORKING_DIRECTORY from chip_gn target
For cmake v3.31.x, custom command generated for chip_gn-build in
build.ninja concats the $WORKING_DIRECTORY and $BUILD_DIR paths and
it mess up the chip_gn step when building example.
COMMAND = cd "/Users/account/esp-matter/connectedhomeip/connectedhomeip/config/esp32/components/chip;/Users/account/esp-matter/examples/light/build/esp-idf/chip" && ninja esp32
For cmake version prior to v3.31, it do not prepend the
$WORKING_DIRECTORY path.
COMMAND = cd /Users/account/esp-matter/examples/light/build/esp-idf/chip && ninja esp32
This could be becuase of https://github.com/Kitware/CMake/commit/f5f80305ef69dd33fbedd31ef1d2cfd3d2bc15b4
related issue - https://github.com/espressif/esp-matter/issues/1157
Add SWVersion in OTAFragment (#36590)
[nxp][platform][mcxw71_k32w1] Relocate key storage default option to example apps args definition files (#36577)
The GN args file for the MCXW71/K32W1 platforms defines a default
for the "nxp_nvm_component" option which prevents the users from
selecting a different option in the command line. The default value
for this build option is already defined by the
third_party/nxp/nxp_matter_support/gn_build/nxp_sdk.gni
GN arguments file. If one would want to override the default, this
has to be done in the scope of the application so that the user can
also override the build option from the command line.
Signed-off-by: Marian Chereji <marian.chereji@nxp.com>
energy-management-app: Add boost state in WaterHeater README (#36338)
* Add boost state in WaterHeater README
* Format
Implement Operational State Cluster PhaseList attribute (#36350)
* Update chef-operational-state-delegate-impl.h
opPhase
* Update chef-operational-state-delegate-impl.h
Implement mOperationalPhaseList
* Restyle
* Update chef-operational-state-delegate-impl.h
Use CharSpan
* Update chef-operational-state-delegate-impl.h
* Clean
[ESP32]: fix compile error for c6 bt lib path (#36332)
* esp32: fix compile error for c6 bt lib path
* Add warning message if no libble_app.a is found.
[Fabric-Sync] Cleanup pass through APIs (#36604)
[Crypto] replacing OpenSSL-specific flag by new public API (#36608)
This is a follow_up to #36386 based on a post-merge comment,
- an OpenSSL-specific mInitialized flag was added to HASH_SHA256 to check if digest computation was initialised, which isn't used for other Crypto Backends
- Fix: replace by a Public API `IsInitialized`, with its implementation for OpenSSL/BoringSSL
Add AsyncFacilitator to enable an async, event-driven, non-polling me… (#29364)
* Add an AsyncTransferFacilitator that supports BDX transfer using an event driven approach rather than polling
- Update the OTA provider darwin implementation to use the AsyncTransferFacilitator to transfer the OTA file using BDX
* Editorial fixes
* Restyled by whitespace
* Restyled by clang-format
* Apply suggestions from code review
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Addresssed review comments
* Restyle
* Apply suggestions from code review
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Address review comments
* More fixes
* Restyle
* Apply suggestions from code review
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Apply suggestions from code review
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Address more review comments
* Apply suggestions from code review
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Address review comments
* Apply suggestions from code review
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Fix restyled issues.
* Add missing header
* Address review comments.
---------
Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Incremental improvements to controller dependencies (#36567)
* Remove unused reference to CHIP_CONFIG_ENABLE_READ_CLIENT
* ExamplePersistentStorage does not need CHIPDeviceController
* Tidy up some Linux app-main dependencies
* Reduce dependency of data model on controller
* Fix log placerholders to use ChipLogFormatX64 in fabric sync example
[Fabric-Admin] Clean up pass through functions from Device Manager (#36614)
* [Fabric-Admin] Clean up pass through functions from Device Manager
* Restyled by clang-format
---------
Co-authored-by: Restyled.io <commits@restyled.io>
Set `dataModelProvider` as a required argument for `Controller::FactoryInitParams` (#36613)
* Add dataModelProvider to Factor init parameters for the codegen data model provider
* make setting the same data model on interaction model provider a noop
* Fix compile
* Fix links
* Restyle
* Restyled by prettier-markdown
* Fix text
* Fix some deps
* Restyled by gn
* Remove dependencies/auto-init of codegen data model in the interaction model. We now fully expect all applications to provide a data model provider
* Fix include
* Update src/app/InteractionModelEngine.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Address some code review comments
* Fix unit tests
* Restyle
* Add more comments about why we have very intentional ordering
---------
Co-authored-by: Andrei Litvin <andreilitvin@google.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Mark _deviceForNodeID:createIfNeeded: as possibly returning nil. (#36617)
Add some constraint checks to the colorcontrol cluster commands (#36542)
* add some constraint checks to the colorcontrol cluster commands
* Update src/app/clusters/color-control-server/color-control-server.cpp
Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com>
* Addrese comments. Move ConstraintCheck Before Unsupported command checks. Add contraint checks for ColorTemperatureMireds arguments
* Update src/app/clusters/color-control-server/color-control-server.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
---------
Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Make Hash_SHA256_stream::IsInitialized() protected (#36633)
[NXP] Update Thermostat ZAP files to fix IDM errors (#36612)
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
BDX transfer support for Python tests (#34821)
* Add the python-C++ translation.
* Add a BDX transfer server to handle unsolicited BDX init messages.
* Add the manager to implement the transfer pool.
* Add the initial implementation of a BDX transfer.
* Use BdxTransfer in the other classes.
* Update constructors to set the delegates etc. correctly.
* Implement the C++ side of the barrier. Move the data callback into the transfer delegate.
* Add a way to map the transfer to the python contexts.
* Fix some of the minor TODOs.
* Add init/shutdown to the transfer server.
* Start on the implementation of the Python side.
Also add the transfer obtained context to the C++ methods relating to expecting transfers.
* Listen for all BDX protocol messages rather than just the init messages.
* Fix minor issues in the transfer server.
* Implement a good chunk of the python side.
* Fix compile errors.
* Fix a number of issues preventing the BDX python code from running at all.
* Return the results of the python-C methods.
* Fix the async-ness of the methods that prepare the system to receive a BDX transfer.
Also run the python BDX initialisation.
* Initialise the BDX transfer server.
Also ignore the BDX transfer server implementation that only handles diagnostic logs.
* Fixes necessary to await on the future from PrepareToReceive/SendBdxData.
* Call Responder::PrepareForTransfer from BdxTransfer.
* Correctly schedule satisfying the future on the event loop.
* Use the real property to determine if a PyChipError was a success.
* Fix sending the accept message.
* Acknowledge received blocks so the BDX transfer continues.
Also don't ignore all messages after the init.
* Fix the parameters of the python callback methods.
* Add another async transaction class to handle the transfer completed callback.
* Add comments to the C++ code.
* Add a test for the BDX transfer that uses the diagnostic logs cluster.
* Move the calls to release a transfer out of the manager so it works the way one would expect.
* Delay releasing the C++ BDX transfer object until after it's no longer in use.
* Verify the diagnostic logs response is a success.
* Restyled by whitespace
* Restyled by clang-format
* Restyled by gn
* Restyled by autopep8
* Restyled by isort
* Improve BdxTransferManager's comments.
* Use a vector for the data to send over a BDX transfer rather than a raw pointer.
* Minor renames.
* Improve the error message when the BDX transfer pool is exhausted.
* Minor fixes.
* remove a check that was inadvertently kept.
* print a log message when something that shouldn't happen inevitably does.
* use user_params to get the end user support log test parameter.
* Pass the status report's status code up the stack.
* Merge the BDX transfer server into the manager.
* Rename BdxTransferManager to TestBdxTransferServer.
* Minor cleanup.
* Rename TransferData to TransferInfo.
* Change `!=` to `is not` in python.
* Add missing type annotation.
* Improve the documentation of the ownership in the C++ side.
* Restyled by clang-format
* Restyled by autopep8
* Update the new test to work with the new formatting.
Also remove an unnecessary conversion to bytearray.
* Lint fixes.
* Fix clang-tidy errors.
* Several fixes suggested by Andrei.
* Fix a name in a comment.
* Fix issues preventing test from working.
Also:
* Split the accept function into one for sending data and one for receiving data.
* Return bytes instead of a bytearray when receiving data.
* Add typing to the data callback.
* Rename the methods that accept transfers so it's clear which way the data is flowing.
* Add doc comments to the Python classes and methods.
* Fix issues found by mypy.
* Restyled by clang-format
* Restyled by autopep8
* Fix python lint error.
* Explicitly truncate the status code when generating the error.
* Generate the diagnostic log to transfer in the test.
---------
Co-authored-by: Restyled.io <commits@restyled.io>
[Fabric-Sync] Fix segment fault during fabric admin initialization (#36635)
[Implementation] Adding get_endpoint functionality to matter_testing support module (#36568)
* Incorporating new get_endpoint functionality in matter_testing support module:
- Added prior previous get_endpoint functionality from Cecille back to matter_testing support module.
- Updating test modules to use new get_endpoint functionality mentioned in issue: https://github.com/project-chip/matter-test-scripts/issues/416
* Restyled by autopep8
* Updated TC_OCC_3_2 to resolve linting errors
---------
Co-authored-by: Restyled.io <commits@restyled.io>
TC-OPCREDS-3.4: Automate (#33541)
* chore(TC_OPCREDS_3.4): skeleton class
* chore(TC_OPCREDS_3.4): implementation until step CSRRequest IsForUpdatedNOC=True
* chore(TC_OPCREDS_3.4): All test step are implement using the old way to printed them
* chore(TC_OPCREDS_3.4): patch from restyled code
* chore(TC_OPCREDS_3.4): restyled by autopep8
* chore(TC_OPCREDS_3.4): fix code-lints
* chore(TC_OPCREDS_3.4): add suggestions
* chore(TC_OPCREDS_3.4): steps _method instead print each step and add suggestions
* chore(TC_OPCREDS_3.4): fix restyled
* chore(TC_OPCREDS_3.4): fix re-implementation validate single entry certs
* chore(TC_OPCREDS_3.4): fix resyled
* chore(TC_OPCREDS_3.4): reverting commissioningBuilingBlocks without icac and nocBytes
* chore(TC_OPCREDS_3.4): fix matter_testing_support ModuleNotError
* chore(TC_OPCREDS_3.4): added and replaced some outcomes/methods for TestSteps
* chore(TC_OPCREDS_3.4): fix restyled
* chore(TC_OPCREDS_3.4): fix restyled
* chore(TC_OPCREDS_3.4): added suggestions
* chore(TC_OPCREDS_3.4): added expected outcomes for some test step
* chore(TC_OPCREDS_3.4): fix restyled
* chore(TC_OPCREDS_3.4): fix f-strings without any placeholder
* chore(TC_OPCREDS_3.4): implemented all expected outcomes for all steps
* chore(TC_OPCREDS_3.4): fix restyled
* Update src/python_testing/TC_OPCREDS_3_4.py
Needs the PICS function
Co-authored-by: C Freeman <cecille@google.com>
---------
Co-authored-by: C Freeman <cecille@google.com>
[Test] Creating TC_CADMIN_1_22 and TC_CADMIN_1_24 python test modules (#35632)
* [Test] Creating TC_CADMIN_1_22 and TC_CADMIN_1_24:
- Created CADMIN_1_22 python test module following steps in PR here:
- Created CADMIN_1_24 python test module following steps in PR here:
- Removed following yaml test modules:
-- Test_TC_CADMIN_1_21.yaml, Test_TC_CADMIN_1_22.yaml, Test_TC_CADMIN_1_23.yaml, Test_TC_CADMIN_1_24.yaml
* Restyled by autopep8
* Updating TC_CADMIN_1_22 and TC_CADMIN_1_24:
- Resolved linting issues
* Created TC_CADMIN_1_22_24 test module:
- Merged TC_CADMIN_1_24 and TC_CADMIN_1_22 standalone test modules into a single test module
- Found enum for window closed value and replaced it in the tests
- Removed generate_unique_value and AttemptCommission functions
- Updated CI arguments format to YAML'esque format
* Restyled by autopep8
* Updated TC_CADMIN_1_22_24:
- Renamed class to TC_CADMIN_1_22_24
* Updating TC_CADMIN_1_22_24:
- Resolving lint errors
* Update TC_CADMIN_1_22_24.py
Updated to include dependency location change for matter_testing support module
* Updated TC_CADMIN_1_22_24.py:
- Resolved issues with CI args in TC_CADMIN_1_22_24 test module
- Removed yaml calls for 1_21, 1_22, 1_23, and 1_24, also removed yaml call for 1_9 from manualTests.json
* Updating TC_CADMIN_1_22_24 test module:
- Resolving comments from tehampson as these were needed changes to be made
-- Substituted to using cleaner code for assert.asserts_equal instead of just assert.failure
-- Resolving copy paste error in TC_CADMIN_1_4 test
-- Made comments cleaner by rewording to include what the error code was referring too
* Update TC_CADMIN_1_22_24 test module:
- Changing method for test step 3 on TC_CADMIN_1_24 test now using timeout for 30 seconds instead of revoke commissioning
* Restyled by autopep8
* Update TC_CADMIN_1_22_24.py
- Unnesting asserts from if statements
* Update src/python_testing/TC_CADMIN_1_22_24.py
- Adding this suggested change from Terrence into the code, as it does make the code much cleaner
Co-authored-by: Terence Hampson <thampson@google.com>
* Update TC_CADMIN_1_22_24.py
-Updating to changing static value to being stored in variable for easier readability as Terrence has suggested, making the code easier to read.
* Restyled by autopep8
* Updated TC_CADMIN_1_22_24 test module:
- Removed unneccessary await from asserts
* Restyled by autopep8
---------
Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Terence Hampson <thampson@google.com>
[Test] Creating CADMIN 1.19 python3 test module (#35611)
* [Test] Creating CADMIN 1.19 test module:
- Test module created following steps in PR: https://github.com/CHIP-Specifications/chip-test-plans/pull/4669
* Restyled by autopep8
* Update TC_CADMIN_1_19 test module:
- Resolving linting issues
* Removing yaml test module for TC_CADMIN_1_19:
- Removed yaml test as we have created python test module in its place
* Update TC_CADMIN_1_19.py
- Removed debugging print statements as no longer needed in test code
* Update src/python_testing/TC_CADMIN_1_19.py
Co-authored-by: C Freeman <cecille@google.com>
* Update src/python_testing/TC_CADMIN_1_19.py
Co-authored-by: C Freeman <cecille@google.com>
* Updating TC_CADMIN_1_19 and matter_testing scripts:
- Updated CI Arguments
- Updated dependency location for matter_testing_support
- Removed local OpenCommissioningWindow function, updated to using MatterBaseTest version
- Removed local CommissioningAttempt function, moved to using function call directly in test
- Removed initialization of TH2 controller as not needed
- Removed additional dictionary names and delimited it down to just using numbers instead.
- Updated matter_testing support script to include setting timeout value dynamically in openCommissioningWindow function
* Restyled by autopep8
* Update TC_CADMIN_1_19.py
Resolving Linting errors
* Update TC_CADMIN_1_19.py
- Moved location of print_step to top of for range for creating virtual fragments
- Removed unnecessary print_step for catching error
* Updated TC_CADMIN_1_19 test module:
- Created new variable for current_fabric + 1
- Replaced if statements with asserts.assert_equal()
- Changed start of range from 1 to 0
- Changed test steps to match test plan better, removed test step 1
* Restyled by autopep8
* Updated TC_CADMIN_1_19 test module:
- Added new criteria to test step 3 where max_fabrics is checked to make sure it is greater than initial_fabrics count
* Updated TC_CADMIN_1_19 test module:
- Removed print statement from debugging session
* Restyled by autopep8
---------
Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: C Freeman <cecille@google.com>
[Silabs] Add Trigger events from Matter CLI to README (#36570)
* Add refrigeratoralarm event to README.md
Add refrigeratoralarm event
* Update README.md
* Update README.md
Trigger events from Matter CLI
* restyled
* Update .wordlist.txt to add refrigeratoralarm
* Update Refrigerator README.md
[NXP] Add EL2GO factory data impl, change default rw61x factory data impl (#36615)
* [NXP][platform] Add EL2GO factory data implementation, update default factory data implmentation to use secure element
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
* [NXP][exmples] Add EL2GO factory data implementation, update default factory data implmentation to use secure element
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
* [NXP][script] Add EL2GO factory data implementation
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
* [NXP][doc] Add EL2GO factory data implementation, update default factory data implmentation to use secure element
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
* Restyled by whitespace
* Restyled by clang-format
* Restyled by gn
* Restyled by prettier-markdown
* Restyled by autopep8
* Restyled by isort
* [NXP] fix spelling
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
* [NXP][submodule] Update NXP matter support submodule
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
* [NXP] Add factory data secure key storage compatiblity with actual factory data
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
---------
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Make IsInitialized implementation in OpenSSL backward compatible with older OpenSSL versions (#36634)
Add some additional `dataModelProvider` settings on server init (#36639)
* Add some missed registrations of dataModelProvider in server init
* Fix commissioner main dependencies (make nrf tests compile)
* Move around dependencies - apparently the commissioner main should be public
* Fix one more odd dependency
Resolve CommissionerMain dependency issues (#36632)
* Resolve CommissionerMain dependency issues
Note that CHIP_DEVICE_CONFIG_ENABLE_BOTH_COMMISSIONER_AND_COMMISSIONEE=1
requires chip_build_controller=true at the GN level, otherwise `lib` does
not pull in `controller`.
* Touch something in /tests/ to force NRF native_posix_64 tests to run
* Add nogncheck to conditional controller imports
dac_revocation: Perform cross validation against crl signer or crl signer delegator (#35144)
* dac_revocation: Support crl signer and crl signer delegator
- Add crl signer and crl signer delegator cert in the python script
which generates the revocation set
- perform the cross validation of DAC/PAI with crl signer and crl signer
delegator cert
- Extended and added unit tests for crl signer delegator case
* include algoright and remove the local var declaration
* use unused attribute
* Fix the buffer overrun and use maybe_unused instead of unused attribute
* we do not need to differentiate pai/dac when cross verifying
* add checks on return value and unit tests on malformed crl signer cert
* use std::string instead of const char *
* address some more reviews
* Update src/credentials/attestation_verifier/TestDACRevocationDelegateImpl.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
---------
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
removed unnecessary include (#36646)
[Silabs] Adds fix for support default value in refrigerator alarm cluster Refrigerator application (#36651)
* Adds changes for supported value
* Adds changes for the supported value
[Silabs] PSA Crypto PAL customized for EFR32. (#36575)
* [Silabs] PSA Crypto PAL customized for EFR32.
Adds SubscriptionInfoProvider API to check if a given fabric has at least 1 subscription (#36627)
* [SL-UP] Add fabric subscription check to the interaction model engine (#117)
* Remove unwanted change
* Restyle
* Improve readability
* Restyled by clang-format
* Update src/app/SubscriptionsInfoProvider.h
Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com>
---------
Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com>
[Silabs] Adds refrigerator app matter shell support for change door state (#36548)
* Added changes for the matter shell
* Added support for the matter shell refrigerator door state
* Added changes for the failure
* Adds required comment changes
* Added restyler changes
* Adds changes according to comment
[Fabric-Sync] Fix segment fault during fabric device sync (#36656)
energy-management-app: refactor WH and EVSE into separate endpoints and fix conformance issues (#36201)
* Add missing Water Heater device to matter-devices.xml
This PR adds the missing Water Heater device to matter-devices.xml.
The description was generated using the Alchemy tool
(https://github.com/project-chip/alchemy) with the following command:
`alchemy zap --attribute="in-progress" --sdkRoot=./connectedhomeip/
--specRoot=./connectedhomeip-spec/
./connectedhomeip-spec/src/device_types/WaterHeater.adoc`
I manually fixed the device nae from `Matter Water Heater` to `Water
Heater`.
* zap regen
* energy-management-app: Split WH and EVSE into 2 endpoints
This PR refactors the energy-management-app into 2 separate endpoints
(one for EVSE and another for WaterHeater).
This is the first step in making this app spec-conformant.
`TC_DeviceBasicComposition.py` failed on this app before this PR and now passes.
Changes:
* Split Water Heater and EVSE into two separate endpoints (1 and 2).
Updated zap and code.
* Dinamically disable unused endpoint at runtime. Based on the app choice
(command line argument on linux or #define in ESP32 or SIlabs), initialize
the clusters in the correct endpoint and disable the other endpoint.
For example, for Water Heater, initialize clusters on endpoint 2 and
disable endpoint 1 (EVSE).
* Refactor/move the init code related to ElectricalSensor (PowerTopology, EPM and EEM) from inside EVSE
into ElectricalSensorInit.h/.cpp so they can be easier to reuse by both WaterHeater and EVSE.
* Refactor/move DEM cluster init code into its own file so it can be
better reused outside EVSE.
Test performed:
1. Check basic composition for EVSE:
```
scripts/run_in_python_env.sh out/python_env './scripts/tests/run_python_test.py --app ./out/linux-x64-energy-management-no-ble/chip-energy-management-app --app-args "--application evse --trace-to json:log" --script src/python_testing/TC_DeviceBasicComposition.py --script-args "--qr-code MT:-24J0AFN00KA0648G00"'
```
2. Check basic composition for WaterHeater:
```
scripts/run_in_python_env.sh out/python_env './scripts/tests/run_python_test.py --app ./out/linux-x64-energy-management-no-ble/chip-energy-management-app --app-args "--application water-heater --trace-to json:log" --script src/python_testing/TC_DeviceBasicComposition.py --script-args "--qr-code MT:-24J0AFN00KA0648G00"'
```
3. Check app against `TC_EEVSE_2_6.py`:
```
rm -f evse.bin; ./out/linux-x64-energy-management-no-ble/chip-energy-management-app --enable-key 000102030405060708090a0b0c0d0e0f --KVS evse.bin --featureSet 0x3d
python src/python_testing/TC_EEVSE_2_6.py --endpoint 1 -m on-network -n 1234 -p 20202021 -d 3840 --hex-arg enableKey:000102030405060708090a0b0c0d0e0f
```
* Use anon namespace instead of static.
* disable enpoint on esp32 and silabs
* address Tennessee's PR feedback
* Review suggestion: move GetMainAppEndpointId to another file
* zap regen
* fix matter-devices white space diffs
* App now builds on all-clusters app
* Fix typo on init
* fix all-clusters breakage on esp32
* fix misuse of namespace in header
* Fix breakage for silabs water heater
* Update WaterHeater endpoint for CI tests
This fixes REPL test CI breakage.
* Update WaterHeater tests to endpoint 2
* Bumped ClusterRevisions
Cluster 40 (0x28) BasicInformation - 3 -> 4
Cluster 47 (0x2f) PowerSource - 2 -> 3
Cluster 48 (0x30) GeneralCommissioning 1-> 2
Cluster 3 (0x03) Identify 4 -> 5
Cluster 153 (0x99) EnergyEvse 2 -> 3
Cluster 157 (0x9d) EnergyEvseMode 1-> 2
Cluster 159 (0x9f) DeviceEnergyManagementMode 1-> 2
* Update AccessControl featureMap to enable Extension attribute
* Remove AccessControl extension attribute
* Remove kStateForecastReporting from the default feature map
That feature can't be enabled together with kPowerAdjustment.
* Update TC_WHM_1_2 endpoint to 2
* Fix various conformance issues
Remove PowerSource from root node and move to EP1/evse
Bump cluster revisions where needed
Fix device type descriptions for each EP
Remove unused Thermostat cluster and added a TODO. We need to properly
implement this cluster for this app for temperature control.
* TC_WHM_1_2: Use endpoint id passed as argument instead of hardcoded
[Silabs] General updates and fixes for the Silabs Wi-Fi platforms (#36628)
* [SL-UP] Remove two algo design for the wifi retry mechanism (#103)
* [SL-UP] Rename ot interval to transport interval (#108)
* [SL-UP] Delete unnecessary double abstraction for the wiseconnect power save functions (#109)
* [SL-UP] Update spi-multiplex header inclusion (#110)
* [SL-UP] Fix Builds after Wi-Fi interface refactor (#111)
* [SL-UP] Remove WF200 define duplication to avoid value conflicts at runtime (#126)
* fix spacing
* restyle
* Fix define name
* add missing function
* Fix wf200 ICD build
* Restyled by clang-format
* Add debug config
* Re added sem check
---------
Co-authored-by: Restyled.io <commits@restyled.io>
[Silabs] Move Wi-Fi interface files to the final structure (#36644)
* Move files
* Move wifi files to their final location & cleanup
* Restyled by clang-format
* rename directories
* rename paths for new locations
* Restyled by clang-format
* update include path with the structure
---------
Co-authored-by: Restyled.io <commits@restyled.io>
Deliver SIGINT to the shell thread to interrupt read() (#36533)
* Deliver SIGINT to the sell thread to interrupt read()
* Verify that TV apps exit cleanly
* TV casting app with proper shutdown on SIGTERM
* Fix import
* Revert sigaction() usage, as it seems not to work on Darwin
* Remove ifdefs
* Use signal() instead of sigaction() on Darwin
* Restyled by clang-format
---------
Co-authored-by: Restyled.io <commits@restyled.io>
Update light-switch-app/nrfconnect/README.md to fix privilege (#36657)
Update light-switch-app/nrfconnect/README.md to fix privilege
python.md: Add real example for run_python_test for the lighting_app (#36645)
This PR adds a real example for running the `run_python_test.py` script against the `chip-lighting-app`.
python.md: Fix python_env command (#36641)
* python.md: Fix python_env command
This PR fixes the python activation command in the tutorial.
From `source pyenv/bin/activate` to `source out/python_env/bin/activate`
* Restyled by prettier-markdown
---------
Co-authored-by: Restyled.io <commits@restyled.io>
[NXP][platform][RT][RW61x] Disable "chip_inet_config_enable_tcp_endpoint" gn arg (#36665)
* [NXP][platform][rt1060] Disable chip_inet_config_enable_tcp_endpoint
Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
* [NXP][platform][rt1170] Disable chip_inet_config_enable_tcp_endpoint
Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
* [NXP][platform][rw61x] Disable chip_inet_config_enable_tcp_endpoint
Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
---------
Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
Add skip_bytes functionality to OTA Provider and BDX downloader class (#36357)
[Silabs] Trustzone-compatibility. (#36643)
[Silabs] Silabs Uart Shell fixes (#36667)
* [SL-UP] Bugfix/silabs out rtt removal (#142)
* [SL-UP] Bugfix/matter shell crash nullptr (#125)
* Added checks on null ptr to prevent uart shell crash and modified ICD shell commands to be compatible with our internal structure
Update energy-management-app README.md (#36662)
* Update energy-management-app README.md
Add link to `kBasicInstallationTestEvent` definition
* Update README.md
* Update README.md
* Restyle
* Update README.md
Use commit it
Remove Active flag when the readhandler is going to be destroyed (#36653)
* remove Active flag when the readhandler is going to be destroyed
* Restyled by clang-format
---------
Co-authored-by: Restyled.io <commits@restyled.io>
Sync latest commits of the laundry-washer-app in nxp rw61x platform (#36664)
* Fix Matter 1.3 certifiction TC-LWM-1.1 case that feature-map should be 0
Signed-off-by: Chin-Ran Lo <nxf57500@lsv051039.swis.nl-cdc01.nxp.com>
(cherry picked from commit 21c40394dd0df65b1dd07e6cf9545f9d5cb1af25)
* Update laundry washer ZAP file to pass TC-IDM-10.2/10.4/10.5 during Matter 1.4 SVE
Signed-off-by: Oliver Fan <nxf90549@lsvm07u0000059.swis.us-west-2.aws.nxp.com>
[nxp toup][laundry-washer-app][common] Update laundry washer to pass TC-OPSTATE-2.6 during Matter 1.4 SVE
Signed-off-by: Oliver Fan <nxf90549@lsvm07u0000059.swis.us-west-2.aws.nxp.com>
[nxp toup][laundry-washer-app][RW612][RTOS] Update RW612 RTOS laundry washer app to pass TC-OPSTATE-2.6 during Matter 1.4 SVE
Signed-off-by: Oliver Fan <nxf90549@lsvm07u0000059.swis.us-west-2.aws.nxp.com>
[nxp toup][laundry-washer-app][RT1170][RTOS] Update RT1170+IW612 RTOS laundry washer app to pass TC-OPSTATE-2.6 during Matter 1.4 SVE
Signed-off-by: Oliver Fan <nxf90549@lsvm07u0000059.swis.us-west-2.aws.nxp.com>
[nxp toup][laundry-washer-app][RW612][Zephyr] Update laundry washer to pass TC-OPSTATE-2.6, TC-IDM-10.2/10.4/10.5 during Matter 1.4 SVE
Signed-off-by: Oliver Fan <nxf90549@lsvm07u0000059.swis.us-west-2.aws.nxp.com>
* Update RW/RT device types ZAP files to align with latest root node configuration updates done in thermostat zap configuration
Signed-off-by: Lo,Chin-Ran <chin-ran.lo@nxp.com>
* Update RT1060 RTOS laundry washer app to aligh with rw61x and rt1170 to pass TC-OPSTATE-2.6
Signed-off-by: Oliver Fan <nxf90549@lsvm07u0000059.swis.us-west-2.aws.nxp.com>
* Restyled by clang-format
* Restyled by gn
---------
Signed-off-by: Oliver Fan <nxf90549@lsvm07u0000059.swis.us-west-2.aws.nxp.com>
Signed-off-by: Lo,Chin-Ran <chin-ran.lo@nxp.com>
Co-authored-by: Chin-Ran Lo <nxf57500@lsv051039.swis.nl-cdc01.nxp.com>
Co-authored-by: Oliver Fan <nxf90549@lsvm07u0000059.swis.us-west-2.aws.nxp.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Decouple ember-specific functions from descriptor cluster (#36493)
* descriptor: decouple from ember
* Restyled by clang-format
* fix shadow error
* fix test build
* fix test build
* use Client cluster iteration
* Restyled by clang-format
* fix CI building error
* fix android build
* review changes
* Restyled by clang-format
* review changes
* some doc changes
* Fix the semantic tags iterator and add unit tests for the new functions
* Restyled by clang-format
* fix clang tidy check
* add composition test
* Restyled by clang-format
* Update src/app/data-model-provider/MetadataTypes.h
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Update src/app/codegen-data-model-provider/CodegenDataModelProvider.cpp
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
---------
Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Andrei Litvin <andy314@gmail.com>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Updating TC_CADMIN_1_9 test module due to issues noticed during step 4 (#36546)
* Updating TC_CADMIN_1_9 test module:
- Replacing wait with using 3 and 50 as error codes possible when attempting to commission on the 21st attempt!
* Restyled by autopep8
* Updating TC_CADMIN_1_9 test module:
- Attempting to resolve linting error for bare except
* Updating TC_CADMIN_1_9 test module:
- Attempting to resolve linting errors
* Updating CADMIN_1_9 test module:
- Replaced exception to using asserts.assert_in() function instead, much cleaner!
---------
Co-authored-by: Restyled.io <commits@restyled.io>
esp32: remove esp32_codegen.cmake and use common chip_data_model.cmake instead (#36674)
Bridge: Remove ACL client (#36677)
Fix JniReferences::GetOptionalValue (#36682)
* Fix JniReferences::GetOptionalValue
It's possible the optional is not of class java/util/Optional so just use the object provided
* fix formatting
Update host.py to fix water-leak-detector-app gen (#36683)
Formatting code extracts (#36670)
* Formatting code extracts
Formatting code extracts
* Update python.md
WARNING: Could not lex literal_block as "python"
Documentation: Fix incorrect paths in fuzz_testing.md and yaml.md (#36689)
* Documentation: Fix incorrect paths in fuzz_testing.md and yaml.md
* Update fuzz_testing…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.