TC-TCTL-2.3 python test #36703
Merged
TC-TCTL-2.3 python test #36703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
|
|
github-actions
bot
added
github
workflows
tests
matter-1.4-te2-script-change
|
PR #36703: Size comparison from 2bc3251 to 71708d1 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
reviewed
Dec 4, 2024
…ttribute_check_success()
|
PR #36703: Size comparison from 2bc3251 to cb1fdfc Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36703: Size comparison from af8d173 to 5777abd Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36703: Size comparison from b0d0614 to 7fa71d7 Full report (19 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
|
PR #36703: Size comparison from b0d0614 to 1a8d6b2 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
reviewed
Dec 18, 2024
There was a problem hiding this comment.
Left two suggestions. That second one is totally my fault - should have realized that earlier. My apologies.
With those changes, this PR looks good, so just ping me once those changes are done and I can checkmark this.
The other thing that will need to happen here is an update to the test plan to remove the PICS markings. Once you add the expected outcome strings, we have a script that can dump the test plan table, so it's just a copy-paste, open PR thing.
The test plan generation script is here: https://github.com/project-chip/connectedhomeip/blob/master/src/python_testing/test_plan_table_generator.py
You just give the file name, class name and test name. So that would be
python src/python_testing/test_plan_table_generator.py TC_TCTL_2_3.py TC_TCTL_2_3 test_TC_TCTL_2_3
A bit redundant, but oh well.
The test plan is here: https://github.com/CHIP-Specifications/chip-test-plans/blob/master/src/cluster/temperaturecontrol.adoc#tc-tctl-2-3-optional-temperature-level-attributes-with-dut_server
You would just replace the table in the "Test Procedure" section with the one that's generated, and open a PR saying that you're removing the PICS markers because those attributes are mandatory when the TL feature is supported.
|
PR #36703: Size comparison from b0d0614 to 0daf2a1 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
I've made a requested changes and asked Juan to raise a PR to a test plan repo https://github.com/CHIP-Specifications/chip-test-plans/pull/4834 as I still have to get access to CHIP-Specifications organization |
andy31415
reviewed
Jan 6, 2025
|
PR #36703: Size comparison from dedef1f to c325a1e Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
approved these changes
Jan 8, 2025
This was referenced Jan 10, 2025
Alami-Amine
pushed a commit
to Alami-Amine/connectedhomeip
that referenced
this pull request
Jan 12, 2025
* implement TC_TCTL_2_3 in Python * add test to CI workflow * revert incorrect path addition, leave only xml parsing check * fix typo * fix code review comment: rework reading attribute using read_single_attribute_check_success() * use run_if_endpoint_matches decorator and use attribute guards * reuse cluster variable * address code review comments * fix typos * fix loop issue found in review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Functional
Description:
Verifies that the DUT can respond to Temperature Control Cluster attribute read commands. This test case is required only if the TL feature is supported (TCTL.S.F01(TL)). Some check examples:
Test plan for more details: https://github.com/CHIP-Specifications/chip-test-plans/blob/master/src/cluster/temperaturecontrol.adoc#tc-tctl-2-3-optional-temperature-level-attributes-with-dut_server