TCP: Use RunOnTCPIP() for the LwIP TCP EndPoint and create pre-allocated connection endpoint for listen endpoint #36962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
wqx6
changed the title
|
PR #36962: Size comparison from 1b4c56c to 5256657 Increases above 0.2%:
Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
|
PR #36962: Size comparison from 1b4c56c to 267b09d Increases above 0.2%:
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
@wqx6 please fix build errors and add a |
bzbarsky-apple
requested changes
Jan 6, 2025
|
PR #36962: Size comparison from f8d457a to cca01f2 Increases above 0.2%:
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pidarped
reviewed
Jan 8, 2025
|
PR #36962: Size comparison from f8d457a to a331147 Increases above 0.2%:
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Jan 9, 2025
andy31415
reviewed
Jan 9, 2025
|
@wqx6 do we know why this costs 2K of flash? that is a lot |
andy31415
requested changes
Jan 14, 2025
bzbarsky-apple
previously approved these changes
Jan 17, 2025
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
This reverts commit 99f823c.
andy31415
reviewed
Jan 20, 2025
|
@andy31415 @bzbarsky-apple I made the following change which doesn't need to add the
Could you please review it? |
|
PR #36962: Size comparison from ce47e22 to d5069a3 Increases above 0.2%:
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
dismissed
their stale review
Significant change to the code since the review.
wqx6
changed the title
bzbarsky-apple
approved these changes
Feb 17, 2025
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
andy31415
approved these changes
Feb 26, 2025
gmarcosb
pushed a commit
to gmarcosb/connectedhomeip
that referenced
this pull request
Mar 4, 2025
…ted connection endpoint for listen endpoint (project-chip#36962) * TCP: Use RunOnTCPIP for the LwIP TCP EndPoint * fix memory leak when the pbuf_alloc gets a packet buffer with chained buffers * Restyled by clang-format * fix build issue * Try to fix CI build errors * move RunOnMatterContext to LayerFreeRTOS * add macro for PlatformEventing::LockMatterStack/UnlockMatterStack * make the new function public in LayerFreeRTOS * fix typo * add some comments in Packet buffer * Restyled by clang-format * Add macro for the RunWithMatterContextLock function * add some comment for avoiding dead lock with the new added function * review changes and revert packet buffer changes * Add PlatformLockSupport for system layer * Restyled by clang-format * fix CI build * review changes * remove some docs * use closure * Update src/platform/PlatformLockSupport.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * update src/platform/PlatformLockSupport.cpp * Revert "update src/platform/PlatformLockSupport.cpp" This reverts commit 99f823c. * Use a pre allocated endpoint for the TCP connection * Restyled by clang-format * revert the change in system * Add pre allocated connection releasing when closing listen endpoint * typo fix * Update src/inet/TCPEndPointImplLwIP.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
RunOnTCPIP()inTCPEndPointImplLwIPinstead ofLOCK_TCPIP_CORE()/UNLOCK_TCPIP_CORE().Testing
chip_inet_config_enable_tcp_endpoint.