-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refrigeratoralarm data model missing commands. #37152
Refrigeratoralarm data model missing commands. #37152
Conversation
Juan Erasmo Trejo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
PR #37152: Size comparison from f5716b1 to 190c82f Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whatever process or tool led to this PR needs to be fixed to understand spec conformance annotations, please.
<description>Reset alarm</description> | ||
<arg name="Alarms" type="AlarmBitmap" optional="false"/> | ||
<mandatoryConform> | ||
<feature name="RESET"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conformance for this feature for this cluster is X (forbidden) in the spec.
</mandatoryConform> | ||
</command> | ||
|
||
<command source="client" code="0x01" name="ModifyEnabledAlarms" optional="true"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conformance for this command for this cluster is X (forbidden) in the spec.
Testing
Added the missing commands in the definition for the refrigerator-alarm.xml
Ran the command:
./scripts/tools/zap_regen_all.py
Added all the files updated during the regen.