Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refrigeratoralarm data model missing commands. #37152

Conversation

jtrejoespinoza-grid
Copy link

Testing

Added the missing commands in the definition for the refrigerator-alarm.xml

  • Reset
  • ModifyEnabledAlarms

Ran the command:

./scripts/tools/zap_regen_all.py

Added all the files updated during the regen.

Copy link

semanticdiff-com bot commented Jan 21, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  src/controller/java/generated/java/chip/devicecontroller/ClusterIDMapping.java  12% smaller
  examples/all-clusters-app/all-clusters-common/all-clusters-app.matter Unsupported file format
  examples/chef/devices/rootnode_refrigerator_temperaturecontrolledcabinet_temperaturecontrolledcabinet_ffdb696680.matter Unsupported file format
  examples/refrigerator-app/silabs/data_model/refrigerator-thread-app.matter Unsupported file format
  examples/refrigerator-app/silabs/data_model/refrigerator-wifi-app.matter Unsupported file format
  src/app/zap-templates/zcl/data-model/chip/refrigerator-alarm.xml  0% smaller
  src/controller/data_model/controller-clusters.matter Unsupported file format
  src/controller/python/chip/clusters/CHIPClusters.py  0% smaller
  src/controller/python/chip/clusters/Objects.py  0% smaller
  src/darwin/Framework/CHIP/zap-generated/MTRBaseClusters.h Unsupported file format
  src/darwin/Framework/CHIP/zap-generated/MTRBaseClusters.mm Unsupported file format
  src/darwin/Framework/CHIP/zap-generated/MTRClusterConstants.h Unsupported file format
  src/darwin/Framework/CHIP/zap-generated/MTRClusterNames.mm Unsupported file format
  src/darwin/Framework/CHIP/zap-generated/MTRClusters.h Unsupported file format
  src/darwin/Framework/CHIP/zap-generated/MTRClusters.mm Unsupported file format
  src/darwin/Framework/CHIP/zap-generated/MTRCommandPayloadsObjc.h Unsupported file format
  src/darwin/Framework/CHIP/zap-generated/MTRCommandPayloadsObjc.mm Unsupported file format
  src/darwin/Framework/CHIP/zap-generated/MTRCommandPayloads_Internal.h Unsupported file format
  zzz_generated/app-common/app-common/zap-generated/callback.h Unsupported file format
  zzz_generated/app-common/app-common/zap-generated/cluster-objects.cpp Unsupported file format
  zzz_generated/app-common/app-common/zap-generated/cluster-objects.h Unsupported file format
  zzz_generated/app-common/app-common/zap-generated/ids/Commands.h Unsupported file format
  zzz_generated/chip-tool/zap-generated/cluster/Commands.h Unsupported file format
  zzz_generated/chip-tool/zap-generated/cluster/logging/EntryToText.cpp Unsupported file format
  zzz_generated/darwin-framework-tool/zap-generated/cluster/Commands.h Unsupported file format

@CLAassistant
Copy link

CLAassistant commented Jan 21, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jtrejoespinoza-grid
❌ Juan Erasmo Trejo


Juan Erasmo Trejo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

github-actions bot commented Jan 21, 2025

PR #37152: Size comparison from f5716b1 to 190c82f

Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
platform target config section f5716b1 190c82f change % change
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 838000 838000 0 0.0
RAM 123464 123464 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823412 823412 0 0.0
RAM 125344 125344 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770636 770636 0 0.0
RAM 113804 113804 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 754888 754888 0 0.0
RAM 114012 114012 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538433 538433 0 0.0
RAM 205192 205192 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572297 572297 0 0.0
RAM 205344 205344 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 913652 913652 0 0.0
RAM 143168 143168 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 888632 888632 0 0.0
RAM 141355 141355 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 848696 848696 0 0.0
RAM 142080 142080 0 0.0
qpg lighting-app qpg6105+debug FLASH 661992 661992 0 0.0
RAM 105204 105204 0 0.0
lock-app qpg6105+debug FLASH 619772 619772 0 0.0
RAM 99648 99648 0 0.0
stm32 light STM32WB5MM-DK FLASH 482608 482608 0 0.0
RAM 144672 144672 0 0.0
tizen all-clusters-app arm unknown 5112 5112 0 0.0
FLASH 1751312 1751316 4 0.0
RAM 93524 93524 0 0.0
chip-tool-ubsan arm unknown 11024 11040 16 0.1
FLASH 18213990 18226438 12448 0.1
RAM 7955248 7960792 5544 0.1

Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whatever process or tool led to this PR needs to be fixed to understand spec conformance annotations, please.

<description>Reset alarm</description>
<arg name="Alarms" type="AlarmBitmap" optional="false"/>
<mandatoryConform>
<feature name="RESET"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conformance for this feature for this cluster is X (forbidden) in the spec.

</mandatoryConform>
</command>

<command source="client" code="0x01" name="ModifyEnabledAlarms" optional="true">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conformance for this command for this cluster is X (forbidden) in the spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants