Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refrigeratoralarm data model missing commands. #37152

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3419,6 +3419,19 @@ cluster RefrigeratorAlarm = 87 {
readonly attribute attrib_id attributeList[] = 65531;
readonly attribute bitmap32 featureMap = 65532;
readonly attribute int16u clusterRevision = 65533;

request struct ResetRequest {
AlarmBitmap alarms = 0;
}

request struct ModifyEnabledAlarmsRequest {
AlarmBitmap mask = 0;
}

/** Reset alarm */
command Reset(ResetRequest): DefaultSuccess = 0;
/** Modify enabled alarms */
command ModifyEnabledAlarms(ModifyEnabledAlarmsRequest): DefaultSuccess = 1;
}

/** Attributes and commands for selecting a mode from a list of supported options. */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1371,6 +1371,19 @@ cluster RefrigeratorAlarm = 87 {
readonly attribute attrib_id attributeList[] = 65531;
readonly attribute bitmap32 featureMap = 65532;
readonly attribute int16u clusterRevision = 65533;

request struct ResetRequest {
AlarmBitmap alarms = 0;
}

request struct ModifyEnabledAlarmsRequest {
AlarmBitmap mask = 0;
}

/** Reset alarm */
command Reset(ResetRequest): DefaultSuccess = 0;
/** Modify enabled alarms */
command ModifyEnabledAlarms(ModifyEnabledAlarmsRequest): DefaultSuccess = 1;
}

/** Attributes and commands for configuring the measurement of temperature, and reporting temperature measurements. */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1710,6 +1710,19 @@ cluster RefrigeratorAlarm = 87 {
readonly attribute attrib_id attributeList[] = 65531;
readonly attribute bitmap32 featureMap = 65532;
readonly attribute int16u clusterRevision = 65533;

request struct ResetRequest {
AlarmBitmap alarms = 0;
}

request struct ModifyEnabledAlarmsRequest {
AlarmBitmap mask = 0;
}

/** Reset alarm */
command Reset(ResetRequest): DefaultSuccess = 0;
/** Modify enabled alarms */
command ModifyEnabledAlarms(ModifyEnabledAlarmsRequest): DefaultSuccess = 1;
}

endpoint 0 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1621,6 +1621,19 @@ cluster RefrigeratorAlarm = 87 {
readonly attribute attrib_id attributeList[] = 65531;
readonly attribute bitmap32 featureMap = 65532;
readonly attribute int16u clusterRevision = 65533;

request struct ResetRequest {
AlarmBitmap alarms = 0;
}

request struct ModifyEnabledAlarmsRequest {
AlarmBitmap mask = 0;
}

/** Reset alarm */
command Reset(ResetRequest): DefaultSuccess = 0;
/** Modify enabled alarms */
command ModifyEnabledAlarms(ModifyEnabledAlarmsRequest): DefaultSuccess = 1;
}

endpoint 0 {
Expand Down
14 changes: 14 additions & 0 deletions src/app/zap-templates/zcl/data-model/chip/refrigerator-alarm.xml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,20 @@ limitations under the License.
<mandatoryConform/>
</attribute>

<command source="client" code="0x00" name="Reset" optional="true">
<description>Reset alarm</description>
<arg name="Alarms" type="AlarmBitmap" optional="false"/>
<mandatoryConform>
<feature name="RESET"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conformance for this feature for this cluster is X (forbidden) in the spec.

</mandatoryConform>
</command>

<command source="client" code="0x01" name="ModifyEnabledAlarms" optional="true">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conformance for this command for this cluster is X (forbidden) in the spec.

<description>Modify enabled alarms</description>
<arg name="Mask" type="AlarmBitmap" optional="false"/>
<optionalConform/>
</command>

<event side="server" code="0x00" priority="info" name="Notify" optional="false">
<description>Notify</description>
<field id="0" name="Active" type="AlarmBitmap" />
Expand Down
13 changes: 13 additions & 0 deletions src/controller/data_model/controller-clusters.matter
Original file line number Diff line number Diff line change
Expand Up @@ -3637,6 +3637,19 @@ cluster RefrigeratorAlarm = 87 {
readonly attribute attrib_id attributeList[] = 65531;
readonly attribute bitmap32 featureMap = 65532;
readonly attribute int16u clusterRevision = 65533;

request struct ResetRequest {
AlarmBitmap alarms = 0;
}

request struct ModifyEnabledAlarmsRequest {
AlarmBitmap mask = 0;
}

/** Reset alarm */
command Reset(ResetRequest): DefaultSuccess = 0;
/** Modify enabled alarms */
command ModifyEnabledAlarms(ModifyEnabledAlarmsRequest): DefaultSuccess = 1;
}

/** Attributes and commands for selecting a mode from a list of supported options. */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7204,7 +7204,9 @@ public static Event value(long id) throws NoSuchFieldError {
}
}

public enum Command {;
public enum Command {
Reset(0L),
ModifyEnabledAlarms(1L),;
private final long id;
Command(long id) {
this.id = id;
Expand All @@ -7222,7 +7224,41 @@ public static Command value(long id) throws NoSuchFieldError {
}
throw new NoSuchFieldError();
}
}@Override
}public enum ResetCommandField {Alarms(0),;
private final int id;
ResetCommandField(int id) {
this.id = id;
}

public int getID() {
return id;
}
public static ResetCommandField value(int id) throws NoSuchFieldError {
for (ResetCommandField field : ResetCommandField.values()) {
if (field.getID() == id) {
return field;
}
}
throw new NoSuchFieldError();
}
}public enum ModifyEnabledAlarmsCommandField {Mask(0),;
private final int id;
ModifyEnabledAlarmsCommandField(int id) {
this.id = id;
}

public int getID() {
return id;
}
public static ModifyEnabledAlarmsCommandField value(int id) throws NoSuchFieldError {
for (ModifyEnabledAlarmsCommandField field : ModifyEnabledAlarmsCommandField.values()) {
if (field.getID() == id) {
return field;
}
}
throw new NoSuchFieldError();
}
}@Override
public String getAttributeName(long id) throws NoSuchFieldError {
return Attribute.value(id).toString();
}
Expand Down
14 changes: 14 additions & 0 deletions src/controller/python/chip/clusters/CHIPClusters.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

33 changes: 33 additions & 0 deletions src/controller/python/chip/clusters/Objects.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 13 additions & 0 deletions src/darwin/Framework/CHIP/zap-generated/MTRBaseClusters.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

49 changes: 49 additions & 0 deletions src/darwin/Framework/CHIP/zap-generated/MTRBaseClusters.mm

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions src/darwin/Framework/CHIP/zap-generated/MTRClusterNames.mm

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 5 additions & 2 deletions src/darwin/Framework/CHIP/zap-generated/MTRClusters.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading