-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] Re-activate subscription when receiving check-in message if subscription fails and resub is scheduled #37481
[ICD] Re-activate subscription when receiving check-in message if subscription fails and resub is scheduled #37481
Conversation
5423fec
to
84eeb84
Compare
84eeb84
to
0a45f2b
Compare
0a45f2b
to
64037cc
Compare
17bb029
to
82d1fda
Compare
82d1fda
to
c770997
Compare
PR #37481: Size comparison from 92f9f0b to c770997 Full report (10 builds for cc32xx, nrfconnect, qpg, stm32, tizen)
|
PR #37481: Size comparison from 92f9f0b to a103e4f Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
a103e4f
to
a4a3c11
Compare
PR #37481: Size comparison from 73fe30c to cb2ecc4 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
07676db
to
c80d18f
Compare
PR #37481: Size comparison from b9a94b5 to c80d18f Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
c80d18f
to
8df8d47
Compare
PR #37481: Size comparison from 28c1d83 to cc6d5fe Full report (11 builds for cc13x4_26x4, cc32xx, qpg, stm32, tizen)
|
cc6d5fe
to
5783085
Compare
PR #37481: Size comparison from 28c1d83 to 5783085 Full report (58 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
5783085
to
b48e87c
Compare
PR #37481: Size comparison from d5d2cba to fe8abb1 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
fe8abb1
to
fe911c3
Compare
PR #37481: Size comparison from d829d90 to 5f3796d Full report (46 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
5f3796d
to
276d01a
Compare
PR #37481: Size comparison from ab3d5ae to 276d01a Full report (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
276d01a
to
2c7b0f2
Compare
PR #37481: Size comparison from ab3d5ae to 2c7b0f2 Full report (58 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
2c7b0f2
to
1ef0011
Compare
PR #37481: Size comparison from ab3d5ae to 1ef0011 Full report (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
…scription fails and resub is scheduled (project-chip#37481) * Resubscribe when check-in is received and it is not in inactive state * Restyled by whitespace * address comments * add test * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
Assume read client fails for subscription because of various timeout via SendAutoResubscribeRequest API with ScopedNodeId and goes to resubscribe with back-off algorithm, once the device becomes active, controller receives the corresponding check-in message, client's scheduled subscription cannot be re-activated immediately. Intuitively, it is better that a resubscription can be triggered immediately
Proposed Resolution:
Re-activate subscription when receiving check-in message if subscription fails and resub is scheduled
Testing
Add unit test