[Darwin] Support MTRCommandWithRequiredResponse being nested in XPC #37506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When secure decoding MTRCommandWithRequiredResponse as part of [MTRDevice deviceController:nodeID:invokeCommands:completion:], it needs to list all classes that be part of the commandFields and requiredResponse fields. When double nested XPC will only assume to decode NSDictionary of basic type.
|
Review changes with |
woody-apple
approved these changes
Feb 11, 2025
|
PR #37506: Size comparison from da6a512 to fdcc42a Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pimpalemahesh
pushed a commit
to pimpalemahesh/connectedhomeip
that referenced
this pull request
Feb 12, 2025
…roject-chip#37506) * [Darwin] Support MTRCommandWithRequiredResponse being nested in XPC When secure decoding MTRCommandWithRequiredResponse as part of [MTRDevice deviceController:nodeID:invokeCommands:completion:], it needs to list all classes that be part of the commandFields and requiredResponse fields. When double nested XPC will only assume to decode NSDictionary of basic type. * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
ratgr
pushed a commit
to ratgr/connectedhomeip
that referenced
this pull request
Feb 26, 2025
…roject-chip#37506) * [Darwin] Support MTRCommandWithRequiredResponse being nested in XPC When secure decoding MTRCommandWithRequiredResponse as part of [MTRDevice deviceController:nodeID:invokeCommands:completion:], it needs to list all classes that be part of the commandFields and requiredResponse fields. When double nested XPC will only assume to decode NSDictionary of basic type. * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
gmarcosb
pushed a commit
to gmarcosb/connectedhomeip
that referenced
this pull request
Mar 4, 2025
…roject-chip#37506) * [Darwin] Support MTRCommandWithRequiredResponse being nested in XPC When secure decoding MTRCommandWithRequiredResponse as part of [MTRDevice deviceController:nodeID:invokeCommands:completion:], it needs to list all classes that be part of the commandFields and requiredResponse fields. When double nested XPC will only assume to decode NSDictionary of basic type. * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When secure decoding MTRCommandWithRequiredResponse as part of [MTRDevice deviceController:nodeID:invokeCommands:completion:], it needs to list all classes that be part of the commandFields and requiredResponse fields. When double nested XPC will only assume to decode NSDictionary of basic type.
Testing
Tested locally