Closure control cluster server code implementation #37561

sabollim-silabs · 2025-02-13T18:08:38Z

Testing

Enabled the cluster in all clusters app and built the server code locally.

semanticdiff-com · 2025-02-13T18:08:42Z

Review changes with

Changed Files

File	Status
src/app/chip_data_model.gni	Unsupported file format
src/app/clusters/closure-control-server/closure-control-cluster-objects.h	Unsupported file format
src/app/clusters/closure-control-server/closure-control-server.cpp	Unsupported file format
src/app/clusters/closure-control-server/closure-control-server.h	Unsupported file format
src/app/common/templates/config-data.yaml	0% smaller
src/app/zap_cluster_list.json	0% smaller
zzz_generated/app-common/app-common/zap-generated/callback.h	Unsupported file format

github-actions · 2025-02-13T18:22:16Z

PR #37561: Size comparison from ecb3c14 to acc7a7d

Full report (1 build for stm32)

platform	target	config	section	`ecb3c14`	`acc7a7d`	change	% change
stm32	light	STM32WB5MM-DK	FLASH	459736	459736	0	0.0
			RAM	141568	141568	0	0.0

…r_code

github-actions · 2025-02-14T10:37:05Z

PR #37561: Size comparison from 1b3f616 to 651fb3b

Full report (3 builds for cc32xx, stm32)

platform	target	config	section	`1b3f616`	`651fb3b`
cc32xx	air-purifier	CC3235SF_LAUNCHXL	FLASH	538894	538894
			RAM	205208	205208
	lock	CC3235SF_LAUNCHXL	FLASH	572766	572766
			RAM	205360	205360
stm32	light	STM32WB5MM-DK	FLASH	459736	459736
			RAM	141568	141568

src/app/clusters/closure-control-server/closure-control-server.cpp

src/app/clusters/closure-control-server/closure-control-server.h

…r_code

github-actions · 2025-02-17T10:00:14Z

PR #37561: Size comparison from 7c1d6f7 to 236a68b

Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)

platform	target	config	section	`7c1d6f7`	`236a68b`
bl602	lighting-app	bl602+mfd+littlefs+rpc	FLASH	1095544	1095544
			RAM	94890	94890
bl702	lighting-app	bl702+eth	FLASH	652000	652000
			RAM	33617	33617
		bl702+wifi	FLASH	828152	828152
			RAM	22325	22325
		bl706+mfd+rpc+littlefs	FLASH	1061288	1061288
			RAM	32269	32269
bl702l	contact-sensor-app	bl702l+mfd+littlefs	FLASH	891998	891998
			RAM	26896	26896
	lighting-app	bl702l+mfd+littlefs	FLASH	975368	975368
			RAM	24736	24736
cc13x4_26x4	lighting-app	LP_EM_CC1354P10_6	FLASH	815468	815468
			RAM	120352	120352
	lock-ftd	LP_EM_CC1354P10_6	FLASH	824096	824096
			RAM	125360	125360
	pump-app	LP_EM_CC1354P10_6	FLASH	771248	771248
			RAM	113820	113820
	pump-controller-app	LP_EM_CC1354P10_6	FLASH	755516	755516
			RAM	114028	114028
cc32xx	air-purifier	CC3235SF_LAUNCHXL	FLASH	538998	538998
			RAM	205208	205208
	lock	CC3235SF_LAUNCHXL	FLASH	572870	572870
			RAM	205360	205360
cyw30739	light	CYW30739B2-P5-EVK-01	unknown	2040	2040
			FLASH	656597	656597
			RAM	75420	75420
		CYW30739B2-P5-EVK-02	unknown	2040	2040
			FLASH	676457	676457
			RAM	78060	78060
		CYW30739B2-P5-EVK-03	unknown	2040	2040
			FLASH	676457	676457
			RAM	78060	78060
		CYW930739M2EVB-02	unknown	2040	2040
			FLASH	633381	633381
			RAM	70488	70488
	light-switch	CYW30739B2-P5-EVK-01	unknown	2040	2040
			FLASH	616213	616213
			RAM	71532	71532
		CYW30739B2-P5-EVK-02	unknown	2040	2040
			FLASH	635849	635849
			RAM	74076	74076
		CYW30739B2-P5-EVK-03	unknown	2040	2040
			FLASH	635849	635849
			RAM	74076	74076
	lock	CYW30739B2-P5-EVK-01	unknown	2040	2040
			FLASH	635717	635717
			RAM	74540	74540
		CYW30739B2-P5-EVK-02	unknown	2040	2040
			FLASH	655433	655433
			RAM	77084	77084
		CYW30739B2-P5-EVK-03	unknown	2040	2040
			FLASH	655433	655433
			RAM	77084	77084
	thermostat	CYW30739B2-P5-EVK-01	unknown	2040	2040
			FLASH	612065	612065
			RAM	68628	68628
		CYW30739B2-P5-EVK-02	unknown	2040	2040
			FLASH	631925	631925
			RAM	71268	71268
		CYW30739B2-P5-EVK-03	unknown	2040	2040
			FLASH	631925	631925
			RAM	71268	71268
efr32	lock-app	BRD4187C	FLASH	937616	937616
			RAM	159916	159916
		BRD4338a	FLASH	731696	731696
			RAM	234772	234772
	window-app	BRD4187C	FLASH	1030336	1030336
			RAM	128020	128020
esp32	all-clusters-app	c3devkit	DRAM	97312	97312
			FLASH	1581788	1581788
			IRAM	83820	83820
		m5stack	DRAM	116100	116100
			FLASH	`1549762`	`1549762`
			IRAM	117039	117039
linux	air-purifier-app	debug	unknown	4712	4712
			FLASH	`2649195`	`2649195`
			RAM	111600	111600
	all-clusters-app	debug	unknown	5520	5520
			FLASH	`5915628`	`5915628`
			RAM	510416	510416
	all-clusters-minimal-app	debug	unknown	5416	5416
			FLASH	5263172	5263172
			RAM	221528	221528
	bridge-app	debug	unknown	5432	5432
			FLASH	4621848	4621848
			RAM	200264	200264
	chip-tool	debug	unknown	6088	6088
			FLASH	13071502	13071502
			RAM	596482	596482
	chip-tool-ipv6only	arm64	unknown	21816	21816
			FLASH	11138080	11138080
			RAM	648184	648184
	fabric-admin	debug	unknown	5776	5776
			FLASH	11360283	11360283
			RAM	596266	596266
	fabric-bridge-app	debug	unknown	4680	4680
			FLASH	`4447170`	`4447170`
			RAM	187480	187480
	fabric-sync	debug	unknown	4936	4936
			FLASH	5564101	5564101
			RAM	467024	467024
	lighting-app	debug+rpc+ui	unknown	6104	6104
			FLASH	5424961	5424961
			RAM	204208	204208
	lock-app	debug	unknown	5384	5384
			FLASH	4681892	4681892
			RAM	191216	191216
	ota-provider-app	debug	unknown	4720	4720
			FLASH	4300278	4300278
			RAM	180184	180184
	ota-requestor-app	debug	unknown	4672	4672
			FLASH	4437654	4437654
			RAM	184768	184768
	shell	debug	unknown	4216	4216
			FLASH	2950364	2950364
			RAM	144040	144040
	thermostat-no-ble	arm64	unknown	9512	9512
			FLASH	4040184	4040184
			RAM	228552	228552
	tv-app	debug	unknown	5712	5712
			FLASH	5902981	5902981
			RAM	590424	590424
	tv-casting-app	debug	unknown	5288	5288
			FLASH	11244045	11244045
			RAM	710640	710640
nxp	contact	k32w0+release	FLASH	585072	585072
			RAM	70876	70876
		mcxw71+release	FLASH	600544	600544
			RAM	63096	63096
	light	k32w0+release	FLASH	611380	611380
			RAM	70268	70268
		k32w1+release	FLASH	685848	685848
			RAM	48680	48680
	lock	mcxw71+release	FLASH	749360	749360
			RAM	67500	67500
psoc6	all-clusters	cy8ckit_062s2_43012	FLASH	1646868	1646868
			RAM	211576	211576
	all-clusters-minimal	cy8ckit_062s2_43012	FLASH	1553620	1553620
			RAM	208392	208392
	light	cy8ckit_062s2_43012	FLASH	1439308	1439308
			RAM	197144	197144
	lock	cy8ckit_062s2_43012	FLASH	1467508	1467508
			RAM	224704	224704
qpg	lighting-app	qpg6105+debug	FLASH	662436	662436
			RAM	105220	105220
	lock-app	qpg6105+debug	FLASH	620232	620232
			RAM	99664	99664
stm32	light	STM32WB5MM-DK	FLASH	460008	460008
			RAM	141568	141568
telink	bridge-app	tl7218x	FLASH	665266	665266
			RAM	90828	90828
	contact-sensor-app	tlsr9528a_retention	FLASH	621948	621948
			RAM	31488	31488
	light-app-ota-shell-factory-data	tl3218x	FLASH	745458	745458
			RAM	40496	40496
		tl7218x	FLASH	754014	754014
			RAM	97632	97632
	light-switch-app-ota-compress-lzma-factory-data	tl7218x_retention	FLASH	680718	680718
			RAM	52192	52192
	light-switch-app-ota-compress-lzma-shell-factory-data	tlsr9528a	FLASH	709280	709280
			RAM	73400	73400
	lighting-app-ota-factory-data	tlsr9118bdk40d	FLASH	600836	600836
			RAM	138912	138912
	lighting-app-ota-rpc-factory-data-4mb	tlsr9518adk80d	FLASH	788968	788968
			RAM	96488	96488
tizen	all-clusters-app	arm	unknown	5104	5104
			FLASH	1751824	1751824
			RAM	93508	93508
	chip-tool-ubsan	arm	unknown	11396	11396
			FLASH	18683262	18683262
			RAM	`8181192`	`8181192`

github-actions · 2025-02-17T18:18:27Z

PR #37561: Size comparison from 7c1d6f7 to 280df4f

Full report (1 build for stm32)

platform	target	config	section	`7c1d6f7`	`280df4f`	change	% change
stm32	light	STM32WB5MM-DK	FLASH	460008	460008	0	0.0
			RAM	141568	141568	0	0.0

github-actions · 2025-02-18T19:46:20Z

PR #37561: Size comparison from 5621ff6 to 5c130df

Full report (3 builds for cc32xx, stm32)

platform	target	config	section	`5621ff6`	`5c130df`
cc32xx	air-purifier	CC3235SF_LAUNCHXL	FLASH	538730	538730
			RAM	205112	205112
	lock	CC3235SF_LAUNCHXL	FLASH	572886	572886
			RAM	205360	205360
stm32	light	STM32WB5MM-DK	FLASH	459776	459776
			RAM	141472	141472

src/app/clusters/closure-control-server/closure-control-server.cpp

github-actions · 2025-02-25T16:09:15Z

PR #37561: Size comparison from 9c49f28 to 2963bab

Full report (52 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)

platform	target	config	section	`9c49f28`	`2963bab`
bl602	lighting-app	bl602+mfd+littlefs+rpc	FLASH	1096628	1096628
			RAM	94842	94842
bl702	lighting-app	bl702+eth	FLASH	651606	651606
			RAM	33509	33509
		bl702+wifi	FLASH	828878	828878
			RAM	22233	22233
		bl706+mfd+rpc+littlefs	FLASH	1061274	1061274
			RAM	32157	32157
bl702l	contact-sensor-app	bl702l+mfd+littlefs	FLASH	892118	892118
			RAM	26896	26896
	lighting-app	bl702l+mfd+littlefs	FLASH	975014	975014
			RAM	24644	24644
cc13x4_26x4	lighting-app	LP_EM_CC1354P10_6	FLASH	815300	815300
			RAM	120256	120256
	lock-ftd	LP_EM_CC1354P10_6	FLASH	824220	824220
			RAM	125352	125352
	pump-app	LP_EM_CC1354P10_6	FLASH	771080	771080
			RAM	113724	113724
	pump-controller-app	LP_EM_CC1354P10_6	FLASH	755364	755364
			RAM	113932	113932
cc32xx	air-purifier	CC3235SF_LAUNCHXL	FLASH	538842	538842
			RAM	205112	205112
	lock	CC3235SF_LAUNCHXL	FLASH	572998	572998
			RAM	205360	205360
cyw30739	light	CYW30739B2-P5-EVK-01	unknown	2040	2040
			FLASH	656429	656429
			RAM	75324	75324
		CYW30739B2-P5-EVK-02	unknown	2040	2040
			FLASH	676289	676289
			RAM	77964	77964
		CYW30739B2-P5-EVK-03	unknown	2040	2040
			FLASH	676289	676289
			RAM	77964	77964
		CYW930739M2EVB-02	unknown	2040	2040
			FLASH	633213	633213
			RAM	70392	70392
	light-switch	CYW30739B2-P5-EVK-01	unknown	2040	2040
			FLASH	616293	616293
			RAM	71532	71532
		CYW30739B2-P5-EVK-02	unknown	2040	2040
			FLASH	635929	635929
			RAM	74076	74076
		CYW30739B2-P5-EVK-03	unknown	2040	2040
			FLASH	635929	635929
			RAM	74076	74076
	lock	CYW30739B2-P5-EVK-01	unknown	2040	2040
			FLASH	635789	635789
			RAM	74540	74540
		CYW30739B2-P5-EVK-02	unknown	2040	2040
			FLASH	655513	655513
			RAM	77084	77084
		CYW30739B2-P5-EVK-03	unknown	2040	2040
			FLASH	655513	655513
			RAM	77084	77084
	thermostat	CYW30739B2-P5-EVK-01	unknown	2040	2040
			FLASH	612137	612137
			RAM	68628	68628
		CYW30739B2-P5-EVK-02	unknown	2040	2040
			FLASH	631997	631997
			RAM	71268	71268
		CYW30739B2-P5-EVK-03	unknown	2040	2040
			FLASH	631997	631997
			RAM	71268	71268
linux	chip-tool-ipv6only	arm64	unknown	21976	21976
			FLASH	11495416	11495416
			RAM	656112	656112
	thermostat-no-ble	arm64	unknown	9448	9448
			FLASH	4138392	4138392
			RAM	229016	229016
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	FLASH	907708	907708
			RAM	142323	142323
		nrf7002dk_nrf5340_cpuapp	FLASH	901788	901788
			RAM	124663	124663
	all-clusters-minimal-app	nrf52840dk_nrf52840	FLASH	846312	846312
			RAM	141251	141251
nxp	contact	k32w0+release	FLASH	585256	585256
			RAM	70876	70876
		mcxw71+release	FLASH	600712	600712
			RAM	63096	63096
	light	k32w0+release	FLASH	611196	611196
			RAM	70164	70164
		k32w1+release	FLASH	685680	685680
			RAM	48584	48584
	lock	mcxw71+release	FLASH	749536	749536
			RAM	67500	67500
psoc6	all-clusters	cy8ckit_062s2_43012	FLASH	1646188	1646188
			RAM	211472	211472
	all-clusters-minimal	cy8ckit_062s2_43012	FLASH	1552956	1552956
			RAM	208288	208288
	light	cy8ckit_062s2_43012	FLASH	1438644	1438644
			RAM	197040	197040
	lock	cy8ckit_062s2_43012	FLASH	1467516	1467516
			RAM	224704	224704
qpg	lighting-app	qpg6105+debug	FLASH	662188	662188
			RAM	105116	105116
	lock-app	qpg6105+debug	FLASH	620304	620304
			RAM	99664	99664
stm32	light	STM32WB5MM-DK	FLASH	459832	459832
			RAM	141472	141472
telink	bridge-app	tl7218x	FLASH	665034	665034
			RAM	90728	90728
	contact-sensor-app	tlsr9528a_retention	FLASH	622078	622078
			RAM	31488	31488
	light-app-ota-shell-factory-data	tl3218x	FLASH	745218	745218
			RAM	40396	40396
		tl7218x	FLASH	753780	753780
			RAM	97540	97540
	light-switch-app-ota-compress-lzma-factory-data	tl7218x_retention	FLASH	680850	680850
			RAM	52192	52192
	light-switch-app-ota-compress-lzma-shell-factory-data	tlsr9528a	FLASH	709412	709412
			RAM	73400	73400
	lighting-app-ota-factory-data	tlsr9118bdk40d	FLASH	600592	600592
			RAM	138812	138812
	lighting-app-ota-rpc-factory-data-4mb	tlsr9518adk80d	FLASH	788820	788820
			RAM	96388	96388
tizen	all-clusters-app	arm	unknown	5076	5076
			FLASH	`1750852`	`1750852`
			RAM	93260	93260
	chip-tool-ubsan	arm	unknown	11492	11492
			FLASH	18983694	18983694
			RAM	8306240	8306240

github-actions · 2025-02-25T17:08:12Z

PR #37561: Size comparison from 9298ce7 to ac42399

Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)

platform	target	config	section	`9298ce7`	`ac42399`
bl602	lighting-app	bl602+mfd+littlefs+rpc	FLASH	1096628	1096628
			RAM	94842	94842
bl702	lighting-app	bl702+eth	FLASH	651606	651606
			RAM	33509	33509
		bl702+wifi	FLASH	828878	828878
			RAM	22233	22233
		bl706+mfd+rpc+littlefs	FLASH	1061274	1061274
			RAM	32157	32157
bl702l	contact-sensor-app	bl702l+mfd+littlefs	FLASH	892118	892118
			RAM	26896	26896
	lighting-app	bl702l+mfd+littlefs	FLASH	975014	975014
			RAM	24644	24644
cc13x4_26x4	lighting-app	LP_EM_CC1354P10_6	FLASH	815300	815300
			RAM	120256	120256
	lock-ftd	LP_EM_CC1354P10_6	FLASH	824220	824220
			RAM	125352	125352
	pump-app	LP_EM_CC1354P10_6	FLASH	771080	771080
			RAM	113724	113724
	pump-controller-app	LP_EM_CC1354P10_6	FLASH	755364	755364
			RAM	113932	113932
cc32xx	air-purifier	CC3235SF_LAUNCHXL	FLASH	538842	538842
			RAM	205112	205112
	lock	CC3235SF_LAUNCHXL	FLASH	572998	572998
			RAM	205360	205360
cyw30739	light	CYW30739B2-P5-EVK-01	unknown	2040	2040
			FLASH	656429	656429
			RAM	75324	75324
		CYW30739B2-P5-EVK-02	unknown	2040	2040
			FLASH	676289	676289
			RAM	77964	77964
		CYW30739B2-P5-EVK-03	unknown	2040	2040
			FLASH	676289	676289
			RAM	77964	77964
		CYW930739M2EVB-02	unknown	2040	2040
			FLASH	633213	633213
			RAM	70392	70392
	light-switch	CYW30739B2-P5-EVK-01	unknown	2040	2040
			FLASH	616293	616293
			RAM	71532	71532
		CYW30739B2-P5-EVK-02	unknown	2040	2040
			FLASH	635929	635929
			RAM	74076	74076
		CYW30739B2-P5-EVK-03	unknown	2040	2040
			FLASH	635929	635929
			RAM	74076	74076
	lock	CYW30739B2-P5-EVK-01	unknown	2040	2040
			FLASH	635789	635789
			RAM	74540	74540
		CYW30739B2-P5-EVK-02	unknown	2040	2040
			FLASH	655513	655513
			RAM	77084	77084
		CYW30739B2-P5-EVK-03	unknown	2040	2040
			FLASH	655513	655513
			RAM	77084	77084
	thermostat	CYW30739B2-P5-EVK-01	unknown	2040	2040
			FLASH	612137	612137
			RAM	68628	68628
		CYW30739B2-P5-EVK-02	unknown	2040	2040
			FLASH	631997	631997
			RAM	71268	71268
		CYW30739B2-P5-EVK-03	unknown	2040	2040
			FLASH	631997	631997
			RAM	71268	71268
efr32	lock-app	BRD4187C	FLASH	939536	939536
			RAM	159920	159920
		BRD4338a	FLASH	732536	732536
			RAM	234828	234828
	window-app	BRD4187C	FLASH	1032000	1032000
			RAM	128024	128024
esp32	all-clusters-app	c3devkit	DRAM	97312	97312
			FLASH	`1582004`	`1582004`
			IRAM	83820	83820
		m5stack	DRAM	116108	116108
			FLASH	1550014	1550014
			IRAM	117039	117039
linux	air-purifier-app	debug	unknown	4720	4720
			FLASH	2649887	2649887
			RAM	111088	111088
	all-clusters-app	debug	unknown	5528	5528
			FLASH	5921360	5921360
			RAM	513712	513712
	all-clusters-minimal-app	debug	unknown	5424	5424
			FLASH	5266394	5266394
			RAM	221112	221112
	bridge-app	debug	unknown	5440	5440
			FLASH	4625036	4625036
			RAM	199816	199816
	camera-app	debug	unknown	5424	5424
			FLASH	4671816	4671816
			RAM	194592	194592
	chip-tool	debug	unknown	6096	6096
			FLASH	13302351	13302351
			RAM	603392	603392
	chip-tool-ipv6only	arm64	unknown	21976	21976
			FLASH	11495416	11495416
			RAM	656112	656112
	fabric-admin	debug	unknown	5784	5784
			FLASH	11567249	11567249
			RAM	603176	603176
	fabric-bridge-app	debug	unknown	4688	4688
			FLASH	`4452254`	`4452254`
			RAM	187016	187016
	fabric-sync	debug	unknown	4944	4944
			FLASH	5569205	5569205
			RAM	470400	470400
	lighting-app	debug+rpc+ui	unknown	6152	6152
			FLASH	5515489	5515489
			RAM	203952	203952
	lock-app	debug	unknown	5392	5392
			FLASH	4688504	4688504
			RAM	191144	191144
	ota-provider-app	debug	unknown	4728	4728
			FLASH	`4310684`	`4310684`
			RAM	179832	179832
	ota-requestor-app	debug	unknown	4680	4680
			FLASH	4440810	4440810
			RAM	184320	184320
	shell	debug	unknown	4216	4216
			FLASH	2949196	2949196
			RAM	143672	143672
	thermostat-no-ble	arm64	unknown	9448	9448
			FLASH	4138392	4138392
			RAM	229016	229016
	tv-app	debug	unknown	5720	5720
			FLASH	5908117	5908117
			RAM	593832	593832
	tv-casting-app	debug	unknown	5296	5296
			FLASH	11472829	11472829
			RAM	718656	718656
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	FLASH	907708	907708
			RAM	142323	142323
		nrf7002dk_nrf5340_cpuapp	FLASH	901788	901788
			RAM	124663	124663
	all-clusters-minimal-app	nrf52840dk_nrf52840	FLASH	846312	846312
			RAM	141251	141251
nxp	contact	k32w0+release	FLASH	585256	585256
			RAM	70876	70876
		mcxw71+release	FLASH	600712	600712
			RAM	63096	63096
	light	k32w0+release	FLASH	611196	611196
			RAM	70164	70164
		k32w1+release	FLASH	685680	685680
			RAM	48584	48584
	lock	mcxw71+release	FLASH	749536	749536
			RAM	67500	67500
psoc6	all-clusters	cy8ckit_062s2_43012	FLASH	1646188	1646188
			RAM	211472	211472
	all-clusters-minimal	cy8ckit_062s2_43012	FLASH	1552956	1552956
			RAM	208288	208288
	light	cy8ckit_062s2_43012	FLASH	1438644	1438644
			RAM	197040	197040
	lock	cy8ckit_062s2_43012	FLASH	1467516	1467516
			RAM	224704	224704
qpg	lighting-app	qpg6105+debug	FLASH	662188	662188
			RAM	105116	105116
	lock-app	qpg6105+debug	FLASH	620304	620304
			RAM	99664	99664
stm32	light	STM32WB5MM-DK	FLASH	459832	459832
			RAM	141472	141472
telink	bridge-app	tl7218x	FLASH	665034	665034
			RAM	90728	90728
	contact-sensor-app	tlsr9528a_retention	FLASH	622078	622078
			RAM	31488	31488
	light-app-ota-shell-factory-data	tl3218x	FLASH	745218	745218
			RAM	40396	40396
		tl7218x	FLASH	753780	753780
			RAM	97540	97540
	light-switch-app-ota-compress-lzma-factory-data	tl7218x_retention	FLASH	680850	680850
			RAM	52192	52192
	light-switch-app-ota-compress-lzma-shell-factory-data	tlsr9528a	FLASH	709412	709412
			RAM	73400	73400
	lighting-app-ota-factory-data	tlsr9118bdk40d	FLASH	600592	600592
			RAM	138812	138812
	lighting-app-ota-rpc-factory-data-4mb	tlsr9518adk80d	FLASH	788820	788820
			RAM	96388	96388
tizen	all-clusters-app	arm	unknown	5076	5076
			FLASH	`1750852`	`1750852`
			RAM	93260	93260
	chip-tool-ubsan	arm	unknown	11492	11492
			FLASH	18983694	18983694
			RAM	8306240	8306240

src/app/clusters/closure-control-server/closure-control-server.h

github-actions · 2025-02-27T18:11:03Z

PR #37561: Size comparison from e34015c to cece03e

Full report (1 build for stm32)

platform	target	config	section	`e34015c`	`cece03e`	change	% change
stm32	light	STM32WB5MM-DK	FLASH	459840	459840	0	0.0
			RAM	141472	141472	0	0.0

src/app/clusters/closure-control-server/closure-control-cluster-objects.h

src/app/clusters/closure-control-server/closure-control-server.h

…oved from spec

src/app/clusters/closure-control-server/closure-control-server.h

github-actions · 2025-02-27T21:21:18Z

PR #37561: Size comparison from 67bedcd to 4ab2e09

Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)

platform	target	config	section	`67bedcd`	`4ab2e09`
bl602	lighting-app	bl602+mfd+littlefs+rpc	FLASH	1096892	1096892
			RAM	94842	94842
bl702	lighting-app	bl702+eth	FLASH	651870	651870
			RAM	33509	33509
		bl702+wifi	FLASH	829142	829142
			RAM	22233	22233
		bl706+mfd+rpc+littlefs	FLASH	1061538	1061538
			RAM	32157	32157
bl702l	contact-sensor-app	bl702l+mfd+littlefs	FLASH	892382	892382
			RAM	26896	26896
	lighting-app	bl702l+mfd+littlefs	FLASH	975278	975278
			RAM	24644	24644
cc13x4_26x4	lighting-app	LP_EM_CC1354P10_6	FLASH	817152	817152
			RAM	120272	120272
	lock-ftd	LP_EM_CC1354P10_6	FLASH	826072	826072
			RAM	125368	125368
	pump-app	LP_EM_CC1354P10_6	FLASH	772956	772956
			RAM	113740	113740
	pump-controller-app	LP_EM_CC1354P10_6	FLASH	757240	757240
			RAM	113948	113948
cc32xx	air-purifier	CC3235SF_LAUNCHXL	FLASH	540646	540646
			RAM	205128	205128
	lock	CC3235SF_LAUNCHXL	FLASH	574794	574794
			RAM	205376	205376
cyw30739	light	CYW30739B2-P5-EVK-01	unknown	2040	2040
			FLASH	658861	658861
			RAM	75412	75412
		CYW30739B2-P5-EVK-02	unknown	2040	2040
			FLASH	678713	678713
			RAM	78052	78052
		CYW30739B2-P5-EVK-03	unknown	2040	2040
			FLASH	678713	678713
			RAM	78052	78052
		CYW930739M2EVB-02	unknown	2040	2040
			FLASH	635645	635645
			RAM	70480	70480
	light-switch	CYW30739B2-P5-EVK-01	unknown	2040	2040
			FLASH	619101	619101
			RAM	71652	71652
		CYW30739B2-P5-EVK-02	unknown	2040	2040
			FLASH	638737	638737
			RAM	74196	74196
		CYW30739B2-P5-EVK-03	unknown	2040	2040
			FLASH	638737	638737
			RAM	74196	74196
	lock	CYW30739B2-P5-EVK-01	unknown	2040	2040
			FLASH	638589	638589
			RAM	74660	74660
		CYW30739B2-P5-EVK-02	unknown	2040	2040
			FLASH	658305	658305
			RAM	77204	77204
		CYW30739B2-P5-EVK-03	unknown	2040	2040
			FLASH	658305	658305
			RAM	77204	77204
	thermostat	CYW30739B2-P5-EVK-01	unknown	2040	2040
			FLASH	614937	614937
			RAM	68748	68748
		CYW30739B2-P5-EVK-02	unknown	2040	2040
			FLASH	634789	634789
			RAM	71388	71388
		CYW30739B2-P5-EVK-03	unknown	2040	2040
			FLASH	634789	634789
			RAM	71388	71388
efr32	lock-app	BRD4187C	FLASH	939672	939672
			RAM	159920	159920
		BRD4338a	FLASH	732656	732656
			RAM	234828	234828
	window-app	BRD4187C	FLASH	1032104	1032104
			RAM	128024	128024
esp32	all-clusters-app	c3devkit	DRAM	98736	98736
			FLASH	1591682	1591682
			IRAM	83820	83820
		m5stack	DRAM	117516	117516
			FLASH	1558478	1558478
			IRAM	117039	117039
linux	air-purifier-app	debug	unknown	4752	4752
			FLASH	2653237	2653237
			RAM	112272	112272
	all-clusters-app	debug	unknown	5560	5560
			FLASH	5973656	5973656
			RAM	516536	516536
	all-clusters-minimal-app	debug	unknown	5456	5456
			FLASH	5299722	5299722
			RAM	222456	222456
	bridge-app	debug	unknown	5472	5472
			FLASH	4652070	4652070
			RAM	201328	201328
	camera-app	debug	unknown	5456	5456
			FLASH	4675206	4675206
			RAM	195776	195776
	chip-tool	debug	unknown	6112	6112
			FLASH	13304951	13304951
			RAM	603424	603424
	chip-tool-ipv6only	arm64	unknown	21976	21976
			FLASH	11497864	11497864
			RAM	656128	656128
	fabric-admin	debug	unknown	5800	5800
			FLASH	11569745	11569745
			RAM	603208	603208
	fabric-bridge-app	debug	unknown	4720	4720
			FLASH	4455636	4455636
			RAM	188168	188168
	fabric-sync	debug	unknown	4976	4976
			FLASH	`5572629`	`5572629`
			RAM	471584	471584
	lighting-app	debug+rpc+ui	unknown	6184	6184
			FLASH	5518913	5518913
			RAM	205136	205136
	lock-app	debug	unknown	5424	5424
			FLASH	4691888	4691888
			RAM	192328	192328
	ota-provider-app	debug	unknown	4760	4760
			FLASH	4314098	4314098
			RAM	180984	180984
	ota-requestor-app	debug	unknown	4712	4712
			FLASH	`4444418`	`4444418`
			RAM	185472	185472
	shell	debug	unknown	4240	4240
			FLASH	2982268	2982268
			RAM	145688	145688
	thermostat-no-ble	arm64	unknown	9448	9448
			FLASH	4141656	4141656
			RAM	229832	229832
	tv-app	debug	unknown	5752	5752
			FLASH	5911477	5911477
			RAM	595016	595016
	tv-casting-app	debug	unknown	5320	5320
			FLASH	11475437	11475437
			RAM	718656	718656
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	FLASH	913576	913576
			RAM	142909	142909
		nrf7002dk_nrf5340_cpuapp	FLASH	904304	904304
			RAM	125245	125245
	all-clusters-minimal-app	nrf52840dk_nrf52840	FLASH	850424	850424
			RAM	141271	141271
nxp	contact	k32w0+release	FLASH	587368	587368
			RAM	70980	70980
		mcxw71+release	FLASH	601192	601192
			RAM	63096	63096
	light	k32w0+release	FLASH	613100	613100
			RAM	70268	70268
		k32w1+release	FLASH	685824	685824
			RAM	48584	48584
	lock	mcxw71+release	FLASH	750032	750032
			RAM	67500	67500
psoc6	all-clusters	cy8ckit_062s2_43012	FLASH	1658100	1658100
			RAM	212344	212344
	all-clusters-minimal	cy8ckit_062s2_43012	FLASH	1562380	1562380
			RAM	208560	208560
	light	cy8ckit_062s2_43012	FLASH	1441180	1441180
			RAM	197296	197296
	lock	cy8ckit_062s2_43012	FLASH	1470068	1470068
			RAM	224960	224960
qpg	lighting-app	qpg6105+debug	FLASH	663772	663772
			RAM	105156	105156
	lock-app	qpg6105+debug	FLASH	622240	622240
			RAM	99768	99768
stm32	light	STM32WB5MM-DK	FLASH	459840	459840
			RAM	141472	141472
telink	bridge-app	tl7218x	FLASH	669192	669192
			RAM	90752	90752
	contact-sensor-app	tlsr9528a_retention	FLASH	622078	622078
			RAM	31488	31488
	light-app-ota-shell-factory-data	tl3218x	FLASH	745386	745386
			RAM	40396	40396
		tl7218x	FLASH	753948	753948
			RAM	97540	97540
	light-switch-app-ota-compress-lzma-factory-data	tl7218x_retention	FLASH	681018	681018
			RAM	52192	52192
	light-switch-app-ota-compress-lzma-shell-factory-data	tlsr9528a	FLASH	709580	709580
			RAM	73400	73400
	lighting-app-ota-factory-data	tlsr9118bdk40d	FLASH	600760	600760
			RAM	138812	138812
	lighting-app-ota-rpc-factory-data-4mb	tlsr9518adk80d	FLASH	788988	788988
			RAM	96388	96388
tizen	all-clusters-app	arm	unknown	5144	5144
			FLASH	1770580	1770580
			RAM	94144	94144
	chip-tool-ubsan	arm	unknown	11492	11492
			FLASH	18983958	18983958
			RAM	8306328	8306328

* Closure control sluster Server Code * Restyled by whitespace * Restyled by clang-format * Changing MainState and Countdowntime Implementation * Handling OverallState and OverallTarget from Instance * Addressing PR comments * Restyled by whitespace * Restyled by clang-format * Updating missing zap changes * Adding wrapper for struct handling * Restyled by whitespace * Restyled by clang-format * Addressing PR comments * Addressing PR comments * Restyled by clang-format * addressing PR comments * changing IsEqual to operator== * Addressing PR comments * Addresssing PR comments * Removing Fallback feature attribute and commands as FB feature is removed from spec * Addressing PR comments * Updating countdonwtime quiet reporting policy * Restyled by whitespace * Restyled by clang-format --------- Co-authored-by: sabollim <satyanaag.bollimpalli@silabs.com> Co-authored-by: Restyled.io <commits@restyled.io>

Closure control sluster Server Code

acc7a7d

sabollim-silabs marked this pull request as draft February 13, 2025 18:08

github-actions bot added the app label Feb 13, 2025

Merge branch 'project-chip:master' into feature/closure_control_serve…

651fb3b

…r_code

jmartinez-silabs reviewed Feb 14, 2025

View reviewed changes

src/app/clusters/closure-control-server/closure-control-server.cpp Outdated Show resolved Hide resolved

jmartinez-silabs approved these changes Feb 14, 2025

View reviewed changes

bzbarsky-apple requested changes Feb 15, 2025

View reviewed changes

src/app/clusters/closure-control-server/closure-control-server.h Outdated Show resolved Hide resolved

sabollim-silabs and others added 3 commits February 17, 2025 15:01

Merge branch 'project-chip:master' into feature/closure_control_serve…

83d5671

…r_code

Restyled by whitespace

88785ee

Restyled by clang-format

236a68b

Changing MainState and Countdowntime Implementation

280df4f

sabollim-silabs changed the title ~~Closure control cluster server code implementation~~ [WIP] Closure control cluster server code implementation Feb 18, 2025

mergify bot added the conflict label Feb 18, 2025

satyanaag-silabs and others added 2 commits February 19, 2025 00:15

Handling OverallState and OverallTarget from Instance

2e82a85

Merge branch 'master' into feature/closure_control_server_code

1e81e1d

mergify bot removed the conflict label Feb 18, 2025

Addressing PR comments

c230a1d

sabollim-silabs requested a review from jmartinez-silabs February 18, 2025 19:28

sabollim-silabs changed the title ~~[WIP] Closure control cluster server code implementation~~ Closure control cluster server code implementation Feb 18, 2025

restyled-commits added 2 commits February 19, 2025 01:02

Restyled by whitespace

bccbebe

Restyled by clang-format

5c130df

jmartinez-silabs reviewed Feb 18, 2025

View reviewed changes

src/app/clusters/closure-control-server/closure-control-server.cpp Outdated Show resolved Hide resolved

senthilku approved these changes Feb 19, 2025

View reviewed changes

sabollim-silabs requested a review from bzbarsky-apple February 19, 2025 07:39

Merge branch 'master' into feature/closure_control_server_code

ac42399

sabollim-silabs mentioned this pull request Feb 25, 2025

Initial closure sample app for 917SoC #37752

Merged

bzbarsky-apple requested changes Feb 25, 2025

View reviewed changes

src/app/clusters/closure-control-server/closure-control-server.h Show resolved Hide resolved

satyanaag-silabs added 2 commits February 26, 2025 03:15

addressing PR comments

bd5a0a5

changing IsEqual to operator==

afae064

sabollim-silabs requested a review from bzbarsky-apple February 26, 2025 10:26

mergify bot added the conflict label Feb 26, 2025

Merge branch 'master' into feature/closure_control_server_code

270be8e

mergify bot removed the conflict label Feb 26, 2025

sabollim-silabs added 2 commits February 27, 2025 20:06

Merge branch 'master' into feature/closure_control_server_code

0e4a00d

Merge branch 'master' into feature/closure_control_server_code

cece03e

bzbarsky-apple reviewed Feb 27, 2025

View reviewed changes

satyanaag-silabs added 4 commits February 28, 2025 01:22

Addressing PR comments

ba8d87c

Addresssing PR comments

408c94d

Removing Fallback feature attribute and commands as FB feature is rem…

b4f685e

…oved from spec

Addressing PR comments

5f8858c

bzbarsky-apple approved these changes Feb 27, 2025

View reviewed changes

src/app/clusters/closure-control-server/closure-control-server.h Show resolved Hide resolved

pullapprove bot added review - approved and removed review - pending labels Feb 27, 2025

satyanaag-silabs and others added 5 commits February 28, 2025 02:29

Updating countdonwtime quiet reporting policy

c282599

Merge branch 'master' into feature/closure_control_server_code

f5f9fed

Restyled by whitespace

acb1c5b

Restyled by clang-format

a1766e6

Merge branch 'master' into feature/closure_control_server_code

4ab2e09

mergify bot merged commit 28c1d83 into project-chip:master Feb 27, 2025
70 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Closure control cluster server code implementation #37561

Closure control cluster server code implementation #37561

sabollim-silabs commented Feb 13, 2025 •

edited

Loading

semanticdiff-com bot commented Feb 13, 2025 •

edited

Loading

github-actions bot commented Feb 13, 2025

github-actions bot commented Feb 14, 2025

github-actions bot commented Feb 17, 2025 •

edited

Loading

github-actions bot commented Feb 17, 2025

github-actions bot commented Feb 18, 2025

github-actions bot commented Feb 25, 2025 •

edited

Loading

github-actions bot commented Feb 25, 2025 •

edited

Loading

github-actions bot commented Feb 27, 2025

github-actions bot commented Feb 27, 2025 •

edited

Loading

Closure control cluster server code implementation #37561

Closure control cluster server code implementation #37561

Conversation

sabollim-silabs commented Feb 13, 2025 • edited Loading

Testing

semanticdiff-com bot commented Feb 13, 2025 • edited Loading

github-actions bot commented Feb 13, 2025

github-actions bot commented Feb 14, 2025

github-actions bot commented Feb 17, 2025 • edited Loading

github-actions bot commented Feb 17, 2025

github-actions bot commented Feb 18, 2025

github-actions bot commented Feb 25, 2025 • edited Loading

github-actions bot commented Feb 25, 2025 • edited Loading

github-actions bot commented Feb 27, 2025

github-actions bot commented Feb 27, 2025 • edited Loading

sabollim-silabs commented Feb 13, 2025 •

edited

Loading

semanticdiff-com bot commented Feb 13, 2025 •

edited

Loading

github-actions bot commented Feb 17, 2025 •

edited

Loading

github-actions bot commented Feb 25, 2025 •

edited

Loading

github-actions bot commented Feb 25, 2025 •

edited

Loading

github-actions bot commented Feb 27, 2025 •

edited

Loading