-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial closure sample app for 917SoC #37752
Initial closure sample app for 917SoC #37752
Conversation
server code is included in this branch. will be removed once we rebase with master when server code is commited into master |
PR #37752: Size comparison from 9298ce7 to 1fa6088 Full report (3 builds for cc32xx, stm32)
|
src/app/clusters/closure-control-server/closure-control-cluster-objects.h
Outdated
Show resolved
Hide resolved
src/app/clusters/closure-control-server/closure-control-cluster-objects.h
Outdated
Show resolved
Hide resolved
src/app/clusters/closure-control-server/closure-control-cluster-objects.h
Outdated
Show resolved
Hide resolved
src/app/clusters/closure-control-server/closure-control-cluster-objects.h
Outdated
Show resolved
Hide resolved
src/app/clusters/closure-control-server/closure-control-server.h
Outdated
Show resolved
Hide resolved
src/app/clusters/closure-control-server/closure-control-server.h
Outdated
Show resolved
Hide resolved
src/app/clusters/closure-control-server/closure-control-server.h
Outdated
Show resolved
Hide resolved
src/app/clusters/closure-control-server/closure-control-server.h
Outdated
Show resolved
Hide resolved
src/app/clusters/closure-control-server/closure-control-server.h
Outdated
Show resolved
Hide resolved
src/app/clusters/closure-control-server/closure-control-server.cpp
Outdated
Show resolved
Hide resolved
1fa6088
to
65a35ba
Compare
PR #37752: Size comparison from 5e10345 to 65a35ba Full report (3 builds for cc32xx, stm32)
|
examples/closure-app/closure-common/common/include/ClosureAppCommonMain.h
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not review the Cluster server code. I will re-review it on the specific PR you already have open for that.
examples/closure-app/closure-common/closure-control/include/ClosureControlDelegate.h
Outdated
Show resolved
Hide resolved
examples/closure-app/closure-common/closure-control/include/ClosureControlMain.h
Show resolved
Hide resolved
93866a3
to
3bfa214
Compare
d5eaf11
to
7e48959
Compare
Removed server code changes from this PR |
PR #37752: Size comparison from 78e5932 to 41b89bd Full report (3 builds for cc32xx, stm32)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I skimmed over the silabs-specific parts; not really qualified to review those.
examples/closure-app/closure-common/closure-control/src/ClosureControlDelegateImpl.cpp
Outdated
Show resolved
Hide resolved
…eControlDelegateImpl.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
PR #37752: Size comparison from 649c341 to 71b9bc3 Full report (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
* Basic closure sample app with closure control server * Adding README file and renaming callback file * Restyled by whitespace * Restyled by clang-format * Restyled by gn * Restyled by prettier-json * Restyled by prettier-markdown * Updating sample app as per server code changes * addressing PR comments * Adding closure README to docs * enabling lcd and qrcode generation in lcd * removing unintended tab changes and default values added during rebase * Addressing PR comments * Update examples/closure-app/closure-common/closure-control/src/ClosureControlDelegateImpl.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * addressing PR comments * Restyled by whitespace * Restyled by prettier-markdown * corecting lint workflow identified errors * corecting lint workflow identified errors --------- Co-authored-by: sabollim <satyanaag.bollimpalli@silabs.com> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
This PR contains a basic implementation of the closure sample app which includes rootnode as ep0 and closure base as ep1,
will be able to commission over wifi, populate ep1 with closure-control cluster ,give appropriate values for global attributes and return default values for closure control attributes and default success for closure control commands.
Attributes, Commands, and Events handling will be taken up in later PRs
Testing
[1740415369.750] [161165:161167] [TOO] Endpoint: 1 Cluster: 0x0000_001D Attribute 0x0000_0001 DataVersion: 2472008
[1740415369.750] [161165:161167] [TOO] ServerList: 4 entries
[1740415369.750] [161165:161167] [TOO] [1]: 3 (Identify)
[1740415369.750] [161165:161167] [TOO] [2]: 4 (Groups)
[1740415369.750] [161165:161167] [TOO] [3]: 29 (Descriptor)
[1740415369.750] [161165:161167] [TOO] [4]: 260 (ClosureControl)
[1740415387.214] [161266:161274] [TOO] Endpoint: 1 Cluster: 0x0000_0104 Attribute 0x0000_FFFB DataVersion: 2407918899
[1740415387.214] [161266:161274] [TOO] AttributeList: 9 entries
[1740415387.215] [161266:161274] [TOO] [1]: 1 (MainState)
[1740415387.215] [161266:161274] [TOO] [2]: 2 (CurrentErrorList)
[1740415387.215] [161266:161274] [TOO] [3]: 3 (OverallState)
[1740415387.215] [161266:161274] [TOO] [4]: 4 (OverallTarget)
[1740415387.215] [161266:161274] [TOO] [5]: 65532 (FeatureMap)
[1740415387.215] [161266:161274] [TOO] [6]: 65533 (ClusterRevision)
[1740415387.215] [161266:161274] [TOO] [7]: 65528 (GeneratedCommandList)
[1740415387.215] [161266:161274] [TOO] [8]: 65529 (AcceptedCommandList)
[1740415387.215] [161266:161274] [TOO] [9]: 65531 (AttributeList)
###########
Adding closure control cluster server code PR for reference:
#37561