Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial closure sample app for 917SoC #37752

Merged

Conversation

sabollim-silabs
Copy link
Contributor

@sabollim-silabs sabollim-silabs commented Feb 24, 2025

This PR contains a basic implementation of the closure sample app which includes rootnode as ep0 and closure base as ep1,
will be able to commission over wifi, populate ep1 with closure-control cluster ,give appropriate values for global attributes and return default values for closure control attributes and default success for closure control commands.

Attributes, Commands, and Events handling will be taken up in later PRs

Testing

  1. built app for 917. - Success
  2. commission with chiptool. - Success
  3. check server-list on Ep1 -Success

[1740415369.750] [161165:161167] [TOO] Endpoint: 1 Cluster: 0x0000_001D Attribute 0x0000_0001 DataVersion: 2472008
[1740415369.750] [161165:161167] [TOO] ServerList: 4 entries
[1740415369.750] [161165:161167] [TOO] [1]: 3 (Identify)
[1740415369.750] [161165:161167] [TOO] [2]: 4 (Groups)
[1740415369.750] [161165:161167] [TOO] [3]: 29 (Descriptor)
[1740415369.750] [161165:161167] [TOO] [4]: 260 (ClosureControl)

  1. check attribute list on Ep1 -Success

[1740415387.214] [161266:161274] [TOO] Endpoint: 1 Cluster: 0x0000_0104 Attribute 0x0000_FFFB DataVersion: 2407918899
[1740415387.214] [161266:161274] [TOO] AttributeList: 9 entries
[1740415387.215] [161266:161274] [TOO] [1]: 1 (MainState)
[1740415387.215] [161266:161274] [TOO] [2]: 2 (CurrentErrorList)
[1740415387.215] [161266:161274] [TOO] [3]: 3 (OverallState)
[1740415387.215] [161266:161274] [TOO] [4]: 4 (OverallTarget)
[1740415387.215] [161266:161274] [TOO] [5]: 65532 (FeatureMap)
[1740415387.215] [161266:161274] [TOO] [6]: 65533 (ClusterRevision)
[1740415387.215] [161266:161274] [TOO] [7]: 65528 (GeneratedCommandList)
[1740415387.215] [161266:161274] [TOO] [8]: 65529 (AcceptedCommandList)
[1740415387.215] [161266:161274] [TOO] [9]: 65531 (AttributeList)

###########
Adding closure control cluster server code PR for reference:
#37561

@sabollim-silabs sabollim-silabs requested a review from a team as a code owner February 24, 2025 16:44
@sabollim-silabs sabollim-silabs marked this pull request as draft February 24, 2025 16:44
Copy link

semanticdiff-com bot commented Feb 24, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  src/app/zap_cluster_list.json  97% smaller
  docs/examples/closure.md Unsupported file format
  examples/closure-app/closure-common/BUILD.gn Unsupported file format
  examples/closure-app/closure-common/closure-app.matter Unsupported file format
  examples/closure-app/closure-common/closure-app.zap Unsupported file format
  examples/closure-app/closure-common/closure-control/include/ClosureControlDelegate.h Unsupported file format
  examples/closure-app/closure-common/closure-control/include/ClosureControlInstance.h Unsupported file format
  examples/closure-app/closure-common/closure-control/include/ClosureControlMain.h Unsupported file format
  examples/closure-app/closure-common/closure-control/src/ClosureControlDelegateImpl.cpp Unsupported file format
  examples/closure-app/closure-common/closure-control/src/ClosureControlInstance.cpp Unsupported file format
  examples/closure-app/closure-common/closure-control/src/ClosureControlMain.cpp Unsupported file format
  examples/closure-app/closure-common/common/include/ClosureAppCommonMain.h Unsupported file format
  examples/closure-app/closure-common/common/src/ClosureAppCommonMain.cpp Unsupported file format
  examples/closure-app/silabs/.gn Unsupported file format
  examples/closure-app/silabs/BUILD.gn Unsupported file format
  examples/closure-app/silabs/README.md Unsupported file format
  examples/closure-app/silabs/build_for_wifi_args.gni Unsupported file format
  examples/closure-app/silabs/build_for_wifi_gnfile.gn Unsupported file format
  examples/closure-app/silabs/build_overrides  0% smaller
  examples/closure-app/silabs/include/AppConfig.h Unsupported file format
  examples/closure-app/silabs/include/AppEvent.h Unsupported file format
  examples/closure-app/silabs/include/AppTask.h Unsupported file format
  examples/closure-app/silabs/include/CHIPProjectConfig.h Unsupported file format
  examples/closure-app/silabs/openthread.gn Unsupported file format
  examples/closure-app/silabs/openthread.gni Unsupported file format
  examples/closure-app/silabs/src/AppTask.cpp Unsupported file format
  examples/closure-app/silabs/src/DataModelCallbacks.cpp Unsupported file format
  examples/closure-app/silabs/third_party/connectedhomeip  0% smaller
  src/app/chip_data_model.gni Unsupported file format
  src/app/clusters/closure-control-server/closure-control-cluster-objects.h Unsupported file format
  src/app/clusters/closure-control-server/closure-control-server.cpp Unsupported file format
  src/app/clusters/closure-control-server/closure-control-server.h Unsupported file format
  src/app/common/templates/config-data.yaml  0% smaller
  zzz_generated/app-common/app-common/zap-generated/callback.h Unsupported file format

@sabollim-silabs
Copy link
Contributor Author

server code is included in this branch. will be removed once we rebase with master when server code is commited into master

@mergify mergify bot removed the conflict label Feb 24, 2025
Copy link

PR #37752: Size comparison from 7eab378 to 31b8b0a

Full report (1 build for stm32)
platform target config section 7eab378 31b8b0a change % change
stm32 light STM32WB5MM-DK FLASH 459800 459800 0 0.0
RAM 141472 141472 0 0.0

@sabollim-silabs sabollim-silabs changed the title [WIP] Feature/closure control sample app 917 [WIP] Intial closure sample app for 917SoC Feb 25, 2025
@sabollim-silabs sabollim-silabs changed the title [WIP] Intial closure sample app for 917SoC [WIP] Initial closure sample app for 917SoC Feb 25, 2025
Copy link

PR #37752: Size comparison from 9298ce7 to 56072b3

Full report (1 build for stm32)
platform target config section 9298ce7 56072b3 change % change
stm32 light STM32WB5MM-DK FLASH 459832 459832 0 0.0
RAM 141472 141472 0 0.0

@sabollim-silabs sabollim-silabs changed the title [WIP] Initial closure sample app for 917SoC Initial closure sample app for 917SoC Feb 25, 2025
Copy link

github-actions bot commented Feb 25, 2025

PR #37752: Size comparison from 9298ce7 to 1fa6088

Full report (3 builds for cc32xx, stm32)
platform target config section 9298ce7 1fa6088 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538842 538842 0 0.0
RAM 205112 205112 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572998 572998 0 0.0
RAM 205360 205360 0 0.0
stm32 light STM32WB5MM-DK FLASH 459832 459832 0 0.0
RAM 141472 141472 0 0.0

@sabollim-silabs sabollim-silabs changed the title Initial closure sample app for 917SoC [WIP] Initial closure sample app for 917SoC Feb 25, 2025
@sabollim-silabs sabollim-silabs force-pushed the feature/closure_control_sample_app_917 branch from 1fa6088 to 65a35ba Compare February 26, 2025 08:05
Copy link

PR #37752: Size comparison from 5e10345 to 65a35ba

Full report (3 builds for cc32xx, stm32)
platform target config section 5e10345 65a35ba change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538842 538842 0 0.0
RAM 205112 205112 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572998 572998 0 0.0
RAM 205360 205360 0 0.0
stm32 light STM32WB5MM-DK FLASH 459832 459832 0 0.0
RAM 141472 141472 0 0.0

Copy link
Member

@jmartinez-silabs jmartinez-silabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not review the Cluster server code. I will re-review it on the specific PR you already have open for that.

@mergify mergify bot removed the conflict label Feb 26, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 26, 2025
Copy link

PR #37752: Size comparison from a8e2ae5 to 0c97c50

Full report (1 build for stm32)
platform target config section a8e2ae5 0c97c50 change % change
stm32 light STM32WB5MM-DK FLASH 459832 459832 0 0.0
RAM 141472 141472 0 0.0

@sabollim-silabs sabollim-silabs changed the title [WIP] Initial closure sample app for 917SoC Initial closure sample app for 917SoC Feb 27, 2025
Copy link

PR #37752: Size comparison from a8e2ae5 to 930783e

Full report (1 build for stm32)
platform target config section a8e2ae5 930783e change % change
stm32 light STM32WB5MM-DK FLASH 459832 459840 8 0.0
RAM 141472 141472 0 0.0

@sabollim-silabs sabollim-silabs force-pushed the feature/closure_control_sample_app_917 branch from 93866a3 to 3bfa214 Compare February 27, 2025 15:55
Copy link

PR #37752: Size comparison from 78e5932 to 3bfa214

Full report (1 build for stm32)
platform target config section 78e5932 3bfa214 change % change
stm32 light STM32WB5MM-DK FLASH 459840 459840 0 0.0
RAM 141472 141472 0 0.0

@sabollim-silabs sabollim-silabs force-pushed the feature/closure_control_sample_app_917 branch from d5eaf11 to 7e48959 Compare February 27, 2025 16:11
@sabollim-silabs
Copy link
Contributor Author

I approve for the examples/closure-app portion of the pr. The added code coming from #37561 shall be removed now. Lets keep it separate so reviews are not duplicated. The app is not added to the CI yet anyway.

Removed server code changes from this PR

Copy link

PR #37752: Size comparison from 78e5932 to 41b89bd

Full report (3 builds for cc32xx, stm32)
platform target config section 78e5932 41b89bd change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 540646 540646 0 0.0
RAM 205128 205128 0 0.0
lock CC3235SF_LAUNCHXL FLASH 574794 574794 0 0.0
RAM 205376 205376 0 0.0
stm32 light STM32WB5MM-DK FLASH 459840 459840 0 0.0
RAM 141472 141472 0 0.0

@sabollim-silabs sabollim-silabs marked this pull request as ready for review February 27, 2025 17:44
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed over the silabs-specific parts; not really qualified to review those.

Copy link

github-actions bot commented Mar 1, 2025

PR #37752: Size comparison from 649c341 to 71b9bc3

Full report (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 649c341 71b9bc3 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1096862 1096862 0 0.0
RAM 94842 94842 0 0.0
bl702 lighting-app bl702+eth FLASH 651836 651836 0 0.0
RAM 33509 33509 0 0.0
bl702+wifi FLASH 829108 829108 0 0.0
RAM 22233 22233 0 0.0
bl706+mfd+rpc+littlefs FLASH 1061504 1061504 0 0.0
RAM 32157 32157 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 892348 892348 0 0.0
RAM 26896 26896 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 975244 975244 0 0.0
RAM 24644 24644 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 817216 817216 0 0.0
RAM 120272 120272 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 826136 826136 0 0.0
RAM 125368 125368 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 773020 773020 0 0.0
RAM 113740 113740 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 757296 757296 0 0.0
RAM 113948 113948 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 540758 540758 0 0.0
RAM 205128 205128 0 0.0
lock CC3235SF_LAUNCHXL FLASH 574882 574882 0 0.0
RAM 205376 205376 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 658933 658933 0 0.0
RAM 75412 75412 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 678785 678785 0 0.0
RAM 78052 78052 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 678785 678785 0 0.0
RAM 78052 78052 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 635717 635717 0 0.0
RAM 70480 70480 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 619173 619173 0 0.0
RAM 71652 71652 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 638809 638809 0 0.0
RAM 74196 74196 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 638809 638809 0 0.0
RAM 74196 74196 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 638661 638661 0 0.0
RAM 74660 74660 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 658377 658377 0 0.0
RAM 77204 77204 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 658377 658377 0 0.0
RAM 77204 77204 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 615001 615001 0 0.0
RAM 68748 68748 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634853 634853 0 0.0
RAM 71388 71388 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634853 634853 0 0.0
RAM 71388 71388 0 0.0
efr32 lock-app BRD4187C FLASH 939760 939760 0 0.0
RAM 159920 159920 0 0.0
BRD4338a FLASH 732744 732744 0 0.0
RAM 234828 234828 0 0.0
window-app BRD4187C FLASH 1032200 1032200 0 0.0
RAM 128024 128024 0 0.0
esp32 all-clusters-app c3devkit DRAM 98736 98736 0 0.0
FLASH 1591770 1591770 0 0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 117516 117516 0 0.0
FLASH 1558614 1558614 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4752 4752 0 0.0
FLASH 2653555 2653555 0 0.0
RAM 112304 112304 0 0.0
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 5973942 5973942 0 0.0
RAM 516568 516568 0 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5299944 5299944 0 0.0
RAM 222488 222488 0 0.0
bridge-app debug unknown 5472 5472 0 0.0
FLASH 4652292 4652292 0 0.0
RAM 201344 201344 0 0.0
camera-app debug unknown 5456 5456 0 0.0
FLASH 4675460 4675460 0 0.0
RAM 195792 195792 0 0.0
chip-tool debug unknown 6112 6112 0 0.0
FLASH 13305205 13305205 0 0.0
RAM 603456 603456 0 0.0
chip-tool-ipv6only arm64 unknown 21976 21976 0 0.0
FLASH 11498088 11498088 0 0.0
RAM 656136 656136 0 0.0
fabric-admin debug unknown 5800 5800 0 0.0
FLASH 11569967 11569967 0 0.0
RAM 603240 603240 0 0.0
fabric-bridge-app debug unknown 4720 4720 0 0.0
FLASH 4455890 4455890 0 0.0
RAM 188168 188168 0 0.0
fabric-sync debug unknown 4976 4976 0 0.0
FLASH 5572837 5572837 0 0.0
RAM 471600 471600 0 0.0
lighting-app debug+rpc+ui unknown 6184 6184 0 0.0
FLASH 5519105 5519105 0 0.0
RAM 205168 205168 0 0.0
lock-app debug unknown 5424 5424 0 0.0
FLASH 4692142 4692142 0 0.0
RAM 192344 192344 0 0.0
ota-provider-app debug unknown 4760 4760 0 0.0
FLASH 4314320 4314320 0 0.0
RAM 181000 181000 0 0.0
ota-requestor-app debug unknown 4712 4712 0 0.0
FLASH 4444672 4444672 0 0.0
RAM 185488 185488 0 0.0
shell debug unknown 4240 4240 0 0.0
FLASH 2982540 2982540 0 0.0
RAM 145688 145688 0 0.0
thermostat-no-ble arm64 unknown 9448 9448 0 0.0
FLASH 4141880 4141880 0 0.0
RAM 229840 229840 0 0.0
tv-app debug unknown 5752 5752 0 0.0
FLASH 5911717 5911717 0 0.0
RAM 595032 595032 0 0.0
tv-casting-app debug unknown 5320 5320 0 0.0
FLASH 11475693 11475693 0 0.0
RAM 718672 718672 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 913676 913676 0 0.0
RAM 142909 142909 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 904420 904420 0 0.0
RAM 125245 125245 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 850456 850456 0 0.0
RAM 141271 141271 0 0.0
nxp contact k32w0+release FLASH 587440 587440 0 0.0
RAM 70980 70980 0 0.0
mcxw71+release FLASH 601264 601264 0 0.0
RAM 63096 63096 0 0.0
light k32w0+release FLASH 613172 613172 0 0.0
RAM 70268 70268 0 0.0
k32w1+release FLASH 685888 685888 0 0.0
RAM 48584 48584 0 0.0
lock mcxw71+release FLASH 750096 750096 0 0.0
RAM 67500 67500 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1658220 1658220 0 0.0
RAM 212344 212344 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1562460 1562460 0 0.0
RAM 208560 208560 0 0.0
light cy8ckit_062s2_43012 FLASH 1441276 1441276 0 0.0
RAM 197296 197296 0 0.0
lock cy8ckit_062s2_43012 FLASH 1470164 1470164 0 0.0
RAM 224960 224960 0 0.0
qpg lighting-app qpg6105+debug FLASH 663836 663836 0 0.0
RAM 105156 105156 0 0.0
lock-app qpg6105+debug FLASH 622304 622304 0 0.0
RAM 99768 99768 0 0.0
stm32 light STM32WB5MM-DK FLASH 459904 459904 0 0.0
RAM 141472 141472 0 0.0
telink bridge-app tl7218x FLASH 669256 669256 0 0.0
RAM 90752 90752 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622118 622118 0 0.0
RAM 31488 31488 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 760904 760904 0 0.0
RAM 40420 40420 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 754012 754012 0 0.0
RAM 97540 97540 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 681062 681062 0 0.0
RAM 52192 52192 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709620 709620 0 0.0
RAM 73400 73400 0 0.0
light-switch-app-ota-shell-factory-data tl3218x_retention FLASH 702170 702170 0 0.0
RAM 37664 37664 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 601736 601736 0 0.0
RAM 137360 137360 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 789028 789028 0 0.0
RAM 96388 96388 0 0.0
tizen all-clusters-app arm unknown 5144 5144 0 0.0
FLASH 1770756 1770756 0 0.0
RAM 94152 94152 0 0.0
chip-tool-ubsan arm unknown 11492 11492 0 0.0
FLASH 18984862 18984862 0 0.0
RAM 8306668 8306668 0 0.0

@mergify mergify bot merged commit 2a97e64 into project-chip:master Mar 1, 2025
72 checks passed
gmarcosb pushed a commit to gmarcosb/connectedhomeip that referenced this pull request Mar 4, 2025
* Basic closure sample app with closure control server

* Adding README file and renaming callback file

* Restyled by whitespace

* Restyled by clang-format

* Restyled by gn

* Restyled by prettier-json

* Restyled by prettier-markdown

* Updating sample app as per server code changes

* addressing PR comments

* Adding closure README to docs

* enabling lcd and qrcode generation in lcd

* removing unintended tab changes and default values added during rebase

* Addressing PR comments

* Update examples/closure-app/closure-common/closure-control/src/ClosureControlDelegateImpl.cpp

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* addressing PR comments

* Restyled by whitespace

* Restyled by prettier-markdown

* corecting lint workflow identified errors

* corecting lint workflow identified errors

---------

Co-authored-by: sabollim <satyanaag.bollimpalli@silabs.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app documentation Improvements or additions to documentation examples review - approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants