[ESP32]: Added the missing ble_store_config_init api to fix ble_bonding #37705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
shripad621git
force-pushed
the
fix/ble_bonding
branch
from
b4f4df4 to
655b227
Compare
shubhamdp
reviewed
Feb 21, 2025
shubhamdp
approved these changes
Feb 21, 2025
|
PR #37705: Size comparison from 06edeee to 655b227 Increases above 0.2%:
Full report (52 builds for bl602, bl702, bl702l, cc13x4_26x4, efr32, esp32, linux, nrfconnect, nxp, qpg, stm32, telink, tizen)
|
shripad621git
force-pushed
the
fix/ble_bonding
branch
from
655b227 to
ec33798
Compare
|
PR #37705: Size comparison from 0d6b2fb to ec33798 Increases above 0.2%:
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yunhanw-google
approved these changes
Feb 26, 2025
shripad621git
added a commit
to shripad621git/connectedhomeip
that referenced
this pull request
Feb 27, 2025
andy31415
pushed a commit
that referenced
this pull request
Feb 27, 2025
* [ESP32]: Added the missing ble_store_config_init api to fix ble_bonding (#37705) * [ESP32]: Fixed the crash due to ble_hs_is_enabled check bypass (#37354) * [ESP32]: Fixed the bluedroid commissioning with latest chip-tool (#37786) - Added the indicate flag instead of notify as per spec in bluedroid implementation. - Fixes the commissioning failure due to "No valid C2" error.
gmarcosb
pushed a commit
to gmarcosb/connectedhomeip
that referenced
this pull request
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The ble bonding fails when tried with nrfconnect app due to missing ble_store_config_init api in the flow.
Change Overview
Added the missing ble_store_config_init api in the implementation.
Testing
Tested the ble_bonding with nrfconnect app before and after the change.