[Telink] Update Docker image (Zephyr 3.3 & 3.7 support) #37852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
|
PR #37852: Size comparison from bb1f2db to a0bf858 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Mar 3, 2025
| @@ -39,6 +40,8 @@ COPY --from=psoc6 /opt/Tools/ModusToolbox /opt/Tools/ModusToolbox | |||
|
|
|||
| COPY --from=telink /opt/telink/zephyrproject /opt/telink/zephyrproject | |||
| COPY --from=telink /opt/telink/zephyr-sdk-0.17.0 /opt/telink/zephyr-sdk-0.17.0 | |||
| COPY --from=telink-zephyr_3_3 /opt/telink/zephyrproject /opt/telink/zephyrproject | |||
| COPY --from=telink-zephyr_3_3 /opt/telink/zephyr-sdk-0.17.0 /opt/telink/zephyr-sdk-0.17.0 | |||
There was a problem hiding this comment.
is this not the same as line 41/42? How do we merge these?
Maybe paths should be different in both images
There was a problem hiding this comment.
is this not the same as line 41/42? How do we merge these?
Maybe paths should be different in both images
paths of zephyr-sdk and zephyr are the same in both Dockers (versions)
zephyr-sdk-0.17.0 - is fully same for both versions
zephyrproject - is different (but with same path) with different versions of Zephyr
Generally I'm not sure if we need to add this lines, but I see COPY --from=telink which mean image_name and as a result I made a copy for other image.
There was a problem hiding this comment.
I understood mistake and will rework this part
There was a problem hiding this comment.
@andy31415
The best approach is to avoid including the old Zephyr 3.3 version in the VSCode image (I removed in last commit change).
This version will be used for about one more year by some customers, but Telink and most customers typically use a local Zephyr setup instead of Docker or VSCode builds.
It's better to maintain consistent paths in both Telink Docker images for both Zephyr versions.
We need this Docker images for GitHub CI builds only.
|
PR #37852: Size comparison from bb1f2db to d494dd3 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Mar 4, 2025
gmarcosb
pushed a commit
to gmarcosb/connectedhomeip
that referenced
this pull request
Mar 4, 2025
…#37852) * [Telink] Update Docker image (Zephyr 3.3 & 3.7 support) * [Telink] Remove Telink Zephyr 3.3 from chip-build-vscode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change overview
Changes of N22 binary:
(latest hash 4d7b3e5962b9d34e28f7b24981ebac7e969b1115)
Testing
Tested manually.
Steps: