-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Telink] Update Docker image (Zephyr 3.3 & 3.7 support) #37852
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
120 : [NXP] Update NXP sdk version | ||
121 : [Telink] Update Docker image (Zephyr 3.3 & 3.7 support) |
48 changes: 48 additions & 0 deletions
48
integrations/docker/images/stage-2/chip-build-telink-zephyr_3_3/Dockerfile
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
ARG VERSION=1 | ||
FROM ghcr.io/project-chip/chip-build:${VERSION} as build | ||
LABEL org.opencontainers.image.source https://github.com/project-chip/connectedhomeip | ||
|
||
RUN set -x \ | ||
&& apt-get update \ | ||
&& DEBIAN_FRONTEND=noninteractive apt-get install -fy --no-install-recommends \ | ||
xz-utils \ | ||
&& : # last line | ||
|
||
# Setup toolchain | ||
WORKDIR /opt/telink | ||
RUN set -x \ | ||
&& curl --location https://github.com/zephyrproject-rtos/sdk-ng/releases/download/v0.17.0/zephyr-sdk-0.17.0_linux-x86_64_minimal.tar.xz --output zephyr-sdk-0.17.0_linux-x86_64_minimal.tar.xz \ | ||
&& tar xvf zephyr-sdk-0.17.0_linux-x86_64_minimal.tar.xz \ | ||
&& rm -rf zephyr-sdk-0.17.0_linux-x86_64_minimal.tar.xz \ | ||
&& zephyr-sdk-0.17.0/setup.sh -t riscv64-zephyr-elf \ | ||
&& : # last line | ||
|
||
# Setup Zephyr version: 3.3.0; branch: develop_3.3 | ||
ARG ZEPHYR_REVISION=fdccaba1ebc147908e9cca653e6c6743def3332b | ||
WORKDIR /opt/telink/zephyrproject | ||
RUN set -x \ | ||
&& python3 -m pip install --break-system-packages -U --no-cache-dir west \ | ||
&& git init zephyr \ | ||
&& cd zephyr \ | ||
&& git remote add origin https://github.com/telink-semi/zephyr \ | ||
&& git fetch --depth=1 origin ${ZEPHYR_REVISION} \ | ||
&& git reset ${ZEPHYR_REVISION} --hard \ | ||
&& west init -l \ | ||
&& west update -o=--depth=1 -n -f smart \ | ||
&& west blobs fetch hal_telink \ | ||
&& : # last line | ||
|
||
FROM ghcr.io/project-chip/chip-build:${VERSION} | ||
|
||
COPY --from=build /opt/telink/zephyr-sdk-0.17.0/ /opt/telink/zephyr-sdk-0.17.0/ | ||
COPY --from=build /opt/telink/zephyrproject/ /opt/telink/zephyrproject/ | ||
|
||
RUN set -x \ | ||
&& apt-get update \ | ||
&& apt-get clean \ | ||
&& rm -rf /var/lib/apt/lists/ \ | ||
&& pip3 install --break-system-packages --no-cache-dir --user -r /opt/telink/zephyrproject/zephyr/scripts/requirements.txt \ | ||
&& : # last line | ||
|
||
ENV TELINK_ZEPHYR_BASE=/opt/telink/zephyrproject/zephyr | ||
ENV TELINK_ZEPHYR_SDK_DIR=/opt/telink/zephyr-sdk-0.17.0 |
1 change: 1 addition & 0 deletions
1
integrations/docker/images/stage-2/chip-build-telink-zephyr_3_3/build.sh
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../../../build.sh |
1 change: 1 addition & 0 deletions
1
integrations/docker/images/stage-2/chip-build-telink-zephyr_3_3/run.sh
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../../../run.sh |
1 change: 1 addition & 0 deletions
1
integrations/docker/images/stage-2/chip-build-telink-zephyr_3_3/version
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../../base/chip-build/version |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this not the same as line 41/42? How do we merge these?
Maybe paths should be different in both images
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
paths of zephyr-sdk and zephyr are the same in both Dockers (versions)
zephyr-sdk-0.17.0 - is fully same for both versions
zephyrproject - is different (but with same path) with different versions of Zephyr
Generally I'm not sure if we need to add this lines, but I see
COPY --from=telink
which mean image_name and as a result I made a copy for other image.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understood mistake and will rework this part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andy31415
The best approach is to avoid including the old Zephyr 3.3 version in the VSCode image (I removed in last commit change).
This version will be used for about one more year by some customers, but Telink and most customers typically use a local Zephyr setup instead of Docker or VSCode builds.
It's better to maintain consistent paths in both Telink Docker images for both Zephyr versions.
We need this Docker images for GitHub CI builds only.