Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share common fabric-scoped table-like storage from SceneTableImpl #38073

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gmarcosb
Copy link
Contributor

Move functionality to a templatized class, chip::common::FabricTableImpl, to allow re-use in other clusters (specifically, TlsClientManagementServer)

Testing

Tested in CI

…to a templatized class, chip::common::FabricTableImpl, to allow re-use in other clusters (specifically, TlsClientManagementServer)
@gmarcosb gmarcosb force-pushed the camera-webrtc-server branch from 4ba315a to 9934b77 Compare March 19, 2025 19:58
@github-actions github-actions bot added the app label Mar 19, 2025
Copy link

PR #38073: Size comparison from 09dd3ac to c18aec4

Full report (3 builds for nrfconnect)
platform target config section 09dd3ac c18aec4 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 916444 917776 1332 0.1
RAM 167463 167467 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 852924 854256 1332 0.2
RAM 141243 141247 4 0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp FLASH 909200 910104 904 0.1
RAM 145707 145711 4 0.0

@github-actions github-actions bot added the tests label Mar 19, 2025
@gmarcosb gmarcosb force-pushed the camera-webrtc-server branch from 5436ca2 to ff085b5 Compare March 19, 2025 21:07
Copy link

PR #38073: Size comparison from 09dd3ac to ff085b5

Full report (1 build for stm32)
platform target config section 09dd3ac ff085b5 change % change
stm32 light STM32WB5MM-DK FLASH 461160 461160 0 0.0
RAM 141496 141496 0 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant