Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(migration): refactor hardcoded repo and images (#2172, #2181) #2174

Conversation

zdrapela
Copy link
Member

@zdrapela zdrapela commented Jan 13, 2025

Description

Refactor repo name and image.

  • Repository: janus-idp/backstage-showcase => redhat-developer/rhdh
  • Quay.io:janus-idp/backstage-showcase => rhdh-community/rhdh

This fixes this error caused by having hardcoded variables and the repo migration:

cp: cannot stat '/tmp/backstage-showcase/e2e-tests/test-results/*': No such file or directory

Should fix also:

Timed out waiting for Docker image redhat-developer/rhdh:pr-2179-3b39bd3a. Time elapsed: 50 minute(s).

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci openshift-ci bot requested review from josephca and psrna January 13, 2025 15:32
Copy link
Contributor

@josephca josephca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@nickboldt
Copy link
Member

Latest images are at https://quay.io/repository/rhdh-community/rhdh?tab=tags&tag=latest instead of in the janus-idp/backstage-showcase quay location. Please update accordingly.

@nickboldt
Copy link
Member

re: the failure of the PR Build Image test

Run docker/login-action@v3
Error: Username required

This is hopefully caused by the migration from janus-idp to redhat-developer in RHIDP-1022. I'll look into why this works in main but not in release-1.4 today.

@openshift-ci openshift-ci bot removed the lgtm label Jan 14, 2025
@zdrapela zdrapela changed the title chore(ci): refactor hardcoded backstage-showcase in e2e tests (#2172) chore(migration): refactor hardcoded backstage-showcase in e2e tests (#2172) Jan 14, 2025
@zdrapela zdrapela changed the title chore(migration): refactor hardcoded backstage-showcase in e2e tests (#2172) chore(migration): refactor hardcoded repo and images (#2172, #2181) Jan 14, 2025
Copy link
Contributor

Copy link
Member

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but with one minor change to the quay image reference as we don't publish a :latest tag.

Co-authored-by: Nick Boldt <nboldt@redhat.com>
Copy link
Contributor

@zdrapela
Copy link
Member Author

/test e2e-tests

@gustavolira
Copy link
Contributor

/lgtm

Copy link

openshift-ci bot commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gustavolira, josephca, nickboldt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 997b313 into redhat-developer:release-1.4 Jan 15, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants