Skip to content

Subordinate nodes note for Kilted Kaiju. #5426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2025

Conversation

fujitatomoya
Copy link
Collaborator

aligns with ros2/rclcpp#2830

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya self-assigned this Apr 30, 2025
Copy link
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christophebedard can you review this?

Copy link

github-actions bot commented Apr 30, 2025

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/14782965745/artifacts/3046838243.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-5426/index.html in your favorite browser

@christophebedard christophebedard added the backport-all backport at reviewers discretion; from rolling to all versions label Apr 30, 2025
Copy link
Collaborator

@kscottz kscottz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like just a smidge more context here for less versed developers.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Collaborator Author

@kscottz can you review the latest fix?

@kscottz
Copy link
Collaborator

kscottz commented May 2, 2025

LGTM

@kscottz kscottz merged commit 06732ab into rolling May 2, 2025
5 checks passed
@kscottz kscottz deleted the fujitatomoya/subordinate-nodes-note branch May 2, 2025 21:13
mergify bot pushed a commit that referenced this pull request May 2, 2025
* Subordinate nodes note for Kilted Kaiju.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

* add more description including the definition of sub-node.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

---------

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 06732ab)
mergify bot pushed a commit that referenced this pull request May 2, 2025
* Subordinate nodes note for Kilted Kaiju.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

* add more description including the definition of sub-node.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

---------

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 06732ab)
mergify bot pushed a commit that referenced this pull request May 2, 2025
* Subordinate nodes note for Kilted Kaiju.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

* add more description including the definition of sub-node.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

---------

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 06732ab)
ahcorde pushed a commit that referenced this pull request May 2, 2025
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 06732ab)

Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
ahcorde pushed a commit that referenced this pull request May 2, 2025
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 06732ab)

Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
ahcorde pushed a commit that referenced this pull request May 2, 2025
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 06732ab)

Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants