-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Subordinate nodes note for Kilted Kaiju. #5426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christophebedard can you review this?
HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/14782965745/artifacts/3046838243. To view the resulting site:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like just a smidge more context here for less versed developers.
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@kscottz can you review the latest fix? |
LGTM |
* Subordinate nodes note for Kilted Kaiju. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * add more description including the definition of sub-node. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> --------- Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 06732ab)
* Subordinate nodes note for Kilted Kaiju. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * add more description including the definition of sub-node. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> --------- Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 06732ab)
* Subordinate nodes note for Kilted Kaiju. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * add more description including the definition of sub-node. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> --------- Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 06732ab)
aligns with ros2/rclcpp#2830