Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't perform a deep checkout for CI and releases #5465

Closed
expipiplus1 opened this issue Oct 31, 2024 · 3 comments · Fixed by #6410
Closed

Don't perform a deep checkout for CI and releases #5465

expipiplus1 opened this issue Oct 31, 2024 · 3 comments · Fixed by #6410
Assignees
@mkeshavaNV
Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang kind:ci & infra Continuous integration and infrastructure issue
Milestone
Q1 2025 (Winter)

Comments

@expipiplus1
Copy link
Collaborator

we probably don't need the tag for CI and releases should be made from the tagged revision itself

we definitely don't need deep checkout for submodules.
@expipiplus1 expipiplus1 added the kind:ci & infra Continuous integration and infrastructure issue label Oct 31, 2024
@bmillsNV bmillsNV added this to the Q1 2025 (Winter) milestone Oct 31, 2024
@bmillsNV bmillsNV added the goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang label Oct 31, 2024
mkeshavaNV added a commit to mkeshavaNV/slang that referenced this issue Feb 20, 2025
@mkeshavaNV
Do not perform deep checkout of submodules
4f2d316 
Fixes shader-slang#5465
@mkeshavaNV mkeshavaNV mentioned this issue Feb 20, 2025
Merged
@mkeshavaNV
Copy link
Contributor

@expipiplus1 - Seems like we do need a recursive submodule clone? I started off with PR #6410 to address this issue, but I see build errors due to some missing cmake files.

Just to clarify, by deep checkout, you refer to "submodule sync --recursive" being done in the CI pipeline, correct?

Build errors:
https://github.com/shader-slang/slang/actions/runs/13432372816/job/37526896811?pr=6410

@expipiplus1
Copy link
Collaborator Author

I mean, we don't need to check out the history of all the submodules, or probably even the history (maybe to the last tag) of our repo

mkeshavaNV added a commit to mkeshavaNV/slang that referenced this issue Feb 20, 2025
@mkeshavaNV
Do not perform deep checkout of submodules
a8974ac 
Fixes shader-slang#5465
mkeshavaNV added a commit to mkeshavaNV/slang that referenced this issue Feb 20, 2025
@mkeshavaNV
Do not perform deep checkout of submodules
b285149 
Fixes shader-slang#5465
mkeshavaNV added a commit to mkeshavaNV/slang that referenced this issue Feb 20, 2025
@mkeshavaNV
Do not perform deep checkout of submodules
2805006 
Fixes shader-slang#5465
mkeshavaNV added a commit to mkeshavaNV/slang that referenced this issue Feb 20, 2025
@mkeshavaNV
Do not perform deep checkout of submodules
7b77064 
Fixes shader-slang#5465
@mkeshavaNV
Copy link
Contributor

check out the history of all the submodules

@expipiplus1 Got it. I now ensure that we call --depth=1 for submodules. Is there any other way to verify this on the pipeline? I did try to add a git log, but that failed. Can you please check the latest patch on PR #6410

expipiplus1 added a commit to mkeshavaNV/slang that referenced this issue Feb 24, 2025
@expipiplus1
Merge branch 'master' into bugfix/shader-slanggh-5465
002aca9
expipiplus1 added a commit that referenced this issue Feb 24, 2025
@mkeshavaNV @expipiplus1
Do not perform deep checkout of submodules (#6410)
8d02444 
* Do not perform deep checkout of submodules

Fixes #5465

* Remove shallow clone for release as suggested by csyonghe

---------

Co-authored-by: Ellie Hermaszewska <ellieh@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkeshavaNV mkeshavaNV

Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang kind:ci & infra Continuous integration and infrastructure issue
Projects
None yet
Milestone
Q1 2025 (Winter)
Development

Successfully merging a pull request may close this issue.

Do not perform deep checkout of submodules mkeshavaNV/slang
3 participants
@expipiplus1 @mkeshavaNV @bmillsNV