Do not perform deep checkout of submodules #6410
Conversation
mkeshavaNV
force-pushed
the
bugfix/gh-5465
branch
3 times, most recently
from
b285149 to
2805006
Compare
mkeshavaNV
force-pushed
the
bugfix/gh-5465
branch
from
2805006 to
7b77064
Compare
|
Is this PR ready for review? |
Yeah I think so. I wanted one confirmation from @expipiplus1 , but we can get that in the review. I'm not sure how else we can confirm that indeed we are doing a -depth=1 clone of submodules. Setting as "Ready for review". |
.github/workflows/release.yml
Outdated
| @@ -44,7 +44,7 @@ jobs: | |||
| - uses: actions/checkout@v4 | |||
| with: | |||
| submodules: "recursive" | |||
| fetch-depth: "0" | |||
| fetch-depth: "1" # Fetch only the latest commit (shallow clone) | |||
There was a problem hiding this comment.
I think this won’t work for our release CI, which requires a tag to be available so it can use the tag name as the version string during build. If you just do a shallow checkout, we won’t be able to use git describe to retrieve the current release tag.
There was a problem hiding this comment.
To test, you can create a release from your own fork, download the binaries from the release build and run slangc —version, and check if it is reporting the version number correctly from the release tag.
There was a problem hiding this comment.
which requires a tag to be available so it can use the tag name as the version string during build.
I see, ok I will revert the change for the release CI.
Fixes #5465