Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not perform deep checkout of submodules #6410

Merged
merged 3 commits into from
Feb 24, 2025
Merged

Do not perform deep checkout of submodules #6410

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b77064
Do not perform deep checkout of submodules
mkeshavaNV Feb 20, 2025
86d6801
Remove shallow clone for release as suggested by csyonghe
mkeshavaNV Feb 24, 2025
002aca9
Merge branch 'master' into bugfix/gh-5465
expipiplus1 Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ jobs:
- uses: actions/checkout@v4
with:
submodules: "recursive"
fetch-depth: "0"
fetch-depth: "1" # Fetch only the latest commit (shallow clone)
- id: filter
run: |
# This step prevents subsequent steps from running if only documentation was changed
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
- uses: actions/checkout@v4
with:
submodules: "recursive"
fetch-depth: "0"
fetch-depth: "1" # Fetch only the latest commit (shallow clone)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this won’t work for our release CI, which requires a tag to be available so it can use the tag name as the version string during build. If you just do a shallow checkout, we won’t be able to use git describe to retrieve the current release tag.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To test, you can create a release from your own fork, download the binaries from the release build and run slangc —version, and check if it is reporting the version number correctly from the release tag.

Copy link
Contributor Author

@mkeshavaNV mkeshavaNV Feb 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which requires a tag to be available so it can use the tag name as the version string during build.

I see, ok I will revert the change for the release CI.

- name: Setup
uses: ./.github/actions/common-setup
with:
Expand Down
Loading