Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slang raytracing test #6404

Merged
merged 7 commits into from
Feb 21, 2025

Conversation

ksavoie-nv
Copy link
Contributor

TestRenderApp is missing handling for raytracing tests in a few places, causing the test tests/pipeline/ray-tracing/raygen.slang (cuda) to fail. This PR adds the missing handling, fixing the test.

RenderTestApp is missing handling for RayTracing in a few places.
@ksavoie-nv ksavoie-nv requested a review from a team as a code owner February 19, 2025 19:54
@CLAassistant
Copy link

CLAassistant commented Feb 19, 2025

CLA assistant check
All committers have signed the CLA.

@cheneym2
Copy link
Collaborator

Does CI pass if you enable optix tests by default? I think it's this in slang-test:
https://github.com/shader-slang/slang/blob/master/tools/slang-test/slang-test-main.cpp#L4902

csyonghe
csyonghe previously approved these changes Feb 19, 2025
@csyonghe csyonghe added the pr: non-breaking PRs without breaking changes label Feb 19, 2025
@ksavoie-nv
Copy link
Contributor Author

Looks like raygen does not pass. Is that expected ?

No, it passed for me locally. I'll investigate.

@cheneym2
Copy link
Collaborator

I confirmed also that this PR works and it seems to be an issue with the CI machine's optix installation. Seems like that could be handled subsequently and just get the original fix merged without that bit.

@cheneym2
Copy link
Collaborator

This also shows that missing a proper OptiX installation causes unexpected failures in slang-test. I think the symptom should have been that optix tests are unsupported and skipped rather than fail. There was really no way to tell that optix wasn't being found as it stands.

@cheneym2 cheneym2 enabled auto-merge (squash) February 21, 2025 01:31
@cheneym2
Copy link
Collaborator

@ksavoie-nv please re-run the failed windows release test. Looks like a spurious failure.

@cheneym2 cheneym2 merged commit 0101e5a into shader-slang:master Feb 21, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants