-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix slang raytracing test #6404
Fix slang raytracing test #6404
Conversation
RenderTestApp is missing handling for RayTracing in a few places.
Does CI pass if you enable optix tests by default? I think it's this in slang-test: |
No, it passed for me locally. I'll investigate. |
I confirmed also that this PR works and it seems to be an issue with the CI machine's optix installation. Seems like that could be handled subsequently and just get the original fix merged without that bit. |
This reverts commit d142068.
This also shows that missing a proper OptiX installation causes unexpected failures in slang-test. I think the symptom should have been that optix tests are unsupported and skipped rather than fail. There was really no way to tell that optix wasn't being found as it stands. |
@ksavoie-nv please re-run the failed windows release test. Looks like a spurious failure. |
TestRenderApp is missing handling for raytracing tests in a few places, causing the test
tests/pipeline/ray-tracing/raygen.slang (cuda)
to fail. This PR adds the missing handling, fixing the test.